From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F24DC4320A for ; Mon, 2 Aug 2021 23:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7663E60EC0 for ; Mon, 2 Aug 2021 23:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233260AbhHBXqR (ORCPT ); Mon, 2 Aug 2021 19:46:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232576AbhHBXqP (ORCPT ); Mon, 2 Aug 2021 19:46:15 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5796C06175F for ; Mon, 2 Aug 2021 16:46:05 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id e4so17566890ybn.2 for ; Mon, 02 Aug 2021 16:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YFen2a45R4zylZ5qIL4DVKtH1qD/CEYQohUeJ2fIXYE=; b=K2qSnv70To4LaSCdj95R8BywMdScv43S8+f6gqhC4b0dowiA8S/jofRv6VSdH/uYi9 TRc02yj0eWBkHhr2np5dDbEe1Z62wQUgleAdcOpEaI9MqMjXw3MdwrW7Cjk+flN+wOr/ IYaV6Fz1GIZzSEgVV+ZEybtXI9Z3qKltq1jJf+YH60WImY6hQ31QTryNmqlzHgVxrGGP v4D4djcLSrNJ2Rcz1MDTzKKMH074YME/UANXrkGIYYYXE7gVw24XjNFNQ4J14rUsDE9U LC4COmdip1DP/3zHPcSY7n7MRRVrvpCddiW555ijiyZ/mKZML4kifeCRjQ3kuDaYCQg6 B2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFen2a45R4zylZ5qIL4DVKtH1qD/CEYQohUeJ2fIXYE=; b=VGnL2Vy0zpu2O0JXaAC87uKRwHavpwE9MNRfOu8fLN9OfPctjsP4cACH4GzCN0H84v 4620GEKBgYxKmtFLZBHn/X+sR7M49b35Y07IgAY8I6qnByIFOARsGV9rPJDaXXF6ZGEi TRSUKgg/M7QnIORQnemj4kBiQNvW0/eiVEQy6F68S5HxT8J/6w6nW72qWoLwEvmKZL8z orEql7TfyGC6O8qCqcjATirFTV8mpdjm4SoDjn1qOSJFA7rGFWasSFa2QVpIXJHhZwju mF4B7P/GmR6sLxtN+wjpWKEKVGn60PudBv8lZpYmNWZwPC0cCycTpXk+Z1GcgU+MatjR 4hBA== X-Gm-Message-State: AOAM5306coHfPnlF5uVZLlf10VMfi+zcj6HGaQAdFR/VTgTtBUxHfjDN iDuVTmdtc1yVPNTwoWPpp7+8gfkW/3PP03BOPRhqiA== X-Google-Smtp-Source: ABdhPJxUFP4kJAwxVZdGUB2z7l2xV/z+hhj6fqS7XIiwm/EVFKwreCRXhIjFT4N5XKhulNOO3AkM7pChtnlG/IL9xLc= X-Received: by 2002:a25:dcd1:: with SMTP id y200mr23800031ybe.92.1627947964806; Mon, 02 Aug 2021 16:46:04 -0700 (PDT) MIME-Version: 1.0 References: <20210730225939.3852712-1-mizhang@google.com> <20210730225939.3852712-4-mizhang@google.com> In-Reply-To: From: Mingwei Zhang Date: Mon, 2 Aug 2021 16:45:53 -0700 Message-ID: Subject: Re: [PATCH v3 3/3] KVM: x86/mmu: Add detailed page size stats To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm , LKML , Ben Gardon , Jing Zhang , David Matlack Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Looks good, but you'll probably need/want to rebase to kvm/queue once that settles > down (I suspect a forced push is coming this week). This has quite a few conflicts > with other stuff sitting in kvm/queue. will do. > > @@ -235,9 +235,12 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = { > > STATS_DESC_COUNTER(VM, mmu_recycled), > > STATS_DESC_COUNTER(VM, mmu_cache_miss), > > STATS_DESC_ICOUNTER(VM, mmu_unsync), > > - STATS_DESC_ICOUNTER(VM, lpages), > > STATS_DESC_ICOUNTER(VM, nx_lpage_splits), > > - STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions) > > + STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions), > > + STATS_DESC_ICOUNTER(VM, pages_4k), > > + STATS_DESC_ICOUNTER(VM, pages_2m), > > + STATS_DESC_ICOUNTER(VM, pages_1g), > > + STATS_DESC_ICOUNTER(VM, pages_512g) > > Uber nit that I wouldn't even have noticed if this didn't conflict, but there's > no need to land the union and the stats definitions at the end of the structs, > i.e. the new fields can directly replace lpages. I don't think it will actually > avoid a conflict, but it would avoid modifying the max_mmu_page_hash_collisions > line. > ah, so I will just remove 'lpages' and put new lines in place instead appending those at the end. Yeah, I did not know that it can create conflicts. So, I will change that.