From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8336C432BE for ; Tue, 17 Aug 2021 18:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0DA560F5E for ; Tue, 17 Aug 2021 18:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbhHQSJJ (ORCPT ); Tue, 17 Aug 2021 14:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232807AbhHQSJD (ORCPT ); Tue, 17 Aug 2021 14:09:03 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E64C0613CF for ; Tue, 17 Aug 2021 11:08:30 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id g26so75370ybe.0 for ; Tue, 17 Aug 2021 11:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ONK5GMsw6Z2jdg3q0ewBdbX45fnfcEKY0NCemn7k1jM=; b=W7uFNzyv5JEkceJi8ykWuavNKT3LRNaAW+qfvyOSlC4c79sfmcjNvIgjAX92pLdVeN z0tj8+4pswB44jPoA9YarDqFKcnJ4BxzA0uEwXSg8RnmAmcuPWpRye7zq0GKtD516Ml8 Tc/hnFWZJttrk5ekh3JxShTRPIrGZG4oWG0wqq+hWmc+1jKt/NQ/Os/6yh6QD0+3dgii 3AFRb6sgZpzYbiD7VxnSnUZWqn5QuJJDFLoHuWHd1bExcYu8BEt3x0WZvKGiUnN78ewQ J9HEtEHRrzwOrvdI85B5jvmZUHdLvVCopwgdjq6l622eRLrF1m66fxkEqdxCwK5CPheX DxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ONK5GMsw6Z2jdg3q0ewBdbX45fnfcEKY0NCemn7k1jM=; b=aDfeGQazms0LS3kxZcTlgXWTJlpgLGgdq9cBlWhuJ18Pzy1sHdbGNePZ/ychLq8T5i XLRXt9o9WcwAaiA+mHFm8Pj85ipm0TNLJ9n3IJ9RKd/JyAR77RRmgI6cCiCeHbOkBMhN lvlKqx0rMgr4B9qB/D65fmt48TWBOeeqr2Q+KJ/PFJOBjOoMyqgsY97O+bczm7FghHO9 jQ4lWWBgmgB+72RnHLIXlrSneJx96DbTnrnBNNtf5t1Tj0avNy8aiDwYdghfOm1EMI6q QySAZmQsr441Zq0V1lvowwqp5IhvQ6Tp0B4W8+TdR4HhZqMhipYqv/dutRCcTJoUk/JN JP8g== X-Gm-Message-State: AOAM5325qf3+3yADH4pyJJszF172ajmA0y/GZX/XpjN4kJ3Ew3on8Oe1 Er9VAg63PaEw1YZjJIU+KxkzvHKanpyrJI0Uyaet9A== X-Google-Smtp-Source: ABdhPJxsGzUlxMjKR3elob/wHPc1HBxtF4Y+RRC8pe7iDaGSGTLe46suMf8KgSl+hgtGHEd8la8rZoAK0KwAKG/BF+k= X-Received: by 2002:a25:d88e:: with SMTP id p136mr5994164ybg.92.1629223709541; Tue, 17 Aug 2021 11:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20210816202441.4098523-1-mizhang@google.com> In-Reply-To: From: Mingwei Zhang Date: Tue, 17 Aug 2021 11:08:18 -0700 Message-ID: Subject: Re: [PATCH 0/3] clean up interface between KVM and psp To: Paolo Bonzini Cc: Brijesh Singh , Tom Lendacky , John Allen , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm , linux-crypto@vger.kernel.org, LKML , Alper Gun , Borislav Petkov , David Rienjes , Marc Orr , Peter Gonda , Vipin Sharma Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, Thanks for the prompt reply. I will update the code and will be waiting for Tom and other AMD folks' feedback. Thanks. Regards -Mingwei On Tue, Aug 17, 2021 at 1:54 AM Paolo Bonzini wrote: > > On 16/08/21 22:24, Mingwei Zhang wrote: > > This patch set is trying to help make the interface between KVM and psp > > cleaner and simpler. In particular, the patches do the following > > improvements: > > - avoid the requirement of psp data structures for some psp APIs. > > - hide error handling within psp API, eg., using sev_decommission. > > - hide the serialization requirement between DF_FLUSH and DEACTIVATE. > > > > Mingwei Zhang (3): > > KVM: SVM: move sev_decommission to psp driver > > KVM: SVM: move sev_bind_asid to psp > > KVM: SVM: move sev_unbind_asid and DF_FLUSH logic into psp > > No objections apart from the build failure on patch 1. However, it's up > to Tom whether they prefer this logic in KVM or the PSP driver. > > Paolo >