LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mingwei Zhang <mizhang@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm <kvm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Matlack <dmatlack@google.com>,
	Jing Zhang <jingzhangos@google.com>, Peter Xu <peterx@redhat.com>,
	Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 1/2] selftests: KVM: align guest physical memory base address to 1GB
Date: Mon, 6 Sep 2021 12:56:46 -0700	[thread overview]
Message-ID: <CAL715WJBMe8tPX=Tch_v=LiGNjPZpCqQVZKM=8GtzaJ_6Q1bXg@mail.gmail.com> (raw)
In-Reply-To: <YS5e4PGxu7tjiEBI@google.com>

> 1gb may not be appropriate for all architectures and we don't want to _just_
> test 1gb aligned memslots.  The alignment should be tied to the backing store,
> even if the test is hardcoded to use THP, that way the alignment logic works
> without modification if the backing store is changed.

Agree on that.
>
> I had a patch[1] that did this, let me go resurrect that series.  My series got
> put on the backburner in favor of Yanan's series[2] which did a much better
> job of identifying/handling the host virtual address alignment, but IIRC my
> approach for handling GPA was correct.
>
> [1] https://lore.kernel.org/kvm/20210210230625.550939-6-seanjc@google.com/
> [2] https://lkml.kernel.org/r/20210330080856.14940-1-wangyanan55@huawei.com
>

Thanks for the info. I will use patch [1] instead of mine in the next version.

Regards.
-Mingwei

  reply	other threads:[~2021-09-06 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 18:26 [PATCH v2 0/2] selftests: verify page stats in kvm x86/mmu Mingwei Zhang
2021-08-29 18:26 ` [PATCH v2 1/2] selftests: KVM: align guest physical memory base address to 1GB Mingwei Zhang
2021-08-31 16:54   ` Sean Christopherson
2021-09-06 19:56     ` Mingwei Zhang [this message]
2021-08-29 18:26 ` [PATCH v2 2/2] selftests: KVM: use dirty logging to check if page stats work correctly Mingwei Zhang
2021-08-30  4:02   ` kernel test robot
2021-08-30  4:42     ` Mingwei Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL715WJBMe8tPX=Tch_v=LiGNjPZpCqQVZKM=8GtzaJ_6Q1bXg@mail.gmail.com' \
    --to=mizhang@google.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=jingzhangos@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=seanjc@google.com \
    --subject='Re: [PATCH v2 1/2] selftests: KVM: align guest physical memory base address to 1GB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).