LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 2/2] kselftests: timers: Reduce default runtime on inconsistency-check and set-timer-lat
Date: Thu, 26 Mar 2015 09:20:42 -0700	[thread overview]
Message-ID: <CALAqxLV+rcYYiR2PtGcJs=A4cu4PxxoTdm5tqAHd=fWZCyguqQ@mail.gmail.com> (raw)
In-Reply-To: <5513EE54.5090203@redhat.com>

On Thu, Mar 26, 2015 at 4:32 AM, Prarit Bhargava <prarit@redhat.com> wrote:
> On 03/25/2015 07:44 PM, John Stultz wrote:
>> For the default run_timers target, the timers tests takes the
>> majority of kselftests runtime.
>>
>> So this patch reduces the default runtime for inconsistentcy-check
>> and set-timer-lat, which reduced the runtime almost in half.
>>
>> Before:       11m48.629s
>> After:        6m47.723s
>>
>> Cc: Shuah Khan <shuahkh@osg.samsung.com>
>> Cc: Prarit Bhargava <prarit@redhat.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>> ---
>>  tools/testing/selftests/timers/inconsistency-check.c | 2 +-
>>  tools/testing/selftests/timers/set-timer-lat.c       | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
>> index 578e423a..caf1bc9 100644
>> --- a/tools/testing/selftests/timers/inconsistency-check.c
>> +++ b/tools/testing/selftests/timers/inconsistency-check.c
>> @@ -166,7 +166,7 @@ int main(int argc, char *argv[])
>>       int clockid, opt;
>>       int userclock = CLOCK_REALTIME;
>>       int maxclocks = NR_CLOCKIDS;
>> -     int runtime = 30;
>> +     int runtime = 10;
>>       struct timespec ts;
>>
>
> Oops ... left everyone off :)
>
> What was the reason that this was originally 30?  Or was that overkill?

So time inconsistencies (when they manifest, which ideally is never)
can be fairly rare events. In the past we've seen them due to cpu TSC
skew and drift, which requires enough scheduler noise to pop the
process around between cores enough to notice, and enough system
runtime for the TSCs to drift far enough apart.. Or we've had tiny
accumulation bugs in update_wall_time which requires the right phase
in the error accumulation to align with an irq. So the consistency
test has always been a long running test (originally I'd run it
overnight), and the 30sec interval here was added just so there was
some "long enough" interval that wasn't too painful for me to test
submitted patches with.  Now that more folks are using it (and they
likely care less), we can cut it down further to avoid making test
runs too onerous.

Now, a patch might badly break things and it would be immediately
obvious to the test that something is wrong, so a quick check isn't
worthless, but it just doesn't instill that much confidence from me.

I think as the kselftests grow, we'll have more "types" of test
targets to run (quick, long, stress, etc), and we can scale the time
in those tests accordingly. But the default should probably lean
towards the short side.

thanks
-john

  reply	other threads:[~2015-03-26 16:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 23:44 [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM John Stultz
2015-03-25 23:44 ` [PATCH 2/2] kselftests: timers: Reduce default runtime on inconsistency-check and set-timer-lat John Stultz
2015-03-26 11:32   ` Prarit Bhargava
2015-03-26 16:20     ` John Stultz [this message]
2015-03-31 16:01       ` Shuah Khan
2015-03-31 19:47         ` Shuah Khan
2015-03-26 11:31 ` [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM Prarit Bhargava
2015-03-26 16:29   ` John Stultz
2015-03-26 17:33     ` Tyler Baker
2015-04-02 10:18       ` Prarit Bhargava
2015-04-02 13:43         ` Shuah Khan
2015-04-02 17:17           ` Tyler Baker
2015-04-02 17:48             ` Shuah Khan
2015-04-02 18:58               ` Tyler Baker
2015-04-02 18:02         ` John Stultz
2015-04-07 14:20           ` Prarit Bhargava
2015-04-08  4:03           ` Michael Ellerman
2015-04-02 10:14     ` Prarit Bhargava
2015-03-31 15:55   ` Shuah Khan
2015-04-02  3:42     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLV+rcYYiR2PtGcJs=A4cu4PxxoTdm5tqAHd=fWZCyguqQ@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 2/2] kselftests: timers: Reduce default runtime on inconsistency-check and set-timer-lat' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).