LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Al Viro <viro@zeniv.linux.org.uk>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext
Date: Fri, 11 Jul 2014 11:39:41 -0700	[thread overview]
Message-ID: <CALCETrWMgTET6MZwaH4D4tOg2v1kV6ozBnjGTGrecnMWJbkUEg@mail.gmail.com> (raw)
In-Reply-To: <20140711181212.GT18735@two.firstfloor.org>

On Fri, Jul 11, 2014 at 11:12 AM, Andi Kleen <andi@firstfloor.org> wrote:
>> diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h
>> index 076b11f..df9908b 100644
>> --- a/arch/x86/include/uapi/asm/sigcontext.h
>> +++ b/arch/x86/include/uapi/asm/sigcontext.h
>
> I don't think renaming fields in uapi/asm is acceptable. These
> are likely used by user programs and you'll break compiles.

Hmm.  That's a fair point.  On the other hand, any user code that uses
these fields explicitly may already be broken, since the current names
of these fields rather strongly imply that they do something.

Is there any clear policy on minor API breaks in the UAPI headers that
don't affect ABI?

--Andy

  reply	other threads:[~2014-07-11 18:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 16:29 [PATCH 0/2] x86_64,signal: Fix the set of saved segment registers Andy Lutomirski
2014-07-11 16:29 ` [PATCH 1/2] x86_64,signal: Save and restore SS in signal frames Andy Lutomirski
2015-03-09 20:15   ` Andy Lutomirski
2014-07-11 16:29 ` [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext Andy Lutomirski
2014-07-11 18:12   ` Andi Kleen
2014-07-11 18:39     ` Andy Lutomirski [this message]
2014-07-12  2:09       ` H. Peter Anvin
2014-07-12  2:04   ` H. Peter Anvin
2014-07-12  2:21   ` Linus Torvalds
2014-07-12  2:26     ` H. Peter Anvin
2014-07-12  8:39     ` Andy Lutomirski
2014-07-12 18:37       ` Andi Kleen
2014-07-12 18:40         ` H. Peter Anvin
2014-07-12 18:52           ` Andi Kleen
2014-07-12 21:17             ` Andy Lutomirski
2014-07-18  1:13               ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrWMgTET6MZwaH4D4tOg2v1kV6ozBnjGTGrecnMWJbkUEg@mail.gmail.com \
    --to=luto@amacapital.net \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 2/2] x86_64,signal: Remove '\''fs'\'' and '\''gs'\'' from sigcontext' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).