LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Jiri Kosina <trivial@kernel.org>,
	Linux HWMON List <linux-hwmon@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices
Date: Mon, 23 Aug 2021 16:12:22 -0500	[thread overview]
Message-ID: <CAL_Jsq+EXrMRFSwQKW2SOO2fgB48ACD6yXaujat9AbgxdG0_BA@mail.gmail.com> (raw)
In-Reply-To: <fffdaaad-ac75-5c2f-6a31-7cdc3e57de20@roeck-us.net>

On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max31785 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >   .../devicetree/bindings/hwmon/max31785.txt    | 22 -------------------
>
> Not sure if that is a good idea. It would make more sense to standardize the
> properties needed by the driver/chip instead (see existing dts files in the kernel).

This device is certainly not trivial, the binding is just incomplete.

Device specific fan controller bindings are something I'm just going
to reject until someone comes up with something common.

Rob

  reply	other threads:[~2021-08-23 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 18:25 [PATCH 1/2] dt-bindings: hwmon: merge max1619 " Krzysztof Kozlowski
2021-08-19 18:25 ` [PATCH 2/2] dt-bindings: hwmon: merge max31785 " Krzysztof Kozlowski
2021-08-20 14:23   ` Guenter Roeck
2021-08-23 21:12     ` Rob Herring [this message]
2021-08-20 14:26 ` [PATCH 1/2] dt-bindings: hwmon: merge max1619 " Guenter Roeck
2021-08-23 21:19   ` Rob Herring
2021-08-31 15:21 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+EXrMRFSwQKW2SOO2fgB48ACD6yXaujat9AbgxdG0_BA@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=trivial@kernel.org \
    --subject='Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).