From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC4FC432BE for ; Tue, 31 Aug 2021 13:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A16F61027 for ; Tue, 31 Aug 2021 13:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239747AbhHaNv1 (ORCPT ); Tue, 31 Aug 2021 09:51:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:44784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239133AbhHaNvW (ORCPT ); Tue, 31 Aug 2021 09:51:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CFE361027; Tue, 31 Aug 2021 13:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630417827; bh=9enbDHRItSEBVqHTy4fYhbDScEEUguUhNhfZuTRNQLo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EPR06hAJKymadfuLFq6bEcXviID2XR2bAf4H8YvO37aoVEz5i1bQK2XY40l5Nn8+b NzZjmBn+7WMQzFw9SCELCWbPFinXfb3nbsOgxv/m3iS0RE2WGP/DiJFpKFGB83NiIt wyu0tZK8sZ9nMamUsPZ9QBC7jGics/WENLVQukyPAJu1oWuFvzOOfuYfHW3O4a0yla MJN8XGUPSOBqSJ8cYmXLLRIip7REiFg8tpVVO87PETnaOb5KCxRy8culSd1UkGpSwA jY6O/b96sHZq7xOQWr7LfduJ5oHI3CtArDlPn1PuhvkIkyKGB6jRU83QRHrQsK32G/ +XtCAxRkQYsmg== Received: by mail-ed1-f47.google.com with SMTP id r7so10920433edd.6; Tue, 31 Aug 2021 06:50:27 -0700 (PDT) X-Gm-Message-State: AOAM530Jm2vWNpYveWC2gLQ8SDYTSey0kJP92izNmgcniWh8wxTogwJd YtV2nNi025fQkEMpjC1Z9rYVAIxK0gDE3JdL9Q== X-Google-Smtp-Source: ABdhPJyYQShfn4w//yBf35+yfTgcoefHDREub/IZd9p9I+kmPPLux1ziBhWsKoLgqZF+WYKcr17QvaJhdiBcbfB5HaI= X-Received: by 2002:aa7:d1d3:: with SMTP id g19mr29465236edp.373.1630417826265; Tue, 31 Aug 2021 06:50:26 -0700 (PDT) MIME-Version: 1.0 References: <20210831125843.1233488-1-nsaenzju@redhat.com> <20210831125843.1233488-2-nsaenzju@redhat.com> In-Reply-To: <20210831125843.1233488-2-nsaenzju@redhat.com> From: Rob Herring Date: Tue, 31 Aug 2021 08:50:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address To: Nicolas Saenz Julienne Cc: Nicolas Saenz Julienne , Florian Fainelli , Greg Kroah-Hartman , devicetree@vger.kernel.org, "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Stefan Wahren Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 7:59 AM Nicolas Saenz Julienne wrote: > > The unit address is supposed to represent ','. Which > are both 0 for RPi4b's XHCI controller. On top of that although > OpenFirmware states bus number goes in the high part of the last reg > parameter, FDT doesn't seem to care for it[1], so remove it. > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 > Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") > Suggested-by: Rob Herring > Signed-off-by: Nicolas Saenz Julienne > --- > > Chages since v1: > - Add patch as per robh suggestion > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring