LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6
@ 2017-12-22 10:43 Türk, Jan
  2017-12-26 17:25 ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Türk, Jan @ 2017-12-22 10:43 UTC (permalink / raw)
  To: 'Rob Herring'
  Cc: Mark Rutland, Thierry Reding, David Airlie, Russell King,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Andreas Färber,
	Kevin Hilman, Maxime Ripard, Alexandre Belloni, SZ Lin,
	Greg Kroah-Hartman, devicetree, linux-kernel, dri-devel,
	LinuxArmKernelMailingListe

> Von: Rob Herring [mailto:robh@kernel.org]
> Gesendet: Freitag, 22. Dezember 2017 00:00
> Betreff: Re: [PATCH v2 1/5] drm/panel: Add support for the EDT
> ETM0700G0BDH6
> 
> On Wed, Dec 20, 2017 at 02:47:01PM +0100, jan.tuerk@emtrion.com wrote:
> > From: Jan Tuerk <jan.tuerk@emtrion.com>
> >
> > The Emerging Display Technology ETM0700G0BDH6 is exactly the same
> > display as the ETM0700G0DH6, exept the pixelclock polarity. Therefore
> > re-use the ETM0700G0DH6 modes. It is used by default on emtrion Avari
> > based development kits.
> 
> As I asked on v1, why not document the panels together in a single doc?

As denoted in the cover letter:
>The documentation for the EDT display is kept as an extra file currently,
>as it is done by the most displays in the documentation. Also a new 
>new Variant of the EDT already arrived. So merging their documentations
>should be discussed separately.

I think it will be even a little tricky to find a matching filename for both versions,
as the recent ones adding an extra character in the description. Are you expecting sth. 
like edt,etm0700series.txt?

> 
> >
> > Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com>
> > ---
> >  .../bindings/display/panel/edt,etm0700g0bdh6.txt          |  9 +++++++++
> >  drivers/gpu/drm/panel/panel-simple.c                      | 15 +++++++++++++++
> >  2 files changed, 24 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6
  2017-12-22 10:43 [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 Türk, Jan
@ 2017-12-26 17:25 ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-12-26 17:25 UTC (permalink / raw)
  To: Türk, Jan
  Cc: Mark Rutland, Thierry Reding, David Airlie, Russell King,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Andreas Färber,
	Kevin Hilman, Maxime Ripard, Alexandre Belloni, SZ Lin,
	Greg Kroah-Hartman, devicetree, linux-kernel, dri-devel,
	LinuxArmKernelMailingListe

On Fri, Dec 22, 2017 at 4:43 AM, Türk, Jan <Jan.Tuerk@emtrion.de> wrote:
>> Von: Rob Herring [mailto:robh@kernel.org]
>> Gesendet: Freitag, 22. Dezember 2017 00:00
>> Betreff: Re: [PATCH v2 1/5] drm/panel: Add support for the EDT
>> ETM0700G0BDH6
>>
>> On Wed, Dec 20, 2017 at 02:47:01PM +0100, jan.tuerk@emtrion.com wrote:
>> > From: Jan Tuerk <jan.tuerk@emtrion.com>
>> >
>> > The Emerging Display Technology ETM0700G0BDH6 is exactly the same
>> > display as the ETM0700G0DH6, exept the pixelclock polarity. Therefore
>> > re-use the ETM0700G0DH6 modes. It is used by default on emtrion Avari
>> > based development kits.
>>
>> As I asked on v1, why not document the panels together in a single doc?
>
> As denoted in the cover letter:

I generally don't read cover letters...

>>The documentation for the EDT display is kept as an extra file currently,
>>as it is done by the most displays in the documentation. Also a new
>>new Variant of the EDT already arrived. So merging their documentations
>>should be discussed separately.

You mean a 3rd variant?

> I think it will be even a little tricky to find a matching filename for both versions,
> as the recent ones adding an extra character in the description. Are you expecting sth.
> like edt,etm0700series.txt?

Yeah, or edt,etm0700g0.txt.

Rob

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6
  2017-12-20 13:47   ` [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
@ 2017-12-21 22:59     ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-12-21 22:59 UTC (permalink / raw)
  To: jan.tuerk
  Cc: Mark Rutland, Thierry Reding, David Airlie, Russell King,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Andreas Färber,
	Kevin Hilman, Maxime Ripard, Alexandre Belloni, SZ Lin,
	Greg Kroah-Hartman, devicetree, linux-kernel, dri-devel,
	linux-arm-kernel

On Wed, Dec 20, 2017 at 02:47:01PM +0100, jan.tuerk@emtrion.com wrote:
> From: Jan Tuerk <jan.tuerk@emtrion.com>
> 
> The Emerging Display Technology ETM0700G0BDH6 is exactly
> the same display as the ETM0700G0DH6, exept the pixelclock
> polarity. Therefore re-use the ETM0700G0DH6 modes. It is
> used by default on emtrion Avari based development kits.

As I asked on v1, why not document the panels together in a single doc?

> 
> Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com>
> ---
>  .../bindings/display/panel/edt,etm0700g0bdh6.txt          |  9 +++++++++
>  drivers/gpu/drm/panel/panel-simple.c                      | 15 +++++++++++++++
>  2 files changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6
  2017-12-20 13:47 ` [PATCH v2 " jan.tuerk
@ 2017-12-20 13:47   ` jan.tuerk
  2017-12-21 22:59     ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: jan.tuerk @ 2017-12-20 13:47 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Thierry Reding, David Airlie,
	Russell King, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Andreas Färber, Kevin Hilman, Maxime Ripard,
	Alexandre Belloni, SZ Lin, Greg Kroah-Hartman, devicetree,
	linux-kernel, dri-devel, linux-arm-kernel

From: Jan Tuerk <jan.tuerk@emtrion.com>

The Emerging Display Technology ETM0700G0BDH6 is exactly
the same display as the ETM0700G0DH6, exept the pixelclock
polarity. Therefore re-use the ETM0700G0DH6 modes. It is
used by default on emtrion Avari based development kits.

Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com>
---
 .../bindings/display/panel/edt,etm0700g0bdh6.txt          |  9 +++++++++
 drivers/gpu/drm/panel/panel-simple.c                      | 15 +++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt

diff --git a/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt
new file mode 100644
index 000000000000..099e30bfa17f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt
@@ -0,0 +1,9 @@
+Emerging Display Technology Corp. ETM0700G0BDH6 7.0" WVGA TFT LCD panel
+
+Required properties:
+	compatible: "edt,etm0700g0bdh6"
+
+This panel is exactly the same as ETM0700G0DH6 except the pixelclock polarity.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index b7c4709f7b34..42442034b53e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -886,6 +886,18 @@ static const struct panel_desc edt_etm0700g0dh6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
 };
 
+static const struct panel_desc edt_etm0700g0bdh6 = {
+	.modes = &edt_etm0700g0dh6_mode,
+	.num_modes = 1,
+	.bpc = 6,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
 static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
 	.clock = 32260,
 	.hdisplay = 800,
@@ -2029,6 +2041,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "edt,etm0700g0dh6",
 		.data = &edt_etm0700g0dh6,
 	}, {
+		.compatible = "edt,etm0700g0bdh6",
+		.data = &edt_etm0700g0bdh6,
+	}, {
 		.compatible = "foxlink,fl500wvr00-a0t",
 		.data = &foxlink_fl500wvr00_a0t,
 	}, {
-- 
emtrion GmbH
Alter Schlachthof 45
76131 Karlsruhe
GERMANY
https://www.emtrion.de

Amtsgericht Mannheim
HRB 110 300
Geschäftsführer: Dieter Baur, Ramona Maurer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-26 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22 10:43 [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 Türk, Jan
2017-12-26 17:25 ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2017-11-23 12:55 [PATCH 0/5] Add basic support for emtrion emCON-MX6 modules Jan Tuerk
2017-12-20 13:47 ` [PATCH v2 " jan.tuerk
2017-12-20 13:47   ` [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
2017-12-21 22:59     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).