LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chris <chrisrblake93@gmail.com>
To: ptyser@xes-inc.com, Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Christian Lamparter <chunkeey@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
Date: Fri, 2 Jul 2021 07:25:21 -0500 [thread overview]
Message-ID: <CALpBJjqfgQ2HfbF2qzGBjoGkq-TiK5rKUvs=cMwaUL7NtkoRrw@mail.gmail.com> (raw)
In-Reply-To: <20210607233535.4198-1-chrisrblake93@gmail.com>
On Mon, Jun 7, 2021 at 6:35 PM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
>
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Co-developed-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>
> Changelog:
> V3: Update commit message format and update contributor message.
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
> V1: Initial Patch
>
> drivers/mfd/lpc_ich.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 3bbb29a7e7a5..f10e53187f67 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
> [LPC_DH89XXCC] = {
> .name = "DH89xxCC",
> .iTCO_version = 2,
> + .gpio_version = ICH_V5_GPIO,
> },
> [LPC_PPT] = {
> .name = "Panther Point",
> --
> 2.25.1
>
Hello,
Just curious if there's anything I can do to help get this reviewed
for merge, thanks.
Regards,
Chris B
next prev parent reply other threads:[~2021-07-02 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 23:35 Chris Blake
2021-07-02 12:25 ` Chris [this message]
2021-07-02 12:45 ` Lee Jones
2021-07-20 14:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALpBJjqfgQ2HfbF2qzGBjoGkq-TiK5rKUvs=cMwaUL7NtkoRrw@mail.gmail.com' \
--to=chrisrblake93@gmail.com \
--cc=chunkeey@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--subject='Re: [PATCH v3] mfd: lpc_ich: Enable GPIO driver for DH89xxCC' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).