LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shakeel Butt <shakeelb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@surriel.com>, Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH] mm: vmscan: fix missing psi annotation for node_reclaim()
Date: Thu, 19 Aug 2021 08:04:19 -0700	[thread overview]
Message-ID: <CALvZod5y4WquXhH6BdVAyqMNqxCm=RGkOk-iBkRuW0uQPCz_1g@mail.gmail.com> (raw)
In-Reply-To: <20210818152457.35846-1-hannes@cmpxchg.org>

On Wed, Aug 18, 2021 at 8:26 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> In a debugging session the other day, Rik noticed that node_reclaim()
> was missing memstall annotations. This means we'll miss pressure and
> lost productivity resulting from reclaim on an overloaded local NUMA
> node when vm.zone_reclaim_mode is enabled.
>
> There haven't been any reports, but that's likely because
> vm.zone_reclaim_mode hasn't been a commonly used feature recently, and
> the intersection between such setups and psi users is probably
> nil. Although, secondary memory such as CXL-connected DIMMS,
> persistent memory etc. and the page demotion patches that handle them
> (https://lore.kernel.org/lkml/20210401183216.443C4443@viggo.jf.intel.com/)
> could soon make this a more common codepath again.
>
> Reported-by: Rik van Riel <riel@surriel.com>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Shakeel Butt <shakeelb@google.com>

      reply	other threads:[~2021-08-19 15:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 15:24 Johannes Weiner
2021-08-19 15:04 ` Shakeel Butt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALvZod5y4WquXhH6BdVAyqMNqxCm=RGkOk-iBkRuW0uQPCz_1g@mail.gmail.com' \
    --to=shakeelb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    --subject='Re: [PATCH] mm: vmscan: fix missing psi annotation for node_reclaim()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).