From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbeCWT1R (ORCPT ); Fri, 23 Mar 2018 15:27:17 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46984 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbeCWT1O (ORCPT ); Fri, 23 Mar 2018 15:27:14 -0400 X-Google-Smtp-Source: AG47ELvZI7w/Jb3T5so51b/+1hN2wKEvhpTU8jCoo8Pd4V/Gx/fga3f0DQE0/O1mLl/jSUySWDvVVooHBAGlbkODFms= MIME-Version: 1.0 In-Reply-To: References: <20180323180903.33B17168@viggo.jf.intel.com> <20180323180911.E43ACAB8@viggo.jf.intel.com> From: Shakeel Butt Date: Fri, 23 Mar 2018 12:27:11 -0700 Message-ID: Subject: Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC To: Dave Hansen Cc: Dave Hansen , LKML , Linux MM , linuxram@us.ibm.com, Thomas Gleixner , mpe@ellerman.id.au, Ingo Molnar , Andrew Morton , shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 23, 2018 at 12:23 PM, Dave Hansen wrote: > On 03/23/2018 12:15 PM, Shakeel Butt wrote: >>> We had a check for PROT_READ/WRITE, but it did not work >>> for PROT_NONE. This entirely removes the PROT_* checks, >>> which ensures that PROT_NONE now works. >>> >>> Reported-by: Shakeel Butt >>> Signed-off-by: Dave Hansen >> Should there be a 'Fixes' tag? Also should this patch go to stable? > > There could be, but I'm to lazy to dig up the original commit. Does it > matter? > I think for stable 'Fixes' is usually preferable.