LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Connor McAdams <conmanx360@gmail.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for R3Di and SBZ
Date: Mon, 7 May 2018 09:55:15 -0400	[thread overview]
Message-ID: <CAM8Agx3QjC79su82yP+4btKQyFsyU-f_QESXqLnZAXAMetkZmQ@mail.gmail.com> (raw)
In-Reply-To: <9918d3d1-d843-6142-ca95-91ee0bde3d6b@sakamocchi.jp>

Just to make sure, do you mean that I need to add more comments to the
SBZ and R3Di changes, or are they good as is?

Thanks,
Connor.

On Sun, May 6, 2018 at 10:29 PM, Takashi Sakamoto
<o-takashi@sakamocchi.jp> wrote:
> Hi,
>
> On May 6 2018 04:03, Connor McAdams wrote:
>>
>> Edit core functions to support the Sound Blaster Z and Recon3Di for
>> startup and loading of the DSP, as well as setting effects.
>>
>> Signed-off-by: Connor McAdams <conmanx360@gmail.com>
>> ---
>>   sound/pci/hda/patch_ca0132.c | 1064
>> ++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 1018 insertions(+), 46 deletions(-)
>
>
> In my opinion, this patch is too large. This patch can be split into
> several parts:
>
>  * Changes for signature of 'dspio_scp()' to get 'src_id'
>   * dspio_scp()
>   * dspio_set_param()
>   * dspio_set_uint_param()
>   * dspio_alloc_dma_chan()
>   * dspio_free_dma_chan()
>  * Changes for SBZ only
>  * Changes for R3Di only
>
> Could you please prepare for these three patches from this large patch in
> your next chance? Especially, you can describe enough information to the
> latter two patches as patch comment.
>
>
> Thanks
>
> Takashi Sakamoto

  reply	other threads:[~2018-05-07 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05 19:03 [PATCH v3 0/9] ALSA: hda/ca0132: Patch Series for Recon3Di and Sound Blaster Z Support Connor McAdams
2018-05-05 19:03 ` [PATCH v3 1/9] ALSA: hda/ca0132: R3Di and SBZ quirk entires + alt firmware loading Connor McAdams
2018-05-05 19:03 ` [PATCH v3 2/9] ALSA: hda/ca0132: Add pincfg for SBZ + R3Di, add fp hp auto-detect Connor McAdams
2018-05-05 19:03 ` [PATCH v3 3/9] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ Connor McAdams
2018-05-05 19:03 ` [PATCH v3 4/9] ALSA: hda/ca0132: Add extra exit functions for R3Di and SBZ Connor McAdams
2018-05-05 19:03 ` [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper " Connor McAdams
2018-05-07  2:29   ` Takashi Sakamoto
2018-05-07 13:55     ` Connor McAdams [this message]
2018-05-05 19:03 ` [PATCH v3 6/9] ALSA: hda/ca0132: add alt_select_in/out for R3Di + SBZ Connor McAdams
2018-05-07  3:01   ` Takashi Sakamoto
2018-05-05 19:03 ` [PATCH v3 7/9] ALSA: hda/ca0132: Add DSP Volume set and New mixers for SBZ + R3Di Connor McAdams
2018-05-05 19:03 ` [PATCH v3 8/9] ALSA: hda/ca0132: add ca0132_alt_set_vipsource Connor McAdams
2018-05-05 19:03 ` [PATCH v3 9/9] ALSA: hda/ca0132: Add new control changes for SBZ + R3Di Connor McAdams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM8Agx3QjC79su82yP+4btKQyFsyU-f_QESXqLnZAXAMetkZmQ@mail.gmail.com \
    --to=conmanx360@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeremy.lefaure@lse.epita.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for R3Di and SBZ' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).