LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] perf, android: fixup get_current_dir_name() compilation
@ 2021-08-17 11:58 Alexey Dobriyan
  2021-08-19 16:28 ` Namhyung Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2021-08-17 11:58 UTC (permalink / raw)
  To: acme; +Cc: linux-kernel, linux-perf-users

strdup() prototype doesn't live in stdlib.h .

Add limits.h for PATH_MAX definition as well.

Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
---

 tools/perf/util/get_current_dir_name.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -3,8 +3,9 @@
 //
 #ifndef HAVE_GET_CURRENT_DIR_NAME
 #include "get_current_dir_name.h"
+#include <limits.h>
+#include <string.h>
 #include <unistd.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] perf, android: fixup get_current_dir_name() compilation
  2021-08-17 11:58 [PATCH] perf, android: fixup get_current_dir_name() compilation Alexey Dobriyan
@ 2021-08-19 16:28 ` Namhyung Kim
  2021-08-19 18:40   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2021-08-19 16:28 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Arnaldo Carvalho de Melo, linux-kernel, linux-perf-users

Hello,

On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> strdup() prototype doesn't live in stdlib.h .
>
> Add limits.h for PATH_MAX definition as well.
>
> Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>
>  tools/perf/util/get_current_dir_name.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -3,8 +3,9 @@
>  //
>  #ifndef HAVE_GET_CURRENT_DIR_NAME
>  #include "get_current_dir_name.h"
> +#include <limits.h>
> +#include <string.h>
>  #include <unistd.h>
> -#include <stdlib.h>
>
>  /* Android's 'bionic' library, for one, doesn't have this */
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] perf, android: fixup get_current_dir_name() compilation
  2021-08-19 16:28 ` Namhyung Kim
@ 2021-08-19 18:40   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-08-19 18:40 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Namhyung Kim, linux-kernel, linux-perf-users

Em Thu, Aug 19, 2021 at 09:28:13AM -0700, Namhyung Kim escreveu:
> Hello,
> 
> On Tue, Aug 17, 2021 at 4:59 AM Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > strdup() prototype doesn't live in stdlib.h .
> >
> > Add limits.h for PATH_MAX definition as well.
> >
> > Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-19 18:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 11:58 [PATCH] perf, android: fixup get_current_dir_name() compilation Alexey Dobriyan
2021-08-19 16:28 ` Namhyung Kim
2021-08-19 18:40   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).