LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Loic Poulain <email@example.com> To: Bhaumik Bhatt <firstname.lastname@example.org> Cc: "Manivannan Sadhasivam" <email@example.com>, linux-arm-msm <firstname.lastname@example.org>, "Hemant Kumar" <email@example.com>, "Jeffrey Hugo" <firstname.lastname@example.org>, "open list" <email@example.com>, "Carl Yin(殷张成)" <firstname.lastname@example.org>, "Naveen Kumar" <email@example.com> Subject: Re: [PATCH v6 3/4] bus: mhi: core: Process execution environment changes serially Date: Thu, 4 Mar 2021 09:43:52 +0100 [thread overview] Message-ID: <CAMZdPi8s8Sp1eaqjTbxUtqiNgDXFa5a+GJnp-LmrDc-8ORCOtw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, 25 Feb 2021 at 00:23, Bhaumik Bhatt <email@example.com> wrote: > > In current design, whenever the BHI interrupt is fired, the > execution environment is updated. This can cause race conditions > and impede ongoing power up/down processing. For example, if a > power down is in progress, MHI host updates to a local "disabled" > execution environment. If a BHI interrupt fires later, that value > gets replaced with one from the BHI EE register. This impacts the > controller as it does not expect multiple RDDM execution > environment change status callbacks as an example. Another issue > would be that the device can enter mission mode and the execution > environment is updated, while device creation for SBL channels is > still going on due to slower PM state worker thread run, leading > to multiple attempts at opening the same channel. > > Ensure that EE changes are handled only from appropriate places > and occur one after another and handle only PBL modes or RDDM EE > changes as critical events directly from the interrupt handler. > Simplify handling by waiting for SYS ERROR before handling RDDM. > This also makes sure that we use the correct execution environment > to notify the controller driver when the device resets to one of > the PBL execution environments. > > Signed-off-by: Bhaumik Bhatt <firstname.lastname@example.org> Looking good now Reviewed-by: Loic Poulain <email@example.com>
next prev parent reply other threads:[~2021-03-04 8:37 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-24 23:23 [PATCH v6 0/4] Serialize execution environment changes for MHI Bhaumik Bhatt 2021-02-24 23:23 ` [PATCH v6 1/4] bus: mhi: core: Destroy SBL devices when moving to mission mode Bhaumik Bhatt 2021-02-26 22:06 ` Hemant Kumar 2021-03-04 8:41 ` Loic Poulain 2021-03-10 14:03 ` Manivannan Sadhasivam 2021-02-24 23:23 ` [PATCH v6 2/4] bus: mhi: core: Download AMSS image from appropriate function Bhaumik Bhatt 2021-03-04 8:42 ` Loic Poulain 2021-02-24 23:23 ` [PATCH v6 3/4] bus: mhi: core: Process execution environment changes serially Bhaumik Bhatt 2021-03-04 8:43 ` Loic Poulain [this message] 2021-03-10 14:04 ` Manivannan Sadhasivam 2021-08-23 18:43 ` Jeffrey Hugo 2021-08-23 19:19 ` Bhaumik Bhatt 2021-08-23 19:38 ` Jeffrey Hugo 2021-08-26 18:04 ` Bhaumik Bhatt 2021-02-24 23:23 ` [PATCH v6 4/4] bus: mhi: core: Update debug prints to include local device state Bhaumik Bhatt 2021-03-04 8:45 ` Loic Poulain 2021-03-10 14:07 ` [PATCH v6 0/4] Serialize execution environment changes for MHI Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMZdPi8s8Sp1eaqjTbxUtqiNgDXFa5a+GJnp-LmrDc-8ORCOtw@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).