LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Ivan Babrou <ibobrik@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Paul Turner <pjt@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Mike Galbraith <efault@gmx.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle
Date: Tue, 22 May 2018 17:34:57 -0700	[thread overview]
Message-ID: <CAM_iQpV3o6Dj4xEgVQvJz0tvVLh4Tmvkjp=DdHFui+tNGevU+w@mail.gmail.com> (raw)
In-Reply-To: <CANWdNRCQCteO7L+Of7T2vWBW7GbMHyvyF5aSQMVYNGg_afxNhg@mail.gmail.com>

On Mon, May 21, 2018 at 11:35 PM, Ivan Babrou <ibobrik@gmail.com> wrote:
>
>
> On Mon, May 21, 2018 at 11:20 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>
>> +
>> +       TP_printk("path=%s cpu=%d runtime_remaining=%lld",
>> __get_str(cfs_path),
>> +                 __entry->cpu, __entry->runtime_remaining)
>
>
> Can you add "[ns]" as the unit to runtime_remaining? We have it in
> "sched:sched_stat_runtime".

Hmm, although it is indeed ns, this ->runtime_remaining can be negative,
unlike sched_stat_runtime. So I am not sure if I should marked it as "[ns]".

  parent reply	other threads:[~2018-05-23  0:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  6:20 [PATCH 0/3] sched/fair: improve CFS throttle Cong Wang
2018-05-22  6:20 ` [PATCH 1/3] sched/fair: make CFS bandwidth slice per cpu group Cong Wang
2018-05-22  6:20 ` [PATCH 2/3] sched/fair: accumulate unused cpu time for CFS throttle Cong Wang
2018-05-22  6:20 ` [PATCH 3/3] sched/fair: add tracepoints for cfs throttle Cong Wang
     [not found]   ` <CANWdNRCQCteO7L+Of7T2vWBW7GbMHyvyF5aSQMVYNGg_afxNhg@mail.gmail.com>
2018-05-23  0:34     ` Cong Wang [this message]
2018-05-23  9:09     ` Peter Zijlstra
2018-05-24  4:40       ` Cong Wang
2018-05-24  7:11         ` Peter Zijlstra
2018-05-24 22:23           ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpV3o6Dj4xEgVQvJz0tvVLh4Tmvkjp=DdHFui+tNGevU+w@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=efault@gmx.de \
    --cc=ibobrik@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).