LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: Lyude Paul <lyude@redhat.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] drm/dp_mst: Improve kdocs for drm_dp_check_act_status()
Date: Mon, 6 Apr 2020 15:21:34 -0400	[thread overview]
Message-ID: <CAMavQK+fjw_Odj-nQkUnZVyGXv_62znBXk2MsUVzkZxuQDJC9A@mail.gmail.com> (raw)
In-Reply-To: <20200403200757.886443-2-lyude@redhat.com>

On Fri, Apr 3, 2020 at 4:08 PM Lyude Paul <lyude@redhat.com> wrote:
>
> No functional changes.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Sean Paul <sean@poorly.run>

Reviewed-by: Sean Paul <sean@poorly.run>

> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 10d0315af513..2b9ce965f044 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4462,10 +4462,14 @@ static int drm_dp_dpcd_write_payload(struct drm_dp_mst_topology_mgr *mgr,
>
>
>  /**
> - * drm_dp_check_act_status() - Check ACT handled status.
> + * drm_dp_check_act_status() - Polls for ACT handled status.
>   * @mgr: manager to use
>   *
> - * Check the payload status bits in the DPCD for ACT handled completion.
> + * Tries waiting for the MST hub to finish updating it's payload table by
> + * polling for the ACT handled bit.
> + *
> + * Returns:
> + * 0 if the ACT was handled in time, negative error code on failure.
>   */
>  int drm_dp_check_act_status(struct drm_dp_mst_topology_mgr *mgr)
>  {
> --
> 2.25.1
>

  reply	other threads:[~2020-04-06 19:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 20:07 [PATCH 0/4] drm/dp_mst: drm_dp_check_act_status() fixes Lyude Paul
2020-04-03 20:07 ` [PATCH 1/4] drm/dp_mst: Improve kdocs for drm_dp_check_act_status() Lyude Paul
2020-04-06 19:21   ` Sean Paul [this message]
2020-04-03 20:07 ` [PATCH 2/4] drm/dp_mst: Reformat drm_dp_check_act_status() a bit Lyude Paul
2020-04-06 19:23   ` Sean Paul
2020-04-06 19:27     ` Lyude Paul
2020-04-06 22:11     ` Lyude Paul
2020-04-03 20:07 ` [PATCH 3/4] drm/dp_mst: Increase ACT retry timeout to 3s Lyude Paul
2020-04-06 19:41   ` Sean Paul
2020-04-06 19:43     ` Lyude Paul
2020-04-06 19:48       ` Sean Paul
2020-04-03 20:07 ` [PATCH 4/4] drm/dp_mst: Print errors on ACT timeouts Lyude Paul
2020-04-06 19:43   ` Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMavQK+fjw_Odj-nQkUnZVyGXv_62znBXk2MsUVzkZxuQDJC9A@mail.gmail.com \
    --to=sean@poorly.run \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    --subject='Re: [PATCH 1/4] drm/dp_mst: Improve kdocs for drm_dp_check_act_status()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).