LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: tg3 crashes under high load, when using 100Mbits
@ 2018-04-19  4:21 Siva Reddy Kallam
  0 siblings, 0 replies; 7+ messages in thread
From: Siva Reddy Kallam @ 2018-04-19  4:21 UTC (permalink / raw)
  To: Kai-Heng Feng
  Cc: Satish Baddipadige, Prashant Sreedharan, Michael Chan,
	Linux Netdev List, Linux Kernel Mailing List, Stanley Hsiao,
	Tim Chen

On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
> Hi Satish,
>
>> On 2018Mar21, at 00:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>
>> Satish Baddipadige <satish.baddipadige@broadcom.com> wrote:
>>
>>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam
>>> <siva.kallam@broadcom.com> wrote:
>>>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam
>>>> <siva.kallam@broadcom.com> wrote:
>>>>> On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
>>>>> <kai.heng.feng@canonical.com> wrote:
>>>>>> Hi Broadcom folks,
>>>>>>
>>>>>> We are now enabling a new platform with tg3 nic, unfortunately we observed
>>>>>> the bug [1] that dated back to 2015.
>>>>>> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to
>>>>>> 2048”) but it does’t work.
>>>>>>
>>>>>> Do you have any idea how to solve the issue?
>>>>>>
>>>>>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>>>>>>
>>>>>> Kai-Heng
>>>>> Thank you for reporting. We will check and update you.
>>>> With link aware mode, the clock speed could be slow and boot code does not
>>>> complete within the expected time with lower link speeds. Need to override
>>>> and the clock in driver. We are checking the feasibility of adding
>>>> this in driver or firmware.
>>>
>>> Hi Kai-Heng,
>>>
>>> Can you please test the attached patch?
>>
>> I built a kernel and asked affected users to try.
>
> Users reported that the crash still happens with the patch.
>
> Kai-Heng
>
Thanks for the feedback. We will re-work on the patch and soon provide
you the update.
>>
>> Thanks for your work.
>>
>> Kai-Heng
>>
>>>
>>> Thanks,
>>> Satish
>>> <tg3_5762_clock_override.patch>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: tg3 crashes under high load, when using 100Mbits
@ 2018-03-20  6:12 Satish Baddipadige
  2018-03-20 16:57 ` Kai-Heng Feng
  0 siblings, 1 reply; 7+ messages in thread
From: Satish Baddipadige @ 2018-03-20  6:12 UTC (permalink / raw)
  To: Siva Reddy Kallam
  Cc: Kai Heng Feng, Prashant Sreedharan, Michael Chan,
	Linux Netdev List, Linux Kernel Mailing List, Stanley Hsiao,
	Tim Chen

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam
<siva.kallam@broadcom.com> wrote:
> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam
> <siva.kallam@broadcom.com> wrote:
>> On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
>> <kai.heng.feng@canonical.com> wrote:
>>> Hi Broadcom folks,
>>>
>>> We are now enabling a new platform with tg3 nic, unfortunately we observed
>>> the bug [1] that dated back to 2015.
>>> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to
>>> 2048”) but it does’t work.
>>>
>>> Do you have any idea how to solve the issue?
>>>
>>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>>>
>>> Kai-Heng
>>>
>> Thank you for reporting. We will check and update you.
> With link aware mode, the clock speed could be slow and boot code does not
> complete within the expected time with lower link speeds. Need to override
> and the clock in driver. We are checking the feasibility of adding
> this in driver or firmware.

Hi Kai-Heng,

Can you please test the attached patch?

Thanks,
Satish

[-- Attachment #2: tg3_5762_clock_override.patch --]
[-- Type: application/octet-stream, Size: 729 bytes --]

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index f259397..d27337d 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -9010,6 +9010,7 @@ static void tg3_override_clk(struct tg3 *tp)
 
 	switch (tg3_asic_rev(tp)) {
 	case ASIC_REV_5717:
+	case ASIC_REV_5762:
 		val = tr32(TG3_CPMU_CLCK_ORIDE_ENABLE);
 		tw32(TG3_CPMU_CLCK_ORIDE_ENABLE, val |
 		     TG3_CPMU_MAC_ORIDE_ENABLE);
@@ -9031,6 +9032,7 @@ static void tg3_restore_clk(struct tg3 *tp)
 
 	switch (tg3_asic_rev(tp)) {
 	case ASIC_REV_5717:
+	case ASIC_REV_5762:
 		val = tr32(TG3_CPMU_CLCK_ORIDE_ENABLE);
 		tw32(TG3_CPMU_CLCK_ORIDE_ENABLE,
 		     val & ~TG3_CPMU_MAC_ORIDE_ENABLE);

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: tg3 crashes under high load, when using 100Mbits
@ 2018-02-12  5:29 Siva Reddy Kallam
       [not found] ` <CA+oDAx-OEk7q7TZ4k8s_q_OWmObCZEwm0irjPSh-a1W0uZwACQ@mail.gmail.com>
  0 siblings, 1 reply; 7+ messages in thread
From: Siva Reddy Kallam @ 2018-02-12  5:29 UTC (permalink / raw)
  To: Kai Heng Feng
  Cc: Prashant Sreedharan, Michael Chan, Linux Netdev List,
	Linux Kernel Mailing List, Stanley Hsiao, Tim Chen

On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng
<kai.heng.feng@canonical.com> wrote:
> Hi Broadcom folks,
>
> We are now enabling a new platform with tg3 nic, unfortunately we observed
> the bug [1] that dated back to 2015.
> I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to
> 2048”) but it does’t work.
>
> Do you have any idea how to solve the issue?
>
> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664
>
> Kai-Heng
>
Thank you for reporting. We will check and update you.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* tg3 crashes under high load, when using 100Mbits
@ 2018-02-09  5:11 Kai Heng Feng
  0 siblings, 0 replies; 7+ messages in thread
From: Kai Heng Feng @ 2018-02-09  5:11 UTC (permalink / raw)
  To: siva.kallam, prashant, mchan
  Cc: netdev, Linux Kernel Mailing List, Stanley Hsiao, Tim Chen

Hi Broadcom folks,

We are now enabling a new platform with tg3 nic, unfortunately we observed  
the bug [1] that dated back to 2015.
I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to  
2048”) but it does’t work.

Do you have any idea how to solve the issue?

[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1447664

Kai-Heng

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-19  4:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  4:21 tg3 crashes under high load, when using 100Mbits Siva Reddy Kallam
  -- strict thread matches above, loose matches on Subject: below --
2018-03-20  6:12 Satish Baddipadige
2018-03-20 16:57 ` Kai-Heng Feng
2018-04-14 15:47   ` Kai-Heng Feng
2018-02-12  5:29 Siva Reddy Kallam
     [not found] ` <CA+oDAx-OEk7q7TZ4k8s_q_OWmObCZEwm0irjPSh-a1W0uZwACQ@mail.gmail.com>
     [not found]   ` <1C1B9BF4-56EE-473A-9E92-F7E6BD188C25@canonical.com>
     [not found]     ` <CA+oDAx8Gu0g97ivQ2r1EiLQTYZxhnyL-n2Cx+4J9Sztwj8brrw@mail.gmail.com>
     [not found]       ` <53F1AA2B-2049-4A7A-AEBC-4C1CA3C15F61@canonical.com>
     [not found]         ` <9654fc1df0d4cc00cf88dbe10188fd0b@mail.gmail.com>
     [not found]           ` <CA+oDAx9K31LJtiKvG2EP4As7t_HqXFiAuLCbaSTdrL1YQwO3Uw@mail.gmail.com>
     [not found]             ` <781b8fed3ceaa133aa0e451d9bfbee26@mail.gmail.com>
     [not found]               ` <CA+oDAx8A=VXx0nUXZxG7fJTvJzeWL6b1UYFHoB2Dw3h6yKgr3Q@mail.gmail.com>
     [not found]                 ` <01bf0c0f91e259dacde4c27f3f31c9e6@mail.gmail.com>
     [not found]                   ` <CA+oDAx9s1iT2OJRZ0i5FwmhQx9QtJs8qU70wbfP3rGWYERPL6w@mail.gmail.com>
     [not found]                     ` <CA+oDAx_gxc_=NOa9naEmHJHjs4t3OP2ef29-4-TP2e8S5p_cEg@mail.gmail.com>
2018-02-15 14:07                       ` Siva Reddy Kallam
2018-02-09  5:11 Kai Heng Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).