LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergio Paracuellos <email@example.com>
To: Stephen Boyd <firstname.lastname@example.org>
Cc: "open list:COMMON CLK FRAMEWORK" <email@example.com>,
Greg KH <firstname.lastname@example.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<email@example.com>, Rob Herring <firstname.lastname@example.org>,
email@example.com, NeilBrown <firstname.lastname@example.org>,
John Crispin <email@example.com>
Subject: Re: [PATCH v2 0/4] clk: ralink: make system controller a reset provider
Date: Sat, 30 Oct 2021 16:23:12 +0200 [thread overview]
Message-ID: <CAMhs-H8zCdhRUaqo3t6RZ95C2E89YFhvPN52SgDbPBAFtTwO0Q@mail.gmail.com> (raw)
On Sun, Oct 17, 2021 at 8:51 AM Sergio Paracuellos
> Hi Stephen,
> On Wed, Oct 6, 2021 at 1:23 PM Sergio Paracuellos
> <firstname.lastname@example.org> wrote:
> > Hi all,
> > This patch series add minimal change to provide mt7621 resets properly
> > defining them in the 'mediatek,mt7621-sysc' node which is the system
> > controller of the SoC and is already providing clocks to the rest of
> > the world.
> > There is shared architecture code for all ralink platforms in 'reset.c'
> > file located in 'arch/mips/ralink' but the correct thing to do to align
> > hardware with software seems to define and add related reset code to the
> > already mainlined clock driver.
> > After this changes, we can get rid of the useless reset controller node
> > in the device tree and use system controller node instead where the property
> > '#reset-cells' has been added. Binding documentation for this nodeq has
> > been updated with the new property accordly.
> > This series also provide a bindings include header where all related
> > reset bits for the MT7621 SoC are defined.
> > Also, please take a look to this review  to understand better motivation
> > for this series.
> > Thanks in advance for your feedback.
> > Changes in v2:
> > - Address review comments of Dan Carpenter :
> > + Avoid 'inline' in function definition.
> > + Return proper error codes (-EINVAL) instead of '-1'.
> > + Make use of 'devm_kzalloc' instead of 'kzalloc'.
> Can you please take a look into this series? I'd like them to be added
> in the next merge window and if something needs to be changed I'd like
> to have a bit of time to do it :)).
> Regarding how to merge this I guess all of the patches should apply
> cleanly in any tree but since there are already changes in mt7621-dts
> maybe patches 1 and 4 which are related can go through the staging
> tree (if Greg is ok with this) and the bindings doc change and driver
> changes (patches 2 and 3) can go through your tree.
I have just sent v3 since PATCH 4 did not apply cleanly anymore in
both clock tree and staging tree.
> Thanks in advance for your time.
> Best regards,
> Sergio Paracuellos
> > Best regards,
> > Sergio Paracuellos
> > : https://email@example.com/
> > : https://lkml.org/lkml/2021/10/6/204
> > Sergio Paracuellos (4):
> > dt-bindings: reset: add dt binding header for Mediatek MT7621 resets
> > dt-bindings: clock: mediatek,mt7621-sysc: add '#reset-cells' property
> > clk: ralink: make system controller node a reset provider
> > staging: mt7621-dts: align resets with binding documentation
> > .../bindings/clock/mediatek,mt7621-sysc.yaml | 12 +++
> > drivers/clk/ralink/clk-mt7621.c | 79 +++++++++++++++++++
> > drivers/staging/mt7621-dts/mt7621.dtsi | 27 +++----
> > include/dt-bindings/reset/mt7621-reset.h | 37 +++++++++
> > 4 files changed, 140 insertions(+), 15 deletions(-)
> > create mode 100644 include/dt-bindings/reset/mt7621-reset.h
> > --
> > 2.33.0
prev parent reply other threads:[~2021-10-30 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 11:23 Sergio Paracuellos
2021-10-06 11:23 ` [PATCH v2 1/4] dt-bindings: reset: add dt binding header for Mediatek MT7621 resets Sergio Paracuellos
2021-10-14 18:26 ` Rob Herring
2021-10-06 11:23 ` [PATCH v2 2/4] dt-bindings: clock: mediatek,mt7621-sysc: add '#reset-cells' property Sergio Paracuellos
2021-10-14 18:27 ` Rob Herring
2021-10-06 11:23 ` [PATCH v2 3/4] clk: ralink: make system controller node a reset provider Sergio Paracuellos
2021-10-06 11:23 ` [PATCH v2 4/4] staging: mt7621-dts: align resets with binding documentation Sergio Paracuellos
2021-10-17 6:51 ` [PATCH v2 0/4] clk: ralink: make system controller a reset provider Sergio Paracuellos
2021-10-30 14:23 ` Sergio Paracuellos [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v2 0/4] clk: ralink: make system controller a reset provider' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).