LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Gregory Fong" <gregory.0xf0@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"René van Dorst" <opensource@vdorst.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"John Thomson" <git@johnthomson.fastmail.com.au>,
	NeilBrown <neil@brown.name>,
	"Nicholas Mc Guire" <hofrat@osadl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip banks per device
Date: Thu, 29 Jul 2021 21:10:12 +0200	[thread overview]
Message-ID: <CAMhs-H93GxOHdD4dNAWeyMOrnU2u3QLYK7v=0XF6DQixjhjxag@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJUnXpOhvaQuNPbFt3TY363vrsEWV1KXxhyBm7cJ-PWvwQ@mail.gmail.com>

On Thu, Jul 29, 2021 at 7:43 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Wed, Jul 28, 2021 at 6:12 AM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
> >
> > There are some unfortunate cases where the DT representation
> > of the device and the Linux internal representation differs.
> > Such drivers for devices are forced to implement a custom function
> > to avoid the core code 'devprop_gpiochip_set_names' to be executed
> > since in any other case every gpiochip inside will got repeated
> > names through its internal gpiochip banks. To avoid this antipattern
> > this changes are introduced trying to adapt core 'devprop_gpiochip_set_names'
> > to get a correct behaviour for every single situation.
> >
> > This series introduces a new 'offset' field in the gpiochip structure
> > that can be used for those unfortunate drivers that must define multiple
> > gpiochips per device.
> >
> > Drivers affected by this situation are also updated. These are
> > 'gpio-mt7621' and 'gpio-brcmstb'.
> >
> > Motivation for this series available at [0].
> >
> > Thanks in advance for your feedback.
> >
> > Best regards,
> >     Sergio Paracuellos
> >
> > Changes in v4:
> >   - Add comma in warning message for clarity.
> >   - Collect Gregory Fong Reviewed-by for PATCH 1/3.
> >
> > Changes in v3:
> >   - Reflow a string literal to be on one line in PATCH 1/3.
> >   - reflow commit messages PATCH 2/3 and PATCH 3/3 to occupy a little bit
> >     more available space per line.
> >
> > Changes in v2:
> >   - Address Gregory Fong comments in v1 of the series [1].
> >   - Collect Andy Shevchenko Reviewed-by for the series.
> >   - Collect Gregory Fong Acked-by for PATCH 3/3.
> >
> > [0]: https://lkml.org/lkml/2021/6/26/198
> > [1]: https://lkml.org/lkml/2021/7/8/47
> >
> > Sergio Paracuellos (3):
> >   gpiolib: convert 'devprop_gpiochip_set_names' to support multiple
> >     gpiochip banks per device
> >   gpio: mt7621: support gpio-line-names property
> >   gpio: brcmstb: remove custom 'brcmstb_gpio_set_names'
> >
> >  drivers/gpio/gpio-brcmstb.c | 45 +------------------------------------
> >  drivers/gpio/gpio-mt7621.c  |  1 +
> >  drivers/gpio/gpiolib.c      | 32 +++++++++++++++++++++-----
> >  include/linux/gpio/driver.h |  4 ++++
> >  4 files changed, 33 insertions(+), 49 deletions(-)
> >
> > --
> > 2.25.1
> >
>
> Patches queued for next. Thanks!

Thanks!

Best regards,
    Sergio Paracuellos

  reply	other threads:[~2021-07-29 19:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  4:12 Sergio Paracuellos
2021-07-28  4:12 ` [PATCH v4 1/3] " Sergio Paracuellos
2021-07-28  4:12 ` [PATCH v4 2/3] gpio: mt7621: support gpio-line-names property Sergio Paracuellos
2021-07-28  4:12 ` [PATCH v4 3/3] gpio: brcmstb: remove custom 'brcmstb_gpio_set_names' Sergio Paracuellos
2021-07-29 17:43 ` [PATCH v4 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip banks per device Bartosz Golaszewski
2021-07-29 19:10   ` Sergio Paracuellos [this message]
2021-08-11  9:03   ` Linus Walleij
2021-08-11 10:26     ` Sergio Paracuellos
2021-08-11 14:29       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhs-H93GxOHdD4dNAWeyMOrnU2u3QLYK7v=0XF6DQixjhjxag@mail.gmail.com' \
    --to=sergio.paracuellos@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=f.fainelli@gmail.com \
    --cc=git@johnthomson.fastmail.com.au \
    --cc=gregory.0xf0@gmail.com \
    --cc=hofrat@osadl.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=neil@brown.name \
    --cc=opensource@vdorst.com \
    --subject='Re: [PATCH v4 0/3] gpiolib: convert '\''devprop_gpiochip_set_names'\'' to support multiple gpiochip banks per device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).