LKML Archive on
help / color / mirror / Atom feed
From: Bartosz Golaszewski <>
To: Doug Berger <>
Cc: Gregory Fong <>,
	Linus Walleij <>,
	Florian Fainelli <>,,
	linux-gpio <>,
	arm-soc <>,
	LKML <>
Subject: Re: [PATCH V2] gpio: brcmstb: support gpio-line-names property
Date: Thu, 12 Mar 2020 09:22:47 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

śr., 11 mar 2020 o 20:03 Doug Berger <> napisał(a):
> The label names are viewed as a convenience for the user and are not
> necessary for the proper functionality of the driver and device, so we
> don't want to prevent the driver from succeeding at probe due to an
> error in the gpio-line-names property. The bank->gc.names member is
> still made non-NULL which is what we really care about to prevent the
> misapplication of label names by devprop_gpiochip_set_names().
> In fact, it is expected that the device-tree will only include label
> strings up to the last GPIO of interest so the ENODATA error is
> considered a valid result to terminate any further labeling so there is
> no need for an error message in that case.
> Other error results are unexpected so an error message indicating the
> consequence of the error is appropriate here.
> I'm not sure which aspect is confusing to you, so it's not clear to me
> how best to comment the code. I can hazard a guess, but if you have a
> suggestion I'm happy to submit a v3.
> Thanks for taking the time to review this,
>     Doug

No it's fine, thank you for the explanation.


  reply	other threads:[~2020-03-12  8:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 19:02 Doug Berger
2020-03-09 20:01 ` Gregory Fong
2020-03-11 12:44 ` Bartosz Golaszewski
2020-03-11 19:02   ` Doug Berger
2020-03-12  8:22     ` Bartosz Golaszewski [this message]
2020-03-11 15:32 ` Linus Walleij
2020-03-11 18:38   ` Doug Berger
2020-03-11 20:59 ` Florian Fainelli
2020-03-25 23:01 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH V2] gpio: brcmstb: support gpio-line-names property' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).