From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbeENIdj (ORCPT ); Mon, 14 May 2018 04:33:39 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:37066 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbeENIdh (ORCPT ); Mon, 14 May 2018 04:33:37 -0400 X-Google-Smtp-Source: AB8JxZoGxhgDJ5Tv6AvFmkVPkmqkvbRPLd8n31ojF0+oCii1JVATGTA5GPJCoHzYWdx4sjjbfZ8U12gxza9EdG55fto= MIME-Version: 1.0 In-Reply-To: <20180502113413.vv2r3ubfoh7gm3ms@flea> References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-10-jagan@amarulasolutions.com> <20180502113413.vv2r3ubfoh7gm3ms@flea> From: Jagan Teki Date: Mon, 14 May 2018 14:03:36 +0530 Message-ID: Subject: Re: [PATCH 09/21] arm64: dts: allwinner: a64: Add HDMI support To: Maxime Ripard Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 2, 2018 at 5:04 PM, Maxime Ripard wrote: > Hi, > > On Mon, Apr 30, 2018 at 05:10:46PM +0530, Jagan Teki wrote: >> + hdmi_phy: hdmi-phy@1ef0000 { >> + compatible = "allwinner,sun50i-a64-hdmi-phy", >> + "allwinner,sun8i-h3-hdmi-phy"; >> + reg = <0x01ef0000 0x10000>; >> + clocks = <&ccu CLK_BUS_HDMI>, <&ccu CLK_HDMI_DDC>, >> + <&ccu CLK_PLL_VIDEO1>; > > You were discussing that the PLL0 could also be used to clock the PHY, > has that been figured out? This is what I understand from Fig: 3-3. Module Clock Diagram, both tcon0 and tcon1 are using HDMI. I'm thinking based on the tcon configuration we need use proper PLL or some logic to get common PLL don't know yet. Since this series adding tcon1 I've attached PLL1. Jagan. -- Jagan Teki Senior Linux Kernel Engineer | Amarula Solutions U-Boot, Linux | Upstream Maintainer Hyderabad, India.