LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema
@ 2020-03-18 17:10 Jagan Teki
  2020-03-18 17:10 ` [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Jagan Teki @ 2020-03-18 17:10 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Rob Herring
  Cc: David Airlie, Daniel Vetter, Mark Rutland, dri-devel, devicetree,
	linux-kernel, linux-amarula, Jagan Teki

Convert the feiyang,fy07024di26a30d panel bindings to DT schema.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- fix dt_binding_check 

 .../display/panel/feiyang,fy07024di26a30d.txt | 20 -------
 .../panel/feiyang,fy07024di26a30d.yaml        | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
deleted file mode 100644
index 82caa7b65ae8..000000000000
--- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
-
-Required properties:
-- compatible: must be "feiyang,fy07024di26a30d"
-- reg: DSI virtual channel used by that screen
-- avdd-supply: analog regulator dc1 switch
-- dvdd-supply: 3v3 digital regulator
-- reset-gpios: a GPIO phandle for the reset pin
-
-Optional properties:
-- backlight: phandle for the backlight control.
-
-panel@0 {
-	compatible = "feiyang,fy07024di26a30d";
-	reg = <0>;
-	avdd-supply = <&reg_dc1sw>;
-	dvdd-supply = <&reg_dldo2>;
-	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
-	backlight = <&backlight>;
-};
diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
new file mode 100644
index 000000000000..f292c57a5bd6
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR X11)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/feiyang,fy07024di26a30d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
+
+maintainers:
+  - Jagan Teki <jagan@amarulasolutions.com>
+
+properties:
+  compatible:
+    const: feiyang,fy07024di26a30d
+
+  reg:
+    description: DSI virtual channel used by that screen
+
+  avdd-supply:
+    description: analog regulator dc1 switch
+
+  dvdd-supply:
+    description: 3v3 digital regulator
+
+  reset-gpios:
+    description: a GPIO phandle for the reset pin
+
+  backlight:
+    description: Backlight used by the panel
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+
+required:
+  - compatible
+  - reg
+  - avdd-supply
+  - dvdd-supply
+  - reset-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "feiyang,fy07024di26a30d";
+            reg = <0>;
+            avdd-supply = <&reg_dc1sw>;
+            dvdd-supply = <&reg_dldo2>;
+            reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
+            backlight = <&backlight>;
+        };
+    };
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 to DT schema
  2020-03-18 17:10 [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema Jagan Teki
@ 2020-03-18 17:10 ` Jagan Teki
  2020-03-25 19:16   ` Rob Herring
  2020-03-18 17:10 ` [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML Jagan Teki
  2020-03-18 18:57 ` [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema Sam Ravnborg
  2 siblings, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2020-03-18 17:10 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Rob Herring
  Cc: David Airlie, Daniel Vetter, Mark Rutland, dri-devel, devicetree,
	linux-kernel, linux-amarula, Jagan Teki

Convert the sitronix,st7701 panel bindings to DT schema.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- fix dt_binding_check 

 .../display/panel/sitronix,st7701.txt         | 30 --------
 .../display/panel/sitronix,st7701.yaml        | 68 +++++++++++++++++++
 2 files changed, 68 insertions(+), 30 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
deleted file mode 100644
index ccd17597f1f6..000000000000
--- a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-Sitronix ST7701 based LCD panels
-
-ST7701 designed for small and medium sizes of TFT LCD display, is
-capable of supporting up to 480RGBX864 in resolution. It provides
-several system interfaces like MIPI/RGB/SPI.
-
-Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has
-inbuilt ST7701 chip.
-
-Required properties:
-- compatible: must be "sitronix,st7701" and one of
-  * "techstar,ts8550b"
-- reset-gpios: a GPIO phandle for the reset pin
-
-Required properties for techstar,ts8550b:
-- reg: DSI virtual channel used by that screen
-- VCC-supply: analog regulator for MIPI circuit
-- IOVCC-supply: I/O system regulator
-
-Optional properties:
-- backlight: phandle for the backlight control.
-
-panel@0 {
-	compatible = "techstar,ts8550b", "sitronix,st7701";
-	reg = <0>;
-	VCC-supply = <&reg_dldo2>;
-	IOVCC-supply = <&reg_dldo2>;
-	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
-	backlight = <&backlight>;
-};
diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
new file mode 100644
index 000000000000..e02686dfd937
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR X11)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/sitronix,st7701.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sitronix ST7701 based LCD panels
+
+maintainers:
+  - Jagan Teki <jagan@amarulasolutions.com>
+
+description: |
+  ST7701 designed for small and medium sizes of TFT LCD display, is
+  capable of supporting up to 480RGBX864 in resolution. It provides
+  several system interfaces like MIPI/RGB/SPI.
+
+  Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has
+  inbuilt ST7701 chip.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - techstar,ts8550b
+      - const: sitronix,st7701
+
+  reg:
+    description: DSI virtual channel used by that screen
+
+  VCC-supply:
+    description: analog regulator for MIPI circuit
+
+  IOVCC-supply:
+    description: I/O system regulator
+
+  reset-gpios:
+    description: a GPIO phandle for the reset pin
+
+  backlight:
+    description: Backlight used by the panel
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+
+required:
+  - compatible
+  - reg
+  - VCC-supply
+  - IOVCC-supply
+  - reset-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "techstar,ts8550b", "sitronix,st7701";
+            reg = <0>;
+            VCC-supply = <&reg_dldo2>;
+            IOVCC-supply = <&reg_dldo2>;
+            reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
+            backlight = <&backlight>;
+        };
+    };
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML
  2020-03-18 17:10 [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema Jagan Teki
  2020-03-18 17:10 ` [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
@ 2020-03-18 17:10 ` Jagan Teki
  2020-03-18 18:58   ` Sam Ravnborg
  2020-03-18 18:57 ` [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema Sam Ravnborg
  2 siblings, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2020-03-18 17:10 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Rob Herring
  Cc: David Airlie, Daniel Vetter, Mark Rutland, dri-devel, devicetree,
	linux-kernel, linux-amarula, Jagan Teki

The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been
converted to YAML schemas, update MAINTAINERS to match them again.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- none

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6ba8b584bf95..b987f2588e6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5273,7 +5273,7 @@ DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS
 M:	Jagan Teki <jagan@amarulasolutions.com>
 S:	Maintained
 F:	drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
-F:	Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
+F:	Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
 
 DRM DRIVER FOR GRAIN MEDIA GM12U320 PROJECTORS
 M:	Hans de Goede <hdegoede@redhat.com>
@@ -5416,7 +5416,7 @@ DRM DRIVER FOR SITRONIX ST7701 PANELS
 M:	Jagan Teki <jagan@amarulasolutions.com>
 S:	Maintained
 F:	drivers/gpu/drm/panel/panel-sitronix-st7701.c
-F:	Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
+F:	Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
 
 DRM DRIVER FOR SITRONIX ST7586 PANELS
 M:	David Lechner <david@lechnology.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema
  2020-03-18 17:10 [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema Jagan Teki
  2020-03-18 17:10 ` [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
  2020-03-18 17:10 ` [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML Jagan Teki
@ 2020-03-18 18:57 ` Sam Ravnborg
  2020-03-19 10:36   ` Jagan Teki
  2 siblings, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2020-03-18 18:57 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

Hi Jagan.

On Wed, Mar 18, 2020 at 10:40:01PM +0530, Jagan Teki wrote:
> Convert the feiyang,fy07024di26a30d panel bindings to DT schema.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Thanks for the resend.

Please fix so the two bindings uses panel-common.yaml.

And then only properties specific for this binding shall have a
description.

See below - please fix both bindings and resend.

	Sam

> ---
> Changes for v2:
> - fix dt_binding_check 
> 
>  .../display/panel/feiyang,fy07024di26a30d.txt | 20 -------
>  .../panel/feiyang,fy07024di26a30d.yaml        | 57 +++++++++++++++++++
>  2 files changed, 57 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> deleted file mode 100644
> index 82caa7b65ae8..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> -
> -Required properties:
> -- compatible: must be "feiyang,fy07024di26a30d"
> -- reg: DSI virtual channel used by that screen
> -- avdd-supply: analog regulator dc1 switch
> -- dvdd-supply: 3v3 digital regulator
> -- reset-gpios: a GPIO phandle for the reset pin
> -
> -Optional properties:
> -- backlight: phandle for the backlight control.
> -
> -panel@0 {
> -	compatible = "feiyang,fy07024di26a30d";
> -	reg = <0>;
> -	avdd-supply = <&reg_dc1sw>;
> -	dvdd-supply = <&reg_dldo2>;
> -	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> -	backlight = <&backlight>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> new file mode 100644
> index 000000000000..f292c57a5bd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/feiyang,fy07024di26a30d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> +
> +maintainers:
> +  - Jagan Teki <jagan@amarulasolutions.com>
> +
> +properties:
> +  compatible:
> +    const: feiyang,fy07024di26a30d
> +
> +  reg:
> +    description: DSI virtual channel used by that screen
reg is already described elsewhere so no description.
Thus is becomes:

    reg: true

> +
> +  avdd-supply:
> +    description: analog regulator dc1 switch
> +
> +  dvdd-supply:
> +    description: 3v3 digital regulator
> +
> +  reset-gpios:
> +    description: a GPIO phandle for the reset pin
This would become:
    reset-gpios: true

> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
This would become:

    backlight: true

> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - dvdd-supply
> +  - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "feiyang,fy07024di26a30d";
> +            reg = <0>;
> +            avdd-supply = <&reg_dc1sw>;
> +            dvdd-supply = <&reg_dldo2>;
> +            reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> +            backlight = <&backlight>;
> +        };
> +    };

Example looks good.



> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML
  2020-03-18 17:10 ` [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML Jagan Teki
@ 2020-03-18 18:58   ` Sam Ravnborg
  2020-03-19 10:20     ` Jagan Teki
  0 siblings, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2020-03-18 18:58 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

On Wed, Mar 18, 2020 at 10:40:03PM +0530, Jagan Teki wrote:
> The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been
> converted to YAML schemas, update MAINTAINERS to match them again.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

The patch is fine.
I just dislike we repeat the maintainer info in two places..

	Sam


> ---
> Changes for v2:
> - none
> 
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6ba8b584bf95..b987f2588e6a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5273,7 +5273,7 @@ DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS
>  M:	Jagan Teki <jagan@amarulasolutions.com>
>  S:	Maintained
>  F:	drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> -F:	Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> +F:	Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
>  
>  DRM DRIVER FOR GRAIN MEDIA GM12U320 PROJECTORS
>  M:	Hans de Goede <hdegoede@redhat.com>
> @@ -5416,7 +5416,7 @@ DRM DRIVER FOR SITRONIX ST7701 PANELS
>  M:	Jagan Teki <jagan@amarulasolutions.com>
>  S:	Maintained
>  F:	drivers/gpu/drm/panel/panel-sitronix-st7701.c
> -F:	Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
> +F:	Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
>  
>  DRM DRIVER FOR SITRONIX ST7586 PANELS
>  M:	David Lechner <david@lechnology.com>
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML
  2020-03-18 18:58   ` Sam Ravnborg
@ 2020-03-19 10:20     ` Jagan Teki
  2020-03-19 10:31       ` Sam Ravnborg
  0 siblings, 1 reply; 10+ messages in thread
From: Jagan Teki @ 2020-03-19 10:20 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

On Thu, Mar 19, 2020 at 12:28 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Wed, Mar 18, 2020 at 10:40:03PM +0530, Jagan Teki wrote:
> > The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been
> > converted to YAML schemas, update MAINTAINERS to match them again.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>
> The patch is fine.
> I just dislike we repeat the maintainer info in two places..

Since these are two different panels. and entry similar like other
panels.do you look for single entry for both the panels?

Jagan.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML
  2020-03-19 10:20     ` Jagan Teki
@ 2020-03-19 10:31       ` Sam Ravnborg
  2020-03-19 10:53         ` Jagan Teki
  0 siblings, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2020-03-19 10:31 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

Hi Jagan.
On Thu, Mar 19, 2020 at 03:50:44PM +0530, Jagan Teki wrote:
> On Thu, Mar 19, 2020 at 12:28 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > On Wed, Mar 18, 2020 at 10:40:03PM +0530, Jagan Teki wrote:
> > > The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been
> > > converted to YAML schemas, update MAINTAINERS to match them again.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >
> > The patch is fine.
> > I just dislike we repeat the maintainer info in two places..
> 
> Since these are two different panels. and entry similar like other
> panels.do you look for single entry for both the panels?
My comment was related to the fact that we have maintainer entry in the
.yaml file, and in MAINTAINERS.

Seems a waste to have a distributed and a centralized place for this.
So patches are fine in this respect.
And merging the two bindings would be very bad, they are not alike.

	Sam

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema
  2020-03-18 18:57 ` [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema Sam Ravnborg
@ 2020-03-19 10:36   ` Jagan Teki
  0 siblings, 0 replies; 10+ messages in thread
From: Jagan Teki @ 2020-03-19 10:36 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

Hi Sam,

On Thu, Mar 19, 2020 at 12:27 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jagan.
>
> On Wed, Mar 18, 2020 at 10:40:01PM +0530, Jagan Teki wrote:
> > Convert the feiyang,fy07024di26a30d panel bindings to DT schema.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>
> Thanks for the resend.
>
> Please fix so the two bindings uses panel-common.yaml.

Is is because few of the bindings in this panel are similar to
panel-common.yaml?

>
> And then only properties specific for this binding shall have a
> description.
>
> See below - please fix both bindings and resend.
>
>         Sam
>
> > ---
> > Changes for v2:
> > - fix dt_binding_check
> >
> >  .../display/panel/feiyang,fy07024di26a30d.txt | 20 -------
> >  .../panel/feiyang,fy07024di26a30d.yaml        | 57 +++++++++++++++++++
> >  2 files changed, 57 insertions(+), 20 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> > deleted file mode 100644
> > index 82caa7b65ae8..000000000000
> > --- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> > +++ /dev/null
> > @@ -1,20 +0,0 @@
> > -Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> > -
> > -Required properties:
> > -- compatible: must be "feiyang,fy07024di26a30d"
> > -- reg: DSI virtual channel used by that screen
> > -- avdd-supply: analog regulator dc1 switch
> > -- dvdd-supply: 3v3 digital regulator
> > -- reset-gpios: a GPIO phandle for the reset pin
> > -
> > -Optional properties:
> > -- backlight: phandle for the backlight control.
> > -
> > -panel@0 {
> > -     compatible = "feiyang,fy07024di26a30d";
> > -     reg = <0>;
> > -     avdd-supply = <&reg_dc1sw>;
> > -     dvdd-supply = <&reg_dldo2>;
> > -     reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> > -     backlight = <&backlight>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> > new file mode 100644
> > index 000000000000..f292c57a5bd6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/feiyang,fy07024di26a30d.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> > +
> > +maintainers:
> > +  - Jagan Teki <jagan@amarulasolutions.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: feiyang,fy07024di26a30d
> > +
> > +  reg:
> > +    description: DSI virtual channel used by that screen
> reg is already described elsewhere so no description.
> Thus is becomes:
>
>     reg: true

Look like reg didn't describe in panel-common.yaml

Jagan.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML
  2020-03-19 10:31       ` Sam Ravnborg
@ 2020-03-19 10:53         ` Jagan Teki
  0 siblings, 0 replies; 10+ messages in thread
From: Jagan Teki @ 2020-03-19 10:53 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Thierry Reding, Rob Herring, Mark Rutland, devicetree,
	David Airlie, linux-kernel, dri-devel, linux-amarula

Hi Sam,

On Thu, Mar 19, 2020 at 4:02 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jagan.
> On Thu, Mar 19, 2020 at 03:50:44PM +0530, Jagan Teki wrote:
> > On Thu, Mar 19, 2020 at 12:28 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> > >
> > > On Wed, Mar 18, 2020 at 10:40:03PM +0530, Jagan Teki wrote:
> > > > The feiyang,fy07024di26a30d.txt and sitronix,st7701.txt has been
> > > > converted to YAML schemas, update MAINTAINERS to match them again.
> > > >
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > >
> > > The patch is fine.
> > > I just dislike we repeat the maintainer info in two places..
> >
> > Since these are two different panels. and entry similar like other
> > panels.do you look for single entry for both the panels?
> My comment was related to the fact that we have maintainer entry in the
> .yaml file, and in MAINTAINERS.
>
> Seems a waste to have a distributed and a centralized place for this.
> So patches are fine in this respect.
> And merging the two bindings would be very bad, they are not alike.

Seems to be a valid point considering the redundant entry in two
places, but the idea of maintainer entry in binding vs MAINTAINER file
may be different in terms of usage, and knowing to public. the later
part is pretty generic for people to know, and checkpatch to find. I
may not be sure, but some experts can help here.

Jagan.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 to DT schema
  2020-03-18 17:10 ` [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
@ 2020-03-25 19:16   ` Rob Herring
  0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-03-25 19:16 UTC (permalink / raw)
  To: Jagan Teki
  Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Mark Rutland, dri-devel, devicetree, linux-kernel, linux-amarula

On Wed, Mar 18, 2020 at 11:10 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Convert the sitronix,st7701 panel bindings to DT schema.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - fix dt_binding_check
>
>  .../display/panel/sitronix,st7701.txt         | 30 --------
>  .../display/panel/sitronix,st7701.yaml        | 68 +++++++++++++++++++
>  2 files changed, 68 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
> deleted file mode 100644
> index ccd17597f1f6..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Sitronix ST7701 based LCD panels
> -
> -ST7701 designed for small and medium sizes of TFT LCD display, is
> -capable of supporting up to 480RGBX864 in resolution. It provides
> -several system interfaces like MIPI/RGB/SPI.
> -
> -Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has
> -inbuilt ST7701 chip.
> -
> -Required properties:
> -- compatible: must be "sitronix,st7701" and one of
> -  * "techstar,ts8550b"
> -- reset-gpios: a GPIO phandle for the reset pin
> -
> -Required properties for techstar,ts8550b:
> -- reg: DSI virtual channel used by that screen
> -- VCC-supply: analog regulator for MIPI circuit
> -- IOVCC-supply: I/O system regulator
> -
> -Optional properties:
> -- backlight: phandle for the backlight control.
> -
> -panel@0 {
> -       compatible = "techstar,ts8550b", "sitronix,st7701";
> -       reg = <0>;
> -       VCC-supply = <&reg_dldo2>;
> -       IOVCC-supply = <&reg_dldo2>;
> -       reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> -       backlight = <&backlight>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
> new file mode 100644
> index 000000000000..e02686dfd937
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR X11)

Do you have rights on the old doc to change the license? If so, it should be:

(GPL-2.0-only OR BSD-2-Clause)

If not, GPL-2.0-only.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/sitronix,st7701.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sitronix ST7701 based LCD panels
> +
> +maintainers:
> +  - Jagan Teki <jagan@amarulasolutions.com>
> +
> +description: |
> +  ST7701 designed for small and medium sizes of TFT LCD display, is
> +  capable of supporting up to 480RGBX864 in resolution. It provides
> +  several system interfaces like MIPI/RGB/SPI.
> +
> +  Techstar TS8550B is 480x854, 2-lane MIPI DSI LCD panel which has
> +  inbuilt ST7701 chip.

Reference panel-common.yaml here.

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - techstar,ts8550b
> +      - const: sitronix,st7701
> +
> +  reg:
> +    description: DSI virtual channel used by that screen

maxItems: 1

> +
> +  VCC-supply:
> +    description: analog regulator for MIPI circuit
> +
> +  IOVCC-supply:
> +    description: I/O system regulator
> +
> +  reset-gpios:
> +    description: a GPIO phandle for the reset pin

Just 'reset-gpios: true'. Already defined by panel-common.yaml.

> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: "/schemas/types.yaml#/definitions/phandle"

Same here. Just need 'true'.

> +
> +required:
> +  - compatible
> +  - reg
> +  - VCC-supply
> +  - IOVCC-supply
> +  - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "techstar,ts8550b", "sitronix,st7701";
> +            reg = <0>;
> +            VCC-supply = <&reg_dldo2>;
> +            IOVCC-supply = <&reg_dldo2>;
> +            reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> +            backlight = <&backlight>;
> +        };
> +    };
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-03-25 19:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 17:10 [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema Jagan Teki
2020-03-18 17:10 ` [PATCH v2 2/3] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
2020-03-25 19:16   ` Rob Herring
2020-03-18 17:10 ` [PATCH v2 3/3] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML Jagan Teki
2020-03-18 18:58   ` Sam Ravnborg
2020-03-19 10:20     ` Jagan Teki
2020-03-19 10:31       ` Sam Ravnborg
2020-03-19 10:53         ` Jagan Teki
2020-03-18 18:57 ` [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d to DT schema Sam Ravnborg
2020-03-19 10:36   ` Jagan Teki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).