LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH
@ 2019-06-04  8:00 Krzysztof Kozlowski
  2019-06-04  8:38 ` Geert Uytterhoeven
  2019-06-13 21:12 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-04  8:00 UTC (permalink / raw)
  To: David S. Miller, Krzysztof Kozlowski, Andrew Morton, sparclinux,
	linux-kernel
  Cc: Geert Uytterhoeven

Remove the CONFIG_UEVENT_HELPER_PATH because:
1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
   CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
   made default to 'n',
2. It is not recommended (help message: "This should not be used today
   [...] creates a high system load") and was kept only for ancient
   userland,
3. Certain userland specifically requests it to be disabled (systemd
   README: "Legacy hotplug slows down the system and confuses udev").

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/sparc/configs/sparc32_defconfig | 1 -
 arch/sparc/configs/sparc64_defconfig | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/sparc/configs/sparc32_defconfig b/arch/sparc/configs/sparc32_defconfig
index 2d4f34c52c67..7b3efe5edc1a 100644
--- a/arch/sparc/configs/sparc32_defconfig
+++ b/arch/sparc/configs/sparc32_defconfig
@@ -27,7 +27,6 @@ CONFIG_INET6_ESP=m
 CONFIG_INET6_IPCOMP=m
 CONFIG_IPV6_TUNNEL=m
 CONFIG_NET_PKTGEN=m
-CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_BLK_DEV_LOOP=m
 CONFIG_BLK_DEV_CRYPTOLOOP=m
 CONFIG_BLK_DEV_RAM=y
diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig
index ea547d596fcf..6c325d53a20a 100644
--- a/arch/sparc/configs/sparc64_defconfig
+++ b/arch/sparc/configs/sparc64_defconfig
@@ -57,7 +57,6 @@ CONFIG_IPV6_TUNNEL=m
 CONFIG_VLAN_8021Q=m
 CONFIG_NET_PKTGEN=m
 CONFIG_NET_TCPPROBE=m
-CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 # CONFIG_PREVENT_FIRMWARE_BUILD is not set
 CONFIG_CONNECTOR=m
 CONFIG_BLK_DEV_LOOP=m
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH
  2019-06-04  8:00 [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
@ 2019-06-04  8:38 ` Geert Uytterhoeven
  2019-06-13 21:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-06-04  8:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David S. Miller, Andrew Morton, sparclinux,
	Linux Kernel Mailing List, Geert Uytterhoeven

On Tue, Jun 4, 2019 at 10:03 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Remove the CONFIG_UEVENT_HELPER_PATH because:
> 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
>    CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
>    made default to 'n',
> 2. It is not recommended (help message: "This should not be used today
>    [...] creates a high system load") and was kept only for ancient
>    userland,
> 3. Certain userland specifically requests it to be disabled (systemd
>    README: "Legacy hotplug slows down the system and confuses udev").
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH
  2019-06-04  8:00 [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
  2019-06-04  8:38 ` Geert Uytterhoeven
@ 2019-06-13 21:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-13 21:12 UTC (permalink / raw)
  To: krzk; +Cc: akpm, sparclinux, linux-kernel, geert+renesas

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Tue,  4 Jun 2019 10:00:59 +0200

> Remove the CONFIG_UEVENT_HELPER_PATH because:
> 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable
>    CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was
>    made default to 'n',
> 2. It is not recommended (help message: "This should not be used today
>    [...] creates a high system load") and was kept only for ancient
>    userland,
> 3. Certain userland specifically requests it to be disabled (systemd
>    README: "Legacy hotplug slows down the system and confuses udev").
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-13 21:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04  8:00 [PATCH] sparc: configs: Remove useless UEVENT_HELPER_PATH Krzysztof Kozlowski
2019-06-04  8:38 ` Geert Uytterhoeven
2019-06-13 21:12 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).