From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbeDJO3P (ORCPT ); Tue, 10 Apr 2018 10:29:15 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33847 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbeDJO3N (ORCPT ); Tue, 10 Apr 2018 10:29:13 -0400 X-Google-Smtp-Source: AIpwx4+lViBhS2NZbCj6H8mJQGOdZFpEOyEIBJ+Qx9syhtt9dgG6Gwr3SMAQ5IDStQBv3bCCIem3/EV26PUyZc9RzvA= MIME-Version: 1.0 In-Reply-To: References: <1522246950-9110-1-git-send-email-phil.edworthy@renesas.com> <20180409192013.5rytwgoixtyraow3@rob-hp-laptop> From: Geert Uytterhoeven Date: Tue, 10 Apr 2018 16:29:11 +0200 X-Google-Sender-Auth: 03z3l_znoY9NNt5ZvSEeBK3BGVI Message-ID: Subject: Re: [PATCH] gpio: dwapb: Add support for 32 interrupts To: Phil Edworthy Cc: Rob Herring , Hoan Tran , Linus Walleij , Mark Rutland , Andy Shevchenko , Michel Pollet , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Phil, On Tue, Apr 10, 2018 at 4:23 PM, Phil Edworthy wrote: > On 10 April 2018 07:24 Phil Edworthy wrote: >> On 09 April 2018 20:20 Rob Herring wrote: >> > On Wed, Mar 28, 2018 at 03:22:30PM +0100, Phil Edworthy wrote: > [...] >> > > +- interrupt-mask : a 32-bit bit mask that specifies which interrupts >> > > +in the list >> > > + of interrupts is valid, bit is 1 for a valid irq. >> > >> > This is not a standard property and would need a vendor prefix. However, >> I'd >> > prefer you just skip any not connected interrupts with an invalid interrupt >> > number. Then the GPIO number is the index into "interrupts". >> Makes sense, I'll rework it to do this. > Err, what would an invalid interrupt number be? > If I use -1, I get a DT parsing error and 0 is certainly valid. If the number is > larger than the valid interrupt range I get errors during probe. Perhaps using interrupts-extended instead of interrupts? E.g. interrupts-extended = <&intc1 5 1>, <0>, <&intc2 1 0>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds