From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CB3C4332F for ; Mon, 4 Oct 2021 17:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 834B161409 for ; Mon, 4 Oct 2021 17:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238239AbhJDRQg (ORCPT ); Mon, 4 Oct 2021 13:16:36 -0400 Received: from mail-vs1-f43.google.com ([209.85.217.43]:35684 "EHLO mail-vs1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233437AbhJDRQf (ORCPT ); Mon, 4 Oct 2021 13:16:35 -0400 Received: by mail-vs1-f43.google.com with SMTP id w13so2432131vsa.2; Mon, 04 Oct 2021 10:14:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SBkLa/4MTN2AV7Ayi5b9WkAAkgh6llV494VW2u23y8M=; b=gm5IwCa8yDWqbfORMl6okiy3cg46UMkjZ75a0LToEUDD/O/OgJtLroYKzVdRwAX5bZ DqKJ3RT2LZPozMjJGgPiwS7HWiOqVZNTS841E/VRrBglbOMJ6s1WfPzMaU2ij2YntUAM xStSnkencrjxZIVZrJbXLq2A4D1+eMhFyicgh6Z1Rb/bmUDQlb+PKemQ1qCQPAl/qanY rEJI+KNpChlfWwB8PYAx6SfELysfpnWjlxTJHmaxRbK/vPfyww7NHD+e+TrJ2H/QtAho orEaqBWu+NeEGfZ8IjmBV4cyb+gUqNa8WcB/j9MGzwnoZdtXCUHNEIt1uNvJPgX2fnq0 B3NQ== X-Gm-Message-State: AOAM530H6pb0nE185Auvls7APEnfLaYbLWRP3hsIURsh3NbWplF/bpXa oDVDEEnkGpnA4IOBA68LSTmhUDMJKnJx8iIUegE= X-Google-Smtp-Source: ABdhPJzAKXaRAKp8VeLwihf2bO6s9nPybnMNdkmRdoDft3Mi8PGfDtP6R7h0/ORYrFJkE1nuoq5c2ZdYEpvBhstP0DQ= X-Received: by 2002:a67:ac04:: with SMTP id v4mr5352188vse.50.1633367683989; Mon, 04 Oct 2021 10:14:43 -0700 (PDT) MIME-Version: 1.0 References: <20211004092100.1.Ic90a5ebd44c75db963112be167a03cc96f9fb249@changeid> In-Reply-To: <20211004092100.1.Ic90a5ebd44c75db963112be167a03cc96f9fb249@changeid> From: Geert Uytterhoeven Date: Mon, 4 Oct 2021 19:14:32 +0200 Message-ID: Subject: Re: [PATCH] drm/edid: Fix crash with zero/invalid EDID To: Douglas Anderson Cc: DRI Development , oliver.sang@intel.com, Daniel Vetter , David Airlie , Jani Nikula , Linus Walleij , Maarten Lankhorst , Maxime Ripard , Sam Ravnborg , Thomas Zimmermann , Linux Kernel Mailing List , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Douglas, On Mon, Oct 4, 2021 at 6:22 PM Douglas Anderson wrote: > In the commit bac9c2948224 ("drm/edid: Break out reading block 0 of > the EDID") I broke out reading the base block of the EDID to its own > function. Unfortunately, when I did that I messed up the handling when > drm_edid_is_zero() indicated that we had an EDID that was all 0x00 or > when we went through 4 loops and didn't get a valid EDID. Specifically > I needed to pass the broken EDID to connector_bad_edid() but now I was > passing an error-pointer. > > Let's re-jigger things so we can pass the bad EDID in properly. > > Fixes: bac9c2948224 ("drm/edid: Break out reading block 0 of the EDID") > Reported-by: kernel test robot > Reported-by: Geert Uytterhoeven > Signed-off-by: Douglas Anderson The crash is was seeing is gone, so Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds