LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Conor Dooley <Conor.Dooley@microchip.com>,
	Atish Patra <atish.patra@wdc.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Bin Meng <bin.meng@windriver.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1
Date: Tue, 24 Aug 2021 17:41:11 +0200	[thread overview]
Message-ID: <CAMuHMdV3DJTii41Q4dy9XSL2zD2rd2ND6rrMwBLNiFsJz+jP3Q@mail.gmail.com> (raw)
In-Reply-To: <20210804123015.807929-1-bmeng.cn@gmail.com>

Hi Bin,

On Wed, Aug 4, 2021 at 2:30 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Per the DT spec, 'local-mac-address' is used to specify MAC address
> that was assigned to the network device, while 'mac-address' is used
> to specify the MAC address that was last used by the boot program,
> and shall be used only if the value differs from 'local-mac-address'
> property value.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: conor dooley <conor.dooley@microchip.com>

Thanks for your patch!

> ---
>
> (no changes since v1)
>
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index 0659068b62f7..a9c558366d61 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -317,7 +317,7 @@ emac1: ethernet@20112000 {
>                         reg = <0x0 0x20112000 0x0 0x2000>;
>                         interrupt-parent = <&plic>;
>                         interrupts = <70 71 72 73>;
> -                       mac-address = [00 00 00 00 00 00];
> +                       local-mac-address = [00 00 00 00 00 00];

Is there any point in providing an all-zeros MAC address at all?
Can't it just be removed?

>                         clocks = <&clkcfg 5>, <&clkcfg 2>;
>                         status = "disabled";
>                         clock-names = "pclk", "hclk";

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2021-08-24 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 12:30 Bin Meng
2021-08-04 12:30 ` [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
2021-08-24 15:46   ` Geert Uytterhoeven
2021-08-19  3:10 ` [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-08-24 15:41 ` Geert Uytterhoeven [this message]
2021-08-25  4:44 ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdV3DJTii41Q4dy9XSL2zD2rd2ND6rrMwBLNiFsJz+jP3Q@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=Conor.Dooley@microchip.com \
    --cc=atish.patra@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v2 1/2] riscv: dts: microchip: Use '\''local-mac-address'\'' for emac1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).