LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: mm: remove unused variables
@ 2019-05-12 11:41 YueHaibing
  2019-05-13  6:20 ` Geert Uytterhoeven
  2019-06-03 18:45 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2019-05-12 11:41 UTC (permalink / raw)
  To: linux, rppt, akpm, geert+renesas, keescook
  Cc: linux-kernel, linux-arm-kernel, YueHaibing

Fix gcc warnings:

arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable]
  extern u32 itcm_end;
             ^
arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable]
  extern u32 dtcm_end;
             ^

They are not used any more since
commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/arm/mm/init.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index be0b429..c71ecbb 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -450,12 +450,6 @@ static void __init free_highpages(void)
  */
 void __init mem_init(void)
 {
-#ifdef CONFIG_HAVE_TCM
-	/* These pointers are filled in on TCM detection */
-	extern u32 dtcm_end;
-	extern u32 itcm_end;
-#endif
-
 	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
 
 	/* this will put all unused low memory onto the freelists */
-- 
2.7.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: mm: remove unused variables
  2019-05-12 11:41 [PATCH] ARM: mm: remove unused variables YueHaibing
@ 2019-05-13  6:20 ` Geert Uytterhoeven
  2019-06-03 18:45 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-05-13  6:20 UTC (permalink / raw)
  To: YueHaibing
  Cc: Russell King, Mike Rapoport, Andrew Morton, Geert Uytterhoeven,
	Kees Cook, Linux Kernel Mailing List, Linux ARM

On Sun, May 12, 2019 at 1:48 PM YueHaibing <yuehaibing@huawei.com> wrote:
> Fix gcc warnings:
>
> arch/arm/mm/init.c: In function 'mem_init':
> arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable]
>   extern u32 itcm_end;
>              ^
> arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable]
>   extern u32 dtcm_end;
>              ^
>
> They are not used any more since
> commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")

Thanks! Sorry for missing that.

> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: mm: remove unused variables
  2019-05-12 11:41 [PATCH] ARM: mm: remove unused variables YueHaibing
  2019-05-13  6:20 ` Geert Uytterhoeven
@ 2019-06-03 18:45 ` Krzysztof Kozlowski
  2019-06-04  2:08   ` Yuehaibing
  2019-06-04  6:19   ` YueHaibing
  1 sibling, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-03 18:45 UTC (permalink / raw)
  To: YueHaibing
  Cc: linux, rppt, akpm, geert+renesas, keescook, linux-kernel,
	linux-arm-kernel

On Sun, 12 May 2019 at 13:51, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix gcc warnings:
>
> arch/arm/mm/init.c: In function 'mem_init':
> arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable]
>   extern u32 itcm_end;
>              ^
> arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable]
>   extern u32 dtcm_end;
>              ^
>
> They are not used any more since
> commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  arch/arm/mm/init.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Did you submit it to Russell's patch system?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: mm: remove unused variables
  2019-06-03 18:45 ` Krzysztof Kozlowski
@ 2019-06-04  2:08   ` Yuehaibing
  2019-06-04  6:19   ` YueHaibing
  1 sibling, 0 replies; 5+ messages in thread
From: Yuehaibing @ 2019-06-04  2:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux, rppt, akpm, geert+renesas, keescook, linux-kernel,
	linux-arm-kernel

On 2019/6/4 2:45, Krzysztof Kozlowski wrote:
> On Sun, 12 May 2019 at 13:51, YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> Fix gcc warnings:
>>
>> arch/arm/mm/init.c: In function 'mem_init':
>> arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable]
>>   extern u32 itcm_end;
>>              ^
>> arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable]
>>   extern u32 dtcm_end;
>>              ^
>>
>> They are not used any more since
>> commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  arch/arm/mm/init.c | 6 ------
>>  1 file changed, 6 deletions(-)
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Did you submit it to Russell's patch system?

Thanks for your reminder, I will send it.

> 
> Best regards,
> Krzysztof
> 
> .
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: mm: remove unused variables
  2019-06-03 18:45 ` Krzysztof Kozlowski
  2019-06-04  2:08   ` Yuehaibing
@ 2019-06-04  6:19   ` YueHaibing
  1 sibling, 0 replies; 5+ messages in thread
From: YueHaibing @ 2019-06-04  6:19 UTC (permalink / raw)
  To: patches
  Cc: linux-kernel, geert+renesas, keescook, linux-arm-kernel, akpm,
	rppt, linux, geert, krzk, rmk+kernel, YueHaibing

Fix gcc warnings:

arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' [-Wunused-variable]
  extern u32 itcm_end;
             ^
arch/arm/mm/init.c:455:13: warning: unused variable 'dtcm_end' [-Wunused-variable]
  extern u32 dtcm_end;
             ^

They are not used any more since
commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")

Link: https://lkml.org/lkml/2019/5/12/82
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
---
KernelVersion: 5.2-rc5
 arch/arm/mm/init.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index be0b42937888..c71ecbb04db8 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -450,12 +450,6 @@ static void __init free_highpages(void)
  */
 void __init mem_init(void)
 {
-#ifdef CONFIG_HAVE_TCM
-	/* These pointers are filled in on TCM detection */
-	extern u32 dtcm_end;
-	extern u32 itcm_end;
-#endif
-
 	set_max_mapnr(pfn_to_page(max_pfn) - mem_map);
 
 	/* this will put all unused low memory onto the freelists */
-- 
2.20.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-06-04  6:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12 11:41 [PATCH] ARM: mm: remove unused variables YueHaibing
2019-05-13  6:20 ` Geert Uytterhoeven
2019-06-03 18:45 ` Krzysztof Kozlowski
2019-06-04  2:08   ` Yuehaibing
2019-06-04  6:19   ` YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).