LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Marek Behún" <kabel@kernel.org>,
	"Robin van der Gracht" <robin@protonic.nl>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Paul Burton" <paulburton@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-leds <linux-leds@vger.kernel.org>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support
Date: Fri, 13 Aug 2021 14:52:52 +0200	[thread overview]
Message-ID: <CAMuHMdVFOu6EXKqkiLgBp3n8Oujm+uSpFn-ximtp+37TOZSp9A@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VeNyHUmcU7GPnP8woRcDErDNQ5M3FHQGpLnhUoL5qTnLQ@mail.gmail.com>

Hi Andy,

On Thu, Aug 12, 2021 at 2:33 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wednesday, August 11, 2021, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> On Wed, Aug 11, 2021 at 12:48 PM Marek Behún <kabel@kernel.org> wrote:
>> > On Wed, 11 Aug 2021 11:57:59 +0200
>> > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> > > Instantiate a single LED based on the "led" subnode in DT.
>> > > This allows the user to control display brightness and blinking (backed
>> > > by hardware support) through the LED class API and triggers, and exposes
>> > > the display color.  The LED will be named
>> > > "auxdisplay:<color>:<function>".
>> > >
>> > > When running in dot-matrix mode and if no "led" subnode is found, the
>> > > driver falls back to the traditional backlight mode, to preserve
>> > > backwards compatibility.
>> > >
>> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> >
>> > Reviewed-by: Marek Behún <kabel@kernel.org>
>>
>> Thanks!
>>
>> > BTW, this driver does not need to depend on OF, methinks.
>> > The few instances of properties reading can be
>> > easily rewritten to device_* functions (from include/linux/property.h).
>> > The of_get_child_by_name() can become device_get_named_child_node().
>> >
>> > Geert, what do you think?
>>
>> Sure, that can be done later, when an ACPI user appears?
>
> Actually with PRP0001 approach any of compatible driver may be used onACPI platform. So, what you are saying can be interpreted the way “we don’t care about users on ACPI based platforms”. If it is the case, then it should be told explicitly.

I think you're interpreting too much ;-)
My point is simply:

>> The dependency on OF was pre-existing, and this series is already
>> at v5.

If any OF compatible driver can now be used on ACPI platforms, perhaps
this should be handled at the API level? I.e. the distinction between
OF and device properties should be dropped completely, and all drivers
be converted mechanically in one shot, instead of a gradual ad-hoc
conversion being sneaked in through other series like this one?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2021-08-13 12:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  9:57 [PATCH v5 00/19] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 01/19] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 02/19] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 03/19] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 04/19] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 05/19] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 06/19] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 07/19] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 08/19] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 09/19] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 10/19] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 11/19] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 12/19] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 13/19] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 14/19] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 15/19] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 16/19] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 17/19] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 18/19] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-08-11  9:57 ` [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-08-11 10:47   ` Marek Behún
2021-08-11 11:29     ` Geert Uytterhoeven
     [not found]       ` <CAHp75VeNyHUmcU7GPnP8woRcDErDNQ5M3FHQGpLnhUoL5qTnLQ@mail.gmail.com>
2021-08-13 12:52         ` Geert Uytterhoeven [this message]
2021-08-13 13:59           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVFOu6EXKqkiLgBp3n8Oujm+uSpFn-ximtp+37TOZSp9A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kabel@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=ojeda@kernel.org \
    --cc=paulburton@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --subject='Re: [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).