LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Conor Dooley <Conor.Dooley@microchip.com>,
	Atish Patra <atish.patra@wdc.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Bin Meng <bin.meng@windriver.com>
Subject: Re: [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
Date: Tue, 24 Aug 2021 17:46:03 +0200	[thread overview]
Message-ID: <CAMuHMdVi9EccyTK7KWqb-Box3PaaMkZ0GRFOszmHP6JsyvAzAg@mail.gmail.com> (raw)
In-Reply-To: <20210804123015.807929-2-bmeng.cn@gmail.com>

Hi Bin,

On Wed, Aug 4, 2021 at 2:30 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> U-Boot expects this alias to be in place in order to fix up the mac
> address of the ethernet node.
>
> Note on the Icicle Kit board, currently only emac1 is enabled so it
> becomes the 'ethernet0'.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> ---
>
> Changes in v2:
> - move the aliases node to board dts

Thanks for the update!

> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -14,6 +14,10 @@ / {
>         model = "Microchip PolarFire-SoC Icicle Kit";
>         compatible = "microchip,mpfs-icicle-kit";
>
> +       aliases {
> +               ethernet0 = &emac1;
> +       };
> +
>         chosen {
>                 stdout-path = &serial0;
>         };

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

BTW, is Ethernet working in Linux for you?
IP-Config is always timing out for me.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-08-24 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 12:30 [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-08-04 12:30 ` [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node Bin Meng
2021-08-24 15:46   ` Geert Uytterhoeven [this message]
2021-08-19  3:10 ` [PATCH v2 1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 Bin Meng
2021-08-24 15:41 ` Geert Uytterhoeven
2021-08-25  4:44 ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVi9EccyTK7KWqb-Box3PaaMkZ0GRFOszmHP6JsyvAzAg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=Conor.Dooley@microchip.com \
    --cc=atish.patra@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --subject='Re: [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).