From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192DBC4332D for ; Fri, 20 Mar 2020 09:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F04FC20739 for ; Fri, 20 Mar 2020 09:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727432AbgCTJPb (ORCPT ); Fri, 20 Mar 2020 05:15:31 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:46765 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbgCTJPa (ORCPT ); Fri, 20 Mar 2020 05:15:30 -0400 Received: by mail-ot1-f67.google.com with SMTP id 111so5243678oth.13; Fri, 20 Mar 2020 02:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=8x4focGPb4ERLGjucd62jlveYIVPZ0IBCjA7nXBe5yM=; b=sME/KImcjBxE/37hOQylbQP4HypdVVyIc3va3OtlqWKytWb1lJRvFntHZHme8p6h/R 6B3FF5CP0y9lCMox2fxr7Dmi57sspcvJv1B1zJUaliqEXvc3TR+Fe2e8b81piwYinsj2 cwd/IKP8goTMZaNU0gToUnbFBFl3KFgIyZuiVi0qJz2tmsWG0aI0x402XCpHPkdU0SeO Q92cSm6viNVU9kGW/n1VcAcWpNgEyQfubPJET3E2n7V1OD03QuzodcJqZGRc/hGVs0GL PfKXljaE0xDNqC1UoPPGkfn/JM3rtPazyp9lTO9jmSrPt+rqmIFLK2qu7UPIRSXSNPks jPmA== X-Gm-Message-State: ANhLgQ3OHt6fVwgDspHxVJNZ4972UanHIR9RYw2ppSK2V+fjHB/a/kqD v4VufE3IR7ArcMs8P0taNfddU0XvevI/himV5rp+wQ== X-Google-Smtp-Source: ADFU+vsYLnunQuvHtatOG7BsZ09H8JNgkdZkzpSDXVv4nRP0XZF8aXP6gXAbKfpS7Iv8xwSoBWNPpDjt9weJDu9tK5g= X-Received: by 2002:a9d:6a47:: with SMTP id h7mr6013558otn.297.1584695728515; Fri, 20 Mar 2020 02:15:28 -0700 (PDT) MIME-Version: 1.0 References: <20200319180125.GJ14585@pendragon.ideasonboard.com> <20200320084406.GB4344@pflmari> <20200320090339.GD4344@pflmari> In-Reply-To: <20200320090339.GD4344@pflmari> From: Geert Uytterhoeven Date: Fri, 20 Mar 2020 10:15:17 +0100 Message-ID: Subject: Re: [PATCH v2 07/10] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) To: Alex Riesen , Geert Uytterhoeven , Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, On Fri, Mar 20, 2020 at 10:03 AM Alex Riesen wrote: > Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100: > > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen wrote: > > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100: > > > > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote: > > > > > As the driver has some support for the audio interface of the device, > > > > > the bindings file should mention it. > > > > > > > @@ -16,6 +18,8 @@ Required Properties: > > > > > slave device on the I2C bus. The main address is mandatory, others are > > > > > optional and remain at default values if not specified. > > > > > > > > > > + - #clock-cells: must be <0> if the I2S port is used > > > > > > > > Wouldn't it be simpler to set it to 0 unconditionally ? > > > > > > Would it? If the port itself is optional, shouldn't the clock be an option > > > too? > > > > You'd be surprised how many board designers would consider this a cheap > > 12.288 MHz clock source, without using the I2S port ;-) > > Well, I am :-) > > Especially considering that the driver will not switch the MCLK pin aktive > (all I2S-related pins are tristate by default). OK, didn't consider that. But that still won't stop the hardware designer. E.g. on Lager, the clock input of the PMIC is tied to the clock line of an SPI bus, so to use that feature, the SPI clock must be kept running all the time, not just when doing a transfer. > And how do I require it to be set unconditionally? By just removing the > "if ..." part of the statement? Indeed. This is still the plain text binding, not yaml. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds