LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 0/2] of/unittest: Add reference count tests
Date: Wed, 4 Feb 2015 18:08:37 +0100	[thread overview]
Message-ID: <CAMuHMdXUbD=4cOa-2Dwzhpz9vYVzjpewx4Z2tcMhccVyrJbVHg@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+7rDCvNQoGVpnjAWwB6Yma6fkiY3YXOso+92iiLU7rEg@mail.gmail.com>

Hi Rob,

On Wed, Feb 4, 2015 at 5:14 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Fri, Jan 23, 2015 at 10:10 AM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> This patch series adds tests to detect reference count imbalances.
>> The tests use a fixed list of paths to devices nodes (required device
>> nodes in a minimal DTS, and device nodes present in unittest-data).
>> I considered scanning for all present device node instead, but these
>> are more likely to change while running the test.
>>
>> These tests are executed only if CONFIG_OF_DYNAMIC=y.
>>
>> Patches are against devicetree/next, with "[PATCH] of: Add missing
>> of_node_put() in of_find_node_by_path()" (or the alternative proposed
>> by Grant) applied.
>>
>> Note that it shows 44 failures, which I haven't investigated yet:
>
> Do you plan to?

Maybe. It doesn't have such a high priority in my task list...

> While this could find problems in the unittests or the core OF code,
> the vast majority of the problems are likely in the users and this
> doesn't help with those. This whole issue of ref counts has been
> discussed some and probably needs to be redesigned or instrumented in
> a way that users can validate. But then it is pretty low priority
> given that ref counts only matter on pseries.

I agree most issues are in the users.
However, I did find one issue in the core code.

Note that the reference counts may become more important in the future,
as OF_OVERLAY selects OF_DYNAMIC.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2015-02-04 17:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 16:10 Geert Uytterhoeven
2015-01-23 16:10 ` [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST Geert Uytterhoeven
2015-03-20 12:25   ` Grant Likely
2015-03-20 13:32     ` Rob Herring
2015-03-24 22:54       ` Grant Likely
2015-03-25 14:14         ` Geert Uytterhoeven
2015-01-23 16:10 ` [PATCH RFC 2/2] of/unittest: Add reference count tests Geert Uytterhoeven
2015-02-04 16:14 ` [PATCH RFC 0/2] " Rob Herring
2015-02-04 17:08   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXUbD=4cOa-2Dwzhpz9vYVzjpewx4Z2tcMhccVyrJbVHg@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --subject='Re: [PATCH RFC 0/2] of/unittest: Add reference count tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).