LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-06-07  9:55 Marius Cirsta
  0 siblings, 0 replies; 8+ messages in thread
From: Marius Cirsta @ 2021-06-07  9:55 UTC (permalink / raw)
  To: almaz.alexandrovich
  Cc: aaptel, andy.lavr, anton, dan.carpenter, dsterba, ebiggers, hch,
	joe, kari.argillander, linux-fsdevel, linux-kernel,
	linux-ntfs-dev, mark, nborisov, oleksandr, pali, rdunlap, viro,
	willy

I am just a user of the kernel but for me the ntfs support is really
important as I have shared drives that are in NTFS format and ntfs-3g
is not really the best as it has a high CPU usage.

What happened to this review ? I am not sure what the process is but
is no one really interested ?

I saw there were some comments initially but if those were solved then
is it ready for integration ? Is more testing required? I could help
with that if needed.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-07-28 16:23 Mohammad Rasim
  0 siblings, 0 replies; 8+ messages in thread
From: Mohammad Rasim @ 2021-07-28 16:23 UTC (permalink / raw)
  To: yanp.bugz
  Cc: aaptel, almaz.alexandrovich, andy.lavr, anton, dan.carpenter,
	dsterba, ebiggers, hch, joe, kari.argillander, linux-fsdevel,
	linux-kernel, linux-ntfs-dev, mark, nborisov, oleksandr, pali,
	rdunlap, viro, willy

Hi,

I've been using your ntfs driver for sometime now and it's great to 
finally have a good driver for this FS, however i have problem where if 
the power cuts off from my system while writing to the volume the 
partition gets corrupted, this is expected of course but the problem is 
that `ntfsfix` tool can't fix the partition and no matter how many times 
i run it the system will always spits this in the kernel log when trying 
to mount the partition:

     ntfs3: sdb1: volume is dirty and "force" flag is not set!

if i boot to a windows 10 OS then the system is able to mount the volume 
with no problem(even before running chkdsk on it), windows `chkdsk` 
utility can find the errors and fix them, and i can reboot to linux to 
use my partition again with no problem.

it would be nice to have your filesystem utilites published on github so 
we can use them with the current out of the tree driver


Regards


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
  2021-04-02 15:53 Konstantin Komarov
                   ` (2 preceding siblings ...)
  2021-07-17 16:36 ` Pali Rohár
@ 2021-07-25 17:02 ` Yan Pas
  3 siblings, 0 replies; 8+ messages in thread
From: Yan Pas @ 2021-07-25 17:02 UTC (permalink / raw)
  To: Konstantin Komarov, linux-fsdevel
  Cc: viro, linux-kernel, pali, dsterba, aaptel, willy, rdunlap, joe,
	mark, nborisov, linux-ntfs-dev, anton, dan.carpenter, hch,
	ebiggers, andy.lavr, kari.argillander, oleksandr

Hi everyone!

I'm regular Arch-linux user and have been using your driver for a while
(https://aur.archlinux.org/packages/ntfs3-dkms/). There are a lot of
users who tested this patch and some of them, like me, have complaints.

I faced stalling of a kthread with some ntfs functions in a stacktrace
while rsyncing one NTFS partition (SATA) to another (USB HDD)
(https://aur.archlinux.org/packages/ntfs3-dkms/#comment-818819):

[ 5529.507567] INFO: task kworker/0:1:18 blocked for more than 1105 seconds.
[ 5529.507580]       Tainted: P           OE     5.13.4-arch1-1 #1
[ 5529.507584] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
disables this message.
[ 5529.507586] task:kworker/0:1     state:D stack:    0 pid:   18
ppid:     2 flags:0x00004000
[ 5529.507598] Workqueue: usb_hub_wq hub_event
[ 5529.507612] Call Trace:
[ 5529.507615]  ? out_of_line_wait_on_bit_lock+0xb0/0xb0
[ 5529.507631]  __schedule+0x310/0x930
[ 5529.507641]  ? out_of_line_wait_on_bit_lock+0xb0/0xb0
[ 5529.507648]  schedule+0x5b/0xc0
[ 5529.507654]  bit_wait+0xd/0x60
[ 5529.507661]  __wait_on_bit+0x2a/0x90
[ 5529.507669]  __inode_wait_for_writeback+0xb0/0xe0
[ 5529.507680]  ? var_wake_function+0x20/0x20
[ 5529.507689]  writeback_single_inode+0x64/0x140
[ 5529.507699]  sync_inode_metadata+0x3d/0x60
[ 5529.507712]  ntfs_set_state+0x126/0x1a0 [ntfs3]
[ 5529.507738]  ni_write_inode+0x244/0xef0 [ntfs3]
[ 5529.507764]  ? pagevec_lookup_range_tag+0x24/0x30
[ 5529.507772]  ? __filemap_fdatawait_range+0x6f/0xf0
[ 5529.507785]  __writeback_single_inode+0x260/0x310
[ 5529.507795]  writeback_single_inode+0xa7/0x140
[ 5529.507803]  sync_inode_metadata+0x3d/0x60
[ 5529.507814]  ntfs_set_state+0x126/0x1a0 [ntfs3]
[ 5529.507834]  ntfs_sync_fs+0xf9/0x100 [ntfs3]
[ 5529.507857]  sync_filesystem+0x40/0x90
[ 5529.507868]  fsync_bdev+0x21/0x60
[ 5529.507874]  delete_partition+0x13/0x80
[ 5529.507882]  blk_drop_partitions+0x5b/0xa0
[ 5529.507889]  del_gendisk+0xa5/0x220

...


Also adding ntfs3 partition (1.4TB) to fstab makes booting much slower:
I see two lines in console (systemd version and some other line) and HDD
led constantly flickering (seems like ntfs3 is traversing entire
partition)
(https://aur.archlinux.org/pkgbase/ntfs3-dkms/edit-comment/?comment_id=818673).

Regards, Yan.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
  2021-04-02 15:53 Konstantin Komarov
  2021-05-19  3:47 ` Neal Gompa
  2021-05-20 16:13 ` Darrick J. Wong
@ 2021-07-17 16:36 ` Pali Rohár
  2021-07-25 17:02 ` Yan Pas
  3 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2021-07-17 16:36 UTC (permalink / raw)
  To: Konstantin Komarov
  Cc: linux-fsdevel, viro, linux-kernel, dsterba, aaptel, willy,
	rdunlap, joe, mark, nborisov, linux-ntfs-dev, anton,
	dan.carpenter, hch, ebiggers, andy.lavr, kari.argillander,
	oleksandr

Hello!

I would like to remind that there are still two open questions about
this ntfs driver which needs to be resolved by vfs maintainers (Al?)
prior merging / accepting this driver into kernel tree.

1) Should this new ntfs driver use and implement old FAT ioctl calls?
These ioctls are added in patch: Add file operations and implementation.
First time I wrote about them in email:
https://lore.kernel.org/linux-fsdevel/20200921133647.3tczqm5zfvae6q6a@pali/

2) Should kernel have two ntfs drivers? And if yes, how they would
interact to userspace? Both Christoph and me think that not, see email:
https://lore.kernel.org/linux-fsdevel/20201031085142.GA5949@lst.de/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
  2021-04-02 15:53 Konstantin Komarov
  2021-05-19  3:47 ` Neal Gompa
@ 2021-05-20 16:13 ` Darrick J. Wong
  2021-07-17 16:36 ` Pali Rohár
  2021-07-25 17:02 ` Yan Pas
  3 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2021-05-20 16:13 UTC (permalink / raw)
  To: Konstantin Komarov
  Cc: linux-fsdevel, viro, linux-kernel, pali, dsterba, aaptel, willy,
	rdunlap, joe, mark, nborisov, linux-ntfs-dev, anton,
	dan.carpenter, hch, ebiggers, andy.lavr, kari.argillander,
	oleksandr

On Fri, Apr 02, 2021 at 06:53:37PM +0300, Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
> 
> Having decades of expertise in commercial file systems development and huge
> test coverage, we at Paragon Software GmbH want to make our contribution to
> the Open Source Community by providing implementation of NTFS Read-Write
> driver for the Linux Kernel.
> 
> This is fully functional NTFS Read-Write driver. Current version works with
> NTFS(including v3.1) and normal/compressed/sparse files and supports journal replaying.
> 
> We plan to support this version after the codebase once merged, and add new
> features and fix bugs.

Questions for the ntfs3 maintainer(s):

1. What happens when you run ntfs3 through fstests with '-g all'?  I get
that the pass rate isn't going to be as high with ntfs3 as it is with
ext4/xfs/btrfs, but fstests can be adapted (see the recent attempts to
get exfat under test).

(And yes, not all the fstests will pass, since some of them are random
exercisers that we use to keep the bug backlog populated.  We can help
you figure out which tests are erratic like that).

2. Same question as #1, except for whatever internal QA suite Paragon
has used to qualify the ntfs3 driver over the years.  (If you haven't
been using fstests this whole time.)

3. If you (Paragon) do have an internal QA suite, are you willing to
contribute some of that to fstests to improve its ability to exercise
whatever features and quirks are unique to NTFS?

4. How often do you run QA validation (of any kind) on the ntfs3
codebase?

In case you're wondering why I ask these questions, my motivation is
in figuring out how easy it will be to extend QA coverage to the
community supported QA suite (fstests) so that people making treewide
and vfs level changes can check that their changes don't bitrot your
driver, and vice-versa.  My primary interest leans towards convincing
everyone to value QA and practice it regularly (aka sharing the load so
it's not entirely up to the maintainer to catch all problems) vs.
finding every coding error as a gate condition for merging.

As another fs maintainer, I know that this is key to preventing fs
drivers from turning into a rotting garbage fire, and probably the best
I can do for a review of ntfs3 since I don't anticipate having time for
a super-detailed review and you've been submitting this driver for a
while now.

After this gets merged, fixing the code warts and cognitive mismatches
with the vfs/mm apis becomes your problem. ;)  Oh, that brings me to my
last question:

5. Are you retiring the old ntfs driver too?

> For example, full journaling support over JBD will be
> added in later updates.

I remember jbd2.  Yikes. ;)

Anyway I'll try to do a once-over code scan while I procrastinate on
higher priority things. :P

--D

> 
> v2:
>  - patch splitted to chunks (file-wise)
>  - build issues fixed
>  - sparse and checkpatch.pl errors fixed
>  - NULL pointer dereference on mkfs.ntfs-formatted volume mount fixed
>  - cosmetics + code cleanup
> 
> v3:
>  - added acl, noatime, no_acs_rules, prealloc mount options
>  - added fiemap support
>  - fixed encodings support
>  - removed typedefs
>  - adapted Kernel-way logging mechanisms
>  - fixed typos and corner-case issues
> 
> v4:
>  - atomic_open() refactored
>  - code style updated
>  - bugfixes
> 
> v5:
> - nls/nls_alt mount options added
> - Unicode conversion fixes
> - Improved very fragmented files operations
> - logging cosmetics
> 
> v6:
> - Security Descriptors processing changed
>   added system.ntfs_security xattr to set
>   SD
> - atomic_open() optimized
> - cosmetics
> 
> v7:
> - Security Descriptors validity checks added (by Mark Harmstone)
> - atomic_open() fixed for the compressed file creation with directio
>   case
> - remount support
> - temporarily removed readahead usage
> - cosmetics
> 
> v8:
> - Compressed files operations fixed
> 
> v9:
> - Further cosmetics applied as suggested
> by Joe Perches
> 
> v10:
> - operations with compressed/sparse files on very fragmented volumes improved
> - reduced memory consumption for above cases
> 
> v11:
> - further compressed files optimizations: reads/writes are now skipping bufferization
> - journal wipe to the initial state optimized (bufferization is also skipped)
> - optimized run storage (re-packing cluster metainformation)
> - fixes based on Matthew Wilcox feedback to the v10
> - compressed/sparse/normal could be set for empty files with 'system.ntfs_attrib' xattr
> 
> v12:
> - nls_alt mount option removed after discussion with Pali Rohar
> - fixed ni_repack()
> - fixed resident files transition to non-resident when size increasing
> 
> v13:
> - nested_lock fix (lockdep)
> - out-of-bounds read fix (KASAN warning)
> - resident->nonresident transition fixed for compressed files
> - load_nls() missed fix applied
> - some sparse utility warnings fixes
> 
> v14:
> - support for additional compression types (we've adapted WIMLIB's
>   implementation, authored by Eric Biggers, into ntfs3)
> 
> v15:
> - kernel test robot warnings fixed
> - lzx/xpress compression license headers updated
> 
> v16:
> - lzx/xpress moved to initial ntfs-3g plugin code
> - mutexes instead of a global spinlock for compresions
> - FALLOC_FL_PUNCH_HOLE and FALLOC_FL_COLLAPSE_RANGE implemented
> - CONFIG_NTFS3_FS_POSIX_ACL added
> 
> v17:
> - FALLOC_FL_COLLAPSE_RANGE fixed
> - fixes for Mattew Wilcox's and Andy Lavr's concerns
> 
> v18:
> - ntfs_alloc macro splitted into two ntfs_malloc + ntfs_zalloc
> - attrlist.c: always use ntfs_cmp_names instead of memcmp; compare entry names
>   only for entry with vcn == 0
> - dir.c: remove unconditional ni_lock in ntfs_readdir
> - fslog.c: corrected error case behavior
> - index.c: refactored due to modification of ntfs_cmp_names; use rw_semaphore
>   for read/write access to alloc_run and bitmap_run while ntfs_readdir
> - run.c: separated big/little endian code in functions
> - upcase.c: improved ntfs_cmp_names, thanks to Kari Argillander for idea
>   and 'bothcase' implementation
> 
> v19:
> - fixed directory bitmap for 2MB cluster size
> - fixed rw_semaphore init for directories
> 
> v20:
> - fixed issue with incorrect hidden/system attribute setting on
>   root subdirectories
> - use kvmalloc instead of kmalloc for runs array
> - fixed index behavior on volumes with cluster size more than 4k
> - current build info is added into module info instead of printing on insmod
> 
> v21:
> - fixes for clang CFI checks
> - fixed sb->s_maxbytes for 32bit clusters
> - user.DOSATTRIB is no more intercepted by ntfs3
> - corrected xattr limits;  is used
> - corrected CONFIG_NTFS3_64BIT_CLUSTER usage
> - info about current build is added into module info and printing
> on insmod (by Andy Lavr's request)
> note: v21 is applicable for 'linux-next' not older than 2021.01.28
> 
> v22:
> - ntfs_cmp_names() fixed
> - raise warning if 'nls->uni2char' fails
> - hot fix free clusters code optimized
> - use clang-format 11.0 instead of 10.0 to format code
> 
> v23:
> - corrections for Kernel Test Robot warnings
> - kmem_cache_create() utilized to allocate memory in bitmap.c
> - cosmetics and comments thru the code
> 
> v24:
> - BIO_MAX_PAGES -> BIO_MAX_VECS (fix for build issue of v23 vs linux-next)
> - minor optimization for LogFile: do not fill it with -1, if it's already there
> - index.c: removed 'inline' in definition of hdr_find_split() and hdr_insert_head()
> 
> v25:
> - restore fs/Makefile in patch
> - refactor ntfs_create_inode() to use error-valued pointer
> - use mi_get_ref to fill MFT_REF
> - minimize checkpatch.pl warnings: replace LogFile with \x24LogFile when printing
> 
> v26:
> - fixed coccinelle warnings
> - fslog.c: fix memory leak and memory overwrite
> 
> Konstantin Komarov (10):
>   fs/ntfs3: Add headers and misc files
>   fs/ntfs3: Add initialization of super block
>   fs/ntfs3: Add bitmap
>   fs/ntfs3: Add file operations and implementation
>   fs/ntfs3: Add attrib operations
>   fs/ntfs3: Add compression
>   fs/ntfs3: Add NTFS journal
>   fs/ntfs3: Add Kconfig, Makefile and doc
>   fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
>   fs/ntfs3: Add MAINTAINERS
> 
>  Documentation/filesystems/ntfs3.rst |  107 +
>  MAINTAINERS                         |    7 +
>  fs/Kconfig                          |    1 +
>  fs/Makefile                         |    1 +
>  fs/ntfs3/Kconfig                    |   46 +
>  fs/ntfs3/Makefile                   |   34 +
>  fs/ntfs3/attrib.c                   | 2082 +++++++++++
>  fs/ntfs3/attrlist.c                 |  456 +++
>  fs/ntfs3/bitfunc.c                  |  135 +
>  fs/ntfs3/bitmap.c                   | 1519 ++++++++
>  fs/ntfs3/debug.h                    |   64 +
>  fs/ntfs3/dir.c                      |  594 +++
>  fs/ntfs3/file.c                     | 1130 ++++++
>  fs/ntfs3/frecord.c                  | 3071 ++++++++++++++++
>  fs/ntfs3/fslog.c                    | 5181 +++++++++++++++++++++++++++
>  fs/ntfs3/fsntfs.c                   | 2542 +++++++++++++
>  fs/ntfs3/index.c                    | 2641 ++++++++++++++
>  fs/ntfs3/inode.c                    | 2033 +++++++++++
>  fs/ntfs3/lib/decompress_common.c    |  332 ++
>  fs/ntfs3/lib/decompress_common.h    |  352 ++
>  fs/ntfs3/lib/lib.h                  |   26 +
>  fs/ntfs3/lib/lzx_decompress.c       |  683 ++++
>  fs/ntfs3/lib/xpress_decompress.c    |  155 +
>  fs/ntfs3/lznt.c                     |  452 +++
>  fs/ntfs3/namei.c                    |  578 +++
>  fs/ntfs3/ntfs.h                     | 1238 +++++++
>  fs/ntfs3/ntfs_fs.h                  | 1085 ++++++
>  fs/ntfs3/record.c                   |  609 ++++
>  fs/ntfs3/run.c                      | 1111 ++++++
>  fs/ntfs3/super.c                    | 1500 ++++++++
>  fs/ntfs3/upcase.c                   |  105 +
>  fs/ntfs3/xattr.c                    | 1046 ++++++
>  32 files changed, 30916 insertions(+)
>  create mode 100644 Documentation/filesystems/ntfs3.rst
>  create mode 100644 fs/ntfs3/Kconfig
>  create mode 100644 fs/ntfs3/Makefile
>  create mode 100644 fs/ntfs3/attrib.c
>  create mode 100644 fs/ntfs3/attrlist.c
>  create mode 100644 fs/ntfs3/bitfunc.c
>  create mode 100644 fs/ntfs3/bitmap.c
>  create mode 100644 fs/ntfs3/debug.h
>  create mode 100644 fs/ntfs3/dir.c
>  create mode 100644 fs/ntfs3/file.c
>  create mode 100644 fs/ntfs3/frecord.c
>  create mode 100644 fs/ntfs3/fslog.c
>  create mode 100644 fs/ntfs3/fsntfs.c
>  create mode 100644 fs/ntfs3/index.c
>  create mode 100644 fs/ntfs3/inode.c
>  create mode 100644 fs/ntfs3/lib/decompress_common.c
>  create mode 100644 fs/ntfs3/lib/decompress_common.h
>  create mode 100644 fs/ntfs3/lib/lib.h
>  create mode 100644 fs/ntfs3/lib/lzx_decompress.c
>  create mode 100644 fs/ntfs3/lib/xpress_decompress.c
>  create mode 100644 fs/ntfs3/lznt.c
>  create mode 100644 fs/ntfs3/namei.c
>  create mode 100644 fs/ntfs3/ntfs.h
>  create mode 100644 fs/ntfs3/ntfs_fs.h
>  create mode 100644 fs/ntfs3/record.c
>  create mode 100644 fs/ntfs3/run.c
>  create mode 100644 fs/ntfs3/super.c
>  create mode 100644 fs/ntfs3/upcase.c
>  create mode 100644 fs/ntfs3/xattr.c
> 
> 
> base-commit: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
> -- 
> 2.25.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
  2021-05-19  3:47 ` Neal Gompa
@ 2021-05-19  3:51   ` Neal Gompa
  0 siblings, 0 replies; 8+ messages in thread
From: Neal Gompa @ 2021-05-19  3:51 UTC (permalink / raw)
  To: almaz.alexandrovich
  Cc: aaptel, andy.lavr, anton, dan.carpenter, David Sterba, ebiggers,
	Christoph Hellwig, joe, kari.argillander, linux-fsdevel,
	Linux Kernel Mailing List, linux-ntfs-dev, Mark Harmstone,
	nborisov, oleksandr, pali, rdunlap, Al Viro, Matthew Wilcox

On Tue, May 18, 2021 at 11:49 PM Neal Gompa <ngompa13@gmail.com> wrote:
>
> Hey all,
>
> I've been playing around with this patch set locally and it seems to work
> quite well. I haven't seen any replies from any bots or humans indicating
> that there might be anything wrong on the list or in Patchwork (which
> does not necessarily mean that there wasn't any feedback, I could equally
> be quite bad at finding responses!).
>
> Could someone please review this to see if it's finally suitable for
> upstream inclusion?
>

Oh, and I also forgot...

Tested-by: Neal Gompa <ngompa13@gmail.com>



-- 
真実はいつも一つ!/ Always, there's only one truth!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
  2021-04-02 15:53 Konstantin Komarov
@ 2021-05-19  3:47 ` Neal Gompa
  2021-05-19  3:51   ` Neal Gompa
  2021-05-20 16:13 ` Darrick J. Wong
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Neal Gompa @ 2021-05-19  3:47 UTC (permalink / raw)
  To: almaz.alexandrovich
  Cc: aaptel, andy.lavr, anton, dan.carpenter, dsterba, ebiggers, hch,
	joe, kari.argillander, linux-fsdevel, linux-kernel,
	linux-ntfs-dev, mark, nborisov, oleksandr, pali, rdunlap, viro,
	willy, Neal Gompa

Hey all,

I've been playing around with this patch set locally and it seems to work
quite well. I haven't seen any replies from any bots or humans indicating
that there might be anything wrong on the list or in Patchwork (which
does not necessarily mean that there wasn't any feedback, I could equally
be quite bad at finding responses!).

Could someone please review this to see if it's finally suitable for
upstream inclusion?

Thanks in advance and best regards,
Neal

-- 
真実はいつも一つ!/ Always, there's only one truth!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software
@ 2021-04-02 15:53 Konstantin Komarov
  2021-05-19  3:47 ` Neal Gompa
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Konstantin Komarov @ 2021-04-02 15:53 UTC (permalink / raw)
  To: linux-fsdevel
  Cc: viro, linux-kernel, pali, dsterba, aaptel, willy, rdunlap, joe,
	mark, nborisov, linux-ntfs-dev, anton, dan.carpenter, hch,
	ebiggers, andy.lavr, kari.argillander, oleksandr,
	Konstantin Komarov

This patch adds NTFS Read-Write driver to fs/ntfs3.

Having decades of expertise in commercial file systems development and huge
test coverage, we at Paragon Software GmbH want to make our contribution to
the Open Source Community by providing implementation of NTFS Read-Write
driver for the Linux Kernel.

This is fully functional NTFS Read-Write driver. Current version works with
NTFS(including v3.1) and normal/compressed/sparse files and supports journal replaying.

We plan to support this version after the codebase once merged, and add new
features and fix bugs. For example, full journaling support over JBD will be
added in later updates.

v2:
 - patch splitted to chunks (file-wise)
 - build issues fixed
 - sparse and checkpatch.pl errors fixed
 - NULL pointer dereference on mkfs.ntfs-formatted volume mount fixed
 - cosmetics + code cleanup

v3:
 - added acl, noatime, no_acs_rules, prealloc mount options
 - added fiemap support
 - fixed encodings support
 - removed typedefs
 - adapted Kernel-way logging mechanisms
 - fixed typos and corner-case issues

v4:
 - atomic_open() refactored
 - code style updated
 - bugfixes

v5:
- nls/nls_alt mount options added
- Unicode conversion fixes
- Improved very fragmented files operations
- logging cosmetics

v6:
- Security Descriptors processing changed
  added system.ntfs_security xattr to set
  SD
- atomic_open() optimized
- cosmetics

v7:
- Security Descriptors validity checks added (by Mark Harmstone)
- atomic_open() fixed for the compressed file creation with directio
  case
- remount support
- temporarily removed readahead usage
- cosmetics

v8:
- Compressed files operations fixed

v9:
- Further cosmetics applied as suggested
by Joe Perches

v10:
- operations with compressed/sparse files on very fragmented volumes improved
- reduced memory consumption for above cases

v11:
- further compressed files optimizations: reads/writes are now skipping bufferization
- journal wipe to the initial state optimized (bufferization is also skipped)
- optimized run storage (re-packing cluster metainformation)
- fixes based on Matthew Wilcox feedback to the v10
- compressed/sparse/normal could be set for empty files with 'system.ntfs_attrib' xattr

v12:
- nls_alt mount option removed after discussion with Pali Rohar
- fixed ni_repack()
- fixed resident files transition to non-resident when size increasing

v13:
- nested_lock fix (lockdep)
- out-of-bounds read fix (KASAN warning)
- resident->nonresident transition fixed for compressed files
- load_nls() missed fix applied
- some sparse utility warnings fixes

v14:
- support for additional compression types (we've adapted WIMLIB's
  implementation, authored by Eric Biggers, into ntfs3)

v15:
- kernel test robot warnings fixed
- lzx/xpress compression license headers updated

v16:
- lzx/xpress moved to initial ntfs-3g plugin code
- mutexes instead of a global spinlock for compresions
- FALLOC_FL_PUNCH_HOLE and FALLOC_FL_COLLAPSE_RANGE implemented
- CONFIG_NTFS3_FS_POSIX_ACL added

v17:
- FALLOC_FL_COLLAPSE_RANGE fixed
- fixes for Mattew Wilcox's and Andy Lavr's concerns

v18:
- ntfs_alloc macro splitted into two ntfs_malloc + ntfs_zalloc
- attrlist.c: always use ntfs_cmp_names instead of memcmp; compare entry names
  only for entry with vcn == 0
- dir.c: remove unconditional ni_lock in ntfs_readdir
- fslog.c: corrected error case behavior
- index.c: refactored due to modification of ntfs_cmp_names; use rw_semaphore
  for read/write access to alloc_run and bitmap_run while ntfs_readdir
- run.c: separated big/little endian code in functions
- upcase.c: improved ntfs_cmp_names, thanks to Kari Argillander for idea
  and 'bothcase' implementation

v19:
- fixed directory bitmap for 2MB cluster size
- fixed rw_semaphore init for directories

v20:
- fixed issue with incorrect hidden/system attribute setting on
  root subdirectories
- use kvmalloc instead of kmalloc for runs array
- fixed index behavior on volumes with cluster size more than 4k
- current build info is added into module info instead of printing on insmod

v21:
- fixes for clang CFI checks
- fixed sb->s_maxbytes for 32bit clusters
- user.DOSATTRIB is no more intercepted by ntfs3
- corrected xattr limits;  is used
- corrected CONFIG_NTFS3_64BIT_CLUSTER usage
- info about current build is added into module info and printing
on insmod (by Andy Lavr's request)
note: v21 is applicable for 'linux-next' not older than 2021.01.28

v22:
- ntfs_cmp_names() fixed
- raise warning if 'nls->uni2char' fails
- hot fix free clusters code optimized
- use clang-format 11.0 instead of 10.0 to format code

v23:
- corrections for Kernel Test Robot warnings
- kmem_cache_create() utilized to allocate memory in bitmap.c
- cosmetics and comments thru the code

v24:
- BIO_MAX_PAGES -> BIO_MAX_VECS (fix for build issue of v23 vs linux-next)
- minor optimization for LogFile: do not fill it with -1, if it's already there
- index.c: removed 'inline' in definition of hdr_find_split() and hdr_insert_head()

v25:
- restore fs/Makefile in patch
- refactor ntfs_create_inode() to use error-valued pointer
- use mi_get_ref to fill MFT_REF
- minimize checkpatch.pl warnings: replace LogFile with \x24LogFile when printing

v26:
- fixed coccinelle warnings
- fslog.c: fix memory leak and memory overwrite

Konstantin Komarov (10):
  fs/ntfs3: Add headers and misc files
  fs/ntfs3: Add initialization of super block
  fs/ntfs3: Add bitmap
  fs/ntfs3: Add file operations and implementation
  fs/ntfs3: Add attrib operations
  fs/ntfs3: Add compression
  fs/ntfs3: Add NTFS journal
  fs/ntfs3: Add Kconfig, Makefile and doc
  fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
  fs/ntfs3: Add MAINTAINERS

 Documentation/filesystems/ntfs3.rst |  107 +
 MAINTAINERS                         |    7 +
 fs/Kconfig                          |    1 +
 fs/Makefile                         |    1 +
 fs/ntfs3/Kconfig                    |   46 +
 fs/ntfs3/Makefile                   |   34 +
 fs/ntfs3/attrib.c                   | 2082 +++++++++++
 fs/ntfs3/attrlist.c                 |  456 +++
 fs/ntfs3/bitfunc.c                  |  135 +
 fs/ntfs3/bitmap.c                   | 1519 ++++++++
 fs/ntfs3/debug.h                    |   64 +
 fs/ntfs3/dir.c                      |  594 +++
 fs/ntfs3/file.c                     | 1130 ++++++
 fs/ntfs3/frecord.c                  | 3071 ++++++++++++++++
 fs/ntfs3/fslog.c                    | 5181 +++++++++++++++++++++++++++
 fs/ntfs3/fsntfs.c                   | 2542 +++++++++++++
 fs/ntfs3/index.c                    | 2641 ++++++++++++++
 fs/ntfs3/inode.c                    | 2033 +++++++++++
 fs/ntfs3/lib/decompress_common.c    |  332 ++
 fs/ntfs3/lib/decompress_common.h    |  352 ++
 fs/ntfs3/lib/lib.h                  |   26 +
 fs/ntfs3/lib/lzx_decompress.c       |  683 ++++
 fs/ntfs3/lib/xpress_decompress.c    |  155 +
 fs/ntfs3/lznt.c                     |  452 +++
 fs/ntfs3/namei.c                    |  578 +++
 fs/ntfs3/ntfs.h                     | 1238 +++++++
 fs/ntfs3/ntfs_fs.h                  | 1085 ++++++
 fs/ntfs3/record.c                   |  609 ++++
 fs/ntfs3/run.c                      | 1111 ++++++
 fs/ntfs3/super.c                    | 1500 ++++++++
 fs/ntfs3/upcase.c                   |  105 +
 fs/ntfs3/xattr.c                    | 1046 ++++++
 32 files changed, 30916 insertions(+)
 create mode 100644 Documentation/filesystems/ntfs3.rst
 create mode 100644 fs/ntfs3/Kconfig
 create mode 100644 fs/ntfs3/Makefile
 create mode 100644 fs/ntfs3/attrib.c
 create mode 100644 fs/ntfs3/attrlist.c
 create mode 100644 fs/ntfs3/bitfunc.c
 create mode 100644 fs/ntfs3/bitmap.c
 create mode 100644 fs/ntfs3/debug.h
 create mode 100644 fs/ntfs3/dir.c
 create mode 100644 fs/ntfs3/file.c
 create mode 100644 fs/ntfs3/frecord.c
 create mode 100644 fs/ntfs3/fslog.c
 create mode 100644 fs/ntfs3/fsntfs.c
 create mode 100644 fs/ntfs3/index.c
 create mode 100644 fs/ntfs3/inode.c
 create mode 100644 fs/ntfs3/lib/decompress_common.c
 create mode 100644 fs/ntfs3/lib/decompress_common.h
 create mode 100644 fs/ntfs3/lib/lib.h
 create mode 100644 fs/ntfs3/lib/lzx_decompress.c
 create mode 100644 fs/ntfs3/lib/xpress_decompress.c
 create mode 100644 fs/ntfs3/lznt.c
 create mode 100644 fs/ntfs3/namei.c
 create mode 100644 fs/ntfs3/ntfs.h
 create mode 100644 fs/ntfs3/ntfs_fs.h
 create mode 100644 fs/ntfs3/record.c
 create mode 100644 fs/ntfs3/run.c
 create mode 100644 fs/ntfs3/super.c
 create mode 100644 fs/ntfs3/upcase.c
 create mode 100644 fs/ntfs3/xattr.c


base-commit: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
-- 
2.25.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-28 16:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07  9:55 [PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software Marius Cirsta
  -- strict thread matches above, loose matches on Subject: below --
2021-07-28 16:23 Mohammad Rasim
2021-04-02 15:53 Konstantin Komarov
2021-05-19  3:47 ` Neal Gompa
2021-05-19  3:51   ` Neal Gompa
2021-05-20 16:13 ` Darrick J. Wong
2021-07-17 16:36 ` Pali Rohár
2021-07-25 17:02 ` Yan Pas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).