LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wanpeng Li <kernellwp@gmail.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Cornelia Huck" <cohuck@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Tonny Lu" <tonnylu@tencent.com>,
	"Janosch Frank" <frankja@linux.ibm.com>
Subject: Re: [PATCH v2] KVM: Extend MAX_IRQ_ROUTES to 4096 for all archs
Date: Mon, 23 Apr 2018 19:56:10 +0800	[thread overview]
Message-ID: <CANRm+Cyoufp89=orEMBst3uwLAn6gfuNkh4g80upM52NOLpDFw@mail.gmail.com> (raw)
In-Reply-To: <38e7d755-f95a-fcad-3f70-3a4eb049fc81@de.ibm.com>

2018-04-23 19:50 GMT+08:00 Christian Borntraeger <borntraeger@de.ibm.com>:
>
>
> On 04/21/2018 02:38 AM, Wanpeng Li wrote:
>> 2018-04-20 22:21 GMT+08:00 Cornelia Huck <cohuck@redhat.com>:
>>> On Fri, 20 Apr 2018 21:51:13 +0800
>>> Wanpeng Li <kernellwp@gmail.com> wrote:
>>>
>>>> 2018-04-20 15:15 GMT+08:00 Cornelia Huck <cohuck@redhat.com>:
>>>>> On Thu, 19 Apr 2018 17:47:28 -0700
>>>>> Wanpeng Li <kernellwp@gmail.com> wrote:
>>>>>
>>>>>> From: Wanpeng Li <wanpengli@tencent.com>
>>>>>>
>>>>>> Our virtual machines make use of device assignment by configuring
>>>>>> 12 NVMe disks for high I/O performance. Each NVMe device has 129
>>>>>> MSI-X Table entries:
>>>>>> Capabilities: [50] MSI-X: Enable+ Count=129 Masked-Vector table: BAR=0 offset=00002000
>>>>>> The windows virtual machines fail to boot since they will map the number of
>>>>>> MSI-table entries that the NVMe hardware reported to the bus to msi routing
>>>>>> table, this will exceed the 1024. This patch extends MAX_IRQ_ROUTES to 4096
>>>>>> for all archs, in the future this might be extended again if needed.
>>>>>>
>>>>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>>>>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>>>>>> Cc: Tonny Lu <tonnylu@tencent.com>
>>>>>> Cc: Cornelia Huck <cohuck@redhat.com>
>>>>>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>>>>>> Signed-off-by: Tonny Lu <tonnylu@tencent.com>
>>>>>> ---
>>>>>> v1 -> v2:
>>>>>>  * extend MAX_IRQ_ROUTES to 4096 for all archs
>>>>>>
>>>>>>  include/linux/kvm_host.h | 6 ------
>>>>>>  1 file changed, 6 deletions(-)
>>>>>>
>>>>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>>>>>> index 6930c63..0a5c299 100644
>>>>>> --- a/include/linux/kvm_host.h
>>>>>> +++ b/include/linux/kvm_host.h
>>>>>> @@ -1045,13 +1045,7 @@ static inline int mmu_notifier_retry(struct kvm *kvm, unsigned long mmu_seq)
>>>>>>
>>>>>>  #ifdef CONFIG_HAVE_KVM_IRQ_ROUTING
>>>>>>
>>>>>> -#ifdef CONFIG_S390
>>>>>>  #define KVM_MAX_IRQ_ROUTES 4096 //FIXME: we can have more than that...
>>>>>
>>>>> What about /* might need extension/rework in the future */ instead of
>>>>> the FIXME?
>>>>
>>>> Yeah, I guess the maintainers can help to fix it when applying. :)
>>>>
>>>>>
>>>>> As far as I understand, 4096 should cover most architectures and the
>>>>> sane end of s390 configurations, but will not be enough at the scarier
>>>>> end of s390. (I'm not sure how much it matters in practice.)
>>>>>
>>>>> Do we want to make this a tuneable in the future? Do some kind of
>>>>> dynamic allocation? Not sure whether it is worth the trouble.
>>>>
>>>> I think keep as it is currently.
>>>
>>> My main question here is how long this is enough... the number of
>>> virtqueues per device is up to 1K from the initial 64, which makes it
>>> possible to hit the 4K limit with fewer virtio devices than before (on
>>> s390, each virtqueue uses a routing table entry). OTOH, we don't want
>>> giant tables everywhere just to accommodate s390.
>>
>> I suspect there is no real scenario to futher extend for s390 since no
>> guys report.
>>
>>> If the s390 maintainers tell me that nobody is doing the really insane
>>> stuff, I'm happy as well :)
>>
>> Christian, any thoughts?
>
> For now this patch is a no-op for s390 so as long as nobody complains today we are good.
> If it turns out to be "not enough" we can then add a configurable number or whatever.

Thanks Christian. Paolo, could you pick this one w/ "/* might need
extension/rework in the future */ instead of
the FIXME" change or do you need I to send out a new version? :)

Regards,
Wanpeng Li

  reply	other threads:[~2018-04-23 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20  0:47 Wanpeng Li
2018-04-20  7:15 ` Cornelia Huck
2018-04-20 13:51   ` Wanpeng Li
2018-04-20 14:21     ` Cornelia Huck
2018-04-21  0:38       ` Wanpeng Li
2018-04-23 11:50         ` Christian Borntraeger
2018-04-23 11:56           ` Wanpeng Li [this message]
2018-04-23 11:57           ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANRm+Cyoufp89=orEMBst3uwLAn6gfuNkh4g80upM52NOLpDFw@mail.gmail.com' \
    --to=kernellwp@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tonnylu@tencent.com \
    --subject='Re: [PATCH v2] KVM: Extend MAX_IRQ_ROUTES to 4096 for all archs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).