LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Philippe Ombredanne <pombredanne@nexb.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Andreas Kemnade <andreas@kemnade.info>,
Johan Hovold <johan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define
Date: Fri, 17 Nov 2017 15:52:53 +0100 [thread overview]
Message-ID: <CAOFm3uHNZ6B0gMn5SbZbq9z_Mkv8syqMUFmrp0mGiARK-ei8WQ@mail.gmail.com> (raw)
In-Reply-To: <20171117141939.GD17880@kroah.com>
On Fri, Nov 17, 2017 at 3:19 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Johan Hovold <johan@kernel.org>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2017-11-17 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:19 [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define Greg Kroah-Hartman
2017-11-17 14:52 ` Philippe Ombredanne [this message]
2017-11-18 1:37 ` David Miller
2017-11-22 17:05 ` Joe Perches
2017-11-22 17:12 ` Greg Kroah-Hartman
2017-11-23 23:30 ` Joe Perches
2017-11-24 0:25 ` Joe Perches
2017-11-22 17:21 ` [Outreachy kernel] " Julia Lawall
2017-11-22 21:20 ` Julia Lawall
2017-11-23 6:22 ` Greg Kroah-Hartman
2017-11-23 7:31 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFm3uHNZ6B0gMn5SbZbq9z_Mkv8syqMUFmrp0mGiARK-ei8WQ@mail.gmail.com \
--to=pombredanne@nexb.com \
--cc=andreas@kemnade.info \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).