From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758700AbdKQOxn (ORCPT ); Fri, 17 Nov 2017 09:53:43 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:45651 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758608AbdKQOxf (ORCPT ); Fri, 17 Nov 2017 09:53:35 -0500 X-Google-Smtp-Source: AGs4zMbB7EbxDnPDKpbUwFxDZw3nqDvM/aOEcN6kyr6NgcwUXey6mbPFwDGDE+4pwAagcAptA8Mvu5L1Ui6knfXsyRg= MIME-Version: 1.0 In-Reply-To: <20171117141939.GD17880@kroah.com> References: <20171117141939.GD17880@kroah.com> From: Philippe Ombredanne Date: Fri, 17 Nov 2017 15:52:53 +0100 Message-ID: Subject: Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define To: Greg Kroah-Hartman Cc: netdev@vger.kernel.org, "David S. Miller" , Andreas Kemnade , Johan Hovold , LKML , linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2017 at 3:19 PM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference. > > Cc: "David S. Miller" > Cc: Andreas Kemnade > Cc: Johan Hovold > Reported-by: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Philippe Ombredanne -- Cordially Philippe Ombredanne