LKML Archive on
help / color / mirror / Atom feed
From: Ravi Chandra Sadineni <>
To: "Rafael J. Wysocki" <>
Cc: Ravi Chandra Sadineni <>,
	"Rafael J. Wysocki" <>,, Pavel Machek <>,
	Dmitry Torokhov <>,
	Len Brown <>,
	Greg Kroah-Hartman <>,
	Todd Broch <>,
	Linux Kernel Mailing List <>,
	Linux PM <>,
	Rajat Jain <>, Benson Leung <>
Subject: Re: [PATCH] power: Print wakeup_count instead of event_count in the sysfs attribute.
Date: Thu, 7 Jun 2018 09:47:24 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Rafeal,

Soft ping. Is this patch good to be merged ?


On Sun, Jun 3, 2018 at 10:14 AM, Ravi Chandra Sadineni
<> wrote:
> Hi Rafael,
> On Sun, Jun 3, 2018 at 1:05 AM, Rafael J. Wysocki <> wrote:
>> On Sat, Jun 2, 2018 at 4:32 AM, Ravi Chandra Sadineni
>> <> wrote:
>>> Currently we show event_count instead of wakeup_count as part of per
>>> device wakeup_count sysfs attribute. Change it to wakeup_count to make
>>> it more meaningful.
>> More information, please.
>> In particular, why it is more meaningful.
> Wakeup_count increments only when events_check_enabled is set. This
> bool is set whenever we write current wakeup count to
> /sys/power/wakeup_count from the user land. Also events_check_enabled
> is cleared on every resume. My understanding is that, userland is
> expected to write to this just before suspend. This way
> pm_wakeup_event() when called from irqs will increment the
> wakeup_count only if we are in system wide suspend resume cycle and
> should give a fair approximation of how many times a device might have
> caused a wake from S3/S0iX.  event_count on the other hand will
> increment every time pm_wakeup_event() is called irrespective of
> whether we are in a suspend/resume cycle.  For example when I try
> doing something like this (, we see
> the wakeup_count sysfs attribute for the particular device
> incrementing every time there is a irq. If it is important to expose
> event_count via sysfs attribute, should we create another attribute ?
> Also we do expose each of these counters via
> debugfs(/sys/kernel/debug/wake_sources).
> Please correct me if I am wrong or missing something. Also if there is
> a better way to do this, please let me know.
>> Thanks,
>> Rafael

  reply	other threads:[~2018-06-07 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02  2:32 Ravi Chandra Sadineni
2018-06-02 19:02 ` Pavel Machek
2018-06-03  8:05 ` Rafael J. Wysocki
2018-06-03 17:14   ` Ravi Chandra Sadineni
2018-06-07 16:47     ` Ravi Chandra Sadineni [this message]
2018-06-08  9:16       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] power: Print wakeup_count instead of event_count in the sysfs attribute.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).