LKML Archive on
help / color / mirror / Atom feed
From: Fabio Estevam <>
To: Stefan Agner <>
Cc: "Greg Kroah-Hartman" <>,
	"Uwe Kleine-König" <>,
	"Jiri Slaby" <>,,
	linux-kernel <>
Subject: Re: [PATCH] serial: imx: fix cached UCR2 read on software reset
Date: Thu, 19 Apr 2018 19:15:26 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Apr 16, 2018 at 12:35 PM, Stefan Agner <> wrote:
> To reset the UART the SRST needs be cleared (low active). According
> to the documentation the bit will remain active for 4 module clocks
> until it is cleared (set to 1).
> Hence the real register need to be read in case the cached register
> indcates that the SRST bit is zero.


> This bug lead to wrong baudrate because the baud rate register got
> restored before reset completed in imx_flush_buffer.
> Fixes: 3a0ab62f43de ("serial: imx: implement shadow registers for UCRx and UFCR")
> Signed-off-by: Stefan Agner <>

Reviewed-by: Fabio Estevam <>

      parent reply	other threads:[~2018-04-19 22:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 15:35 Stefan Agner
2018-04-19 21:37 ` Stefan Agner
2018-04-20  6:03   ` Uwe Kleine-König
2018-04-20  8:22     ` Stefan Agner
2018-04-19 22:15 ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] serial: imx: fix cached UCR2 read on software reset' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).