LKML Archive on
help / color / mirror / Atom feed
From: Fabio Estevam <>
To: Anson Huang <>
Cc: Shawn Guo <>,
	Sascha Hauer <>,
	Fabio Estevam <>,
	Rob Herring <>,
	Mark Rutland <>,
	Russell King - ARM Linux <>,
	dl-linux-imx <>,
	linux-kernel <>
Subject: Re: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support
Date: Thu, 26 Apr 2018 14:24:26 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Apr 26, 2018 at 3:31 AM, Anson Huang <> wrote:

> I searched the mail I sent, I can NOT found where I said "MAX7310 controls the ethernet phy"....

Initially you passed:  pinctrl-assert-gpios = <&max7322 0
GPIO_ACTIVE_HIGH> inside the fec1 node.

Then I explained that 'pinctrl-assert-gpios' is not a valid property
in mainline. It only exists in NXP vendor tree.

Then you explained:

"Sorry, I made a mistake here, the MAX7320 IO0 is for adjusting FEC1's voltage"

> There are MAX7310 users, it is just because currently those users are NOT enabled, so I can
> NOT verify them. MAX7310 is an independent I2C device, why we can NOT enable it first?
> I tested it from sysfs interface, we can control the MAX7310's IO output via echo different value
> to GPIO value, that means MAX7310 itself as an IO expander chip is working just fine, similar with PMIC,
> it is a I2C device, can be enabled independently, then consumers can be added later when they are enabled.
> Just my personal opinion, thanks.

Right, but if FEC needs max7322 IO0 at level 1 then better describe it in dts.

  reply	other threads:[~2018-04-26 17:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  5:36 [PATCH V4 1/6] ARM: dts: imx6sx-sabreauto: add PMIC support Anson Huang
2018-04-25  5:36 ` [PATCH V4 2/6] ARM: dts: imx6sx-sabreauto: add max7322 IO expander support Anson Huang
2018-04-25  5:36 ` [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support Anson Huang
2018-04-25 21:46   ` Fabio Estevam
2018-04-26  3:06     ` Anson Huang
2018-04-26  6:21       ` Fabio Estevam
2018-04-26  6:31         ` Anson Huang
2018-04-26 17:24           ` Fabio Estevam [this message]
2018-04-27  1:33             ` Anson Huang
2018-04-25  5:36 ` [PATCH V4 4/6] ARM: dts: imx6sx-sabreauto: add fec support Anson Huang
2018-04-25  5:36 ` [PATCH V4 5/6] ARM: dts: imx6sx-sabreauto: add wdog external reset support Anson Huang
2018-04-25  5:36 ` [PATCH V4 6/6] ARM: imx_v6_v7_defconfig: Select CONFIG_GPIO_MAX732X by default Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).