LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Curtis Malainey <cujomalainey@google.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Lukasz Majczak <lma@semihalf.com>,
upstream@semihalf.com,
ALSA development <alsa-devel@alsa-project.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Curtis Malainey <cujomalainey@chromium.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373
Date: Thu, 19 Aug 2021 12:56:40 -0700 [thread overview]
Message-ID: <CAOReqxiYYPgmAcN1RnVnOKziV+cnwD8nRCT_x3k7H3FeUW1SYA@mail.gmail.com> (raw)
In-Reply-To: <50eb6c88-5f1a-7a42-adaf-da16f711e5c5@linux.intel.com>
On Thu, Aug 19, 2021 at 8:18 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> >
> > Apart from that, Maxim codecs go by the name of 'max' in
> > sound/soc/codecs/. It's more intuitive to have equivalent shortcut used
> > in board's name.
>
> the ACPI HID start with MX and there's not much consistency in naming,
> is there?
>
> .drv_name = "kbl_r5514_5663_max",
> .drv_name = "kbl_rt5663_m98927",
> .drv_name = "kbl_da7219_mx98357a",
> .drv_name = "kbl_da7219_max98927",
> .drv_name = "kbl_max98373",
>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Agreed, it is definitely better to revisit and get it all in one go so
we don't end up with a cherry-picking nightmare
Acked-by: Curtis Malainey <cujomalainey@chromium.org>
prev parent reply other threads:[~2021-08-19 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 8:24 Lukasz Majczak
2021-08-19 14:30 ` Pierre-Louis Bossart
2021-08-19 15:06 ` Cezary Rojewski
2021-08-19 15:18 ` Pierre-Louis Bossart
2021-08-19 19:56 ` Curtis Malainey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOReqxiYYPgmAcN1RnVnOKziV+cnwD8nRCT_x3k7H3FeUW1SYA@mail.gmail.com \
--to=cujomalainey@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lma@semihalf.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=upstream@semihalf.com \
--subject='Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).