LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yu Zhao <yuzhao@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>, Yang Shi <shy828301@gmail.com>,
Zi Yan <ziy@nvidia.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Shuang Zhai <zhais@google.com>
Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp
Date: Sun, 8 Aug 2021 11:21:48 -0600 [thread overview]
Message-ID: <CAOUHufZYt+QbOmhrjXiwOAWXAXMYAzHy8gUas8MtzxJGNWqxAA@mail.gmail.com> (raw)
In-Reply-To: <YQkqMhGsra8YCVoU@casper.infradead.org>
On Tue, Aug 3, 2021 at 5:38 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote:
> > +++ b/include/linux/rmap.h
> > @@ -243,7 +243,7 @@ int page_mkclean(struct page *);
> > */
> > void page_mlock(struct page *page);
> >
> > -void remove_migration_ptes(struct page *old, struct page *new, bool locked);
> > +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean);
>
> I'm not a big fan of 'bool, bool'. Could we use a flag word instead?
>
> #define MIGRATE_REMOVE_LOCKED 1
> #define MIGRATE_UNMAP_CLEAN 2
Will do. Thanks.
next prev parent reply other threads:[~2021-08-08 17:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 6:39 [PATCH 0/3] mm: optimize thp for reclaim and migration Yu Zhao
2021-07-31 6:39 ` [PATCH 1/3] mm: don't take lru lock when splitting isolated thp Yu Zhao
2021-07-31 6:39 ` [PATCH 2/3] mm: free zapped tail pages " Yu Zhao
2021-08-04 14:22 ` Kirill A. Shutemov
2021-08-08 17:28 ` Yu Zhao
2021-08-05 0:13 ` Yang Shi
2021-08-08 17:49 ` Yu Zhao
2021-08-11 22:25 ` Yang Shi
2021-08-11 23:12 ` Yu Zhao
2021-08-13 23:24 ` Yang Shi
2021-08-13 23:56 ` Yu Zhao
2021-08-14 0:30 ` Yang Shi
2021-08-14 1:49 ` Yu Zhao
2021-08-14 2:34 ` Yang Shi
2021-07-31 6:39 ` [PATCH 3/3] mm: don't remap clean subpages " Yu Zhao
2021-07-31 9:53 ` kernel test robot
2021-07-31 15:45 ` kernel test robot
2021-08-03 11:25 ` Matthew Wilcox
2021-08-03 11:36 ` Matthew Wilcox
2021-08-08 17:21 ` Yu Zhao [this message]
2021-08-04 14:27 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOUHufZYt+QbOmhrjXiwOAWXAXMYAzHy8gUas8MtzxJGNWqxAA@mail.gmail.com \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=zhais@google.com \
--cc=ziy@nvidia.com \
--subject='Re: [PATCH 3/3] mm: don'\''t remap clean subpages when splitting isolated thp' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).