Re: [PATCH] ARM: at91: fix Kconfig.debug by adding DEBUG_AT91_UART option

[Olof Johansson <olof@lixom.net>]

Hi Nicolas,

On Tue, Jan 20, 2015 at 2:54 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> The DEBUG_AT91_UART Kconfig option was forgotten when moving the
> AT91 debug-macro.S file. Add it and use it for the at91.S compilation.
>
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Hi Alexandre,
> Please tell me if this patch makes sense to fix the lack of this
> DEBUG_AT91_UART Kconfig option.
>
> Paul,
> Thanks for the heads up.
>
> Bye,
>   Nico.
>
>  arch/arm/Kconfig.debug | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index e34d24949c6a..b3d388e5f4ff 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1164,12 +1164,15 @@ config DEBUG_STI_UART
>         bool
>         depends on ARCH_STI
>
> +config DEBUG_AT91_UART
> +       bool
> +       depends on ARCH_AT91
> +

This is not inserted in the list alphabetically. It's not very well
sorted today either, but it should probably go above exynos.

Also, there are a number of configs that _select_ DEBUG_AT91_UART in
the list above, but they don't depend on AT91. So what can happen is
that you can select those, and then they will enable this option
(which will spit out a warning about unfulfilled dependency).

You should probably make the choices that select this option also
depend on AT91?


-Olof