LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: kernel CI: printk loglevels in kernel boot logs?
Date: Wed, 22 Nov 2017 12:22:11 -0800	[thread overview]
Message-ID: <CAOi56cWif7n-j=2g0=wM_71YBtTf6T4hJbJJLz4zZriC1f4Jdw@mail.gmail.com> (raw)
In-Reply-To: <20171122123821.GA697@jagdpanzerIV>

On Wed, Nov 22, 2017 at 4:38 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (11/22/17 12:34), Petr Mladek wrote:
> [..]
>> > > > This is espeically useful when ingesting kernel logs into advanced
>> > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic
>> > > > Search, Logstash, Kibana).
> [..]
>> To make it clear. I understand that "show_loglevel" command line argument
>> would be useful for you. But I am afraid that it is not worth changing
>> the format. There would need to be wide interest into the change.
>> Also there would need to be evidence that the existing solutions
>> (dmesg --raw, console_loglevel) are not enough in many real life
>> scenarios.
>
> well, I think that that "consoles_format=syslog" command line parameter
> will be enabled only by those who actually want to have it - Fengguang's
> build robot and kernelCI (+ may be more setups).  so I'd probably assume
> there are low risks here. may be I'm wrong.

Agreed.  The goal of the command-line parameter is so that only
automation frameworks that would use it.

The other important reason for having this on the command line is that
for testing linux-next (and other bleeding edge developer branches),
it's common that we never make it to userspace, so can't even run
"dmesg --raw" (or equivalent.)  So we really want this on the primary
boot (serial) console.

> I think it makes sense to have syslog's format "<%u>[timestamp] text\n"
> on serial consoles (time stamp when PRINTK_TIME set; <%u> when
> consoles_format=syslog set).

Yes, I think it should match "dmesg --raw".

Kevin

  parent reply	other threads:[~2017-11-22 20:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOi56cVORdyjTXK4QGYRfyD1Q=QBgsU3B__gZT0xj6OBKaasLQ@mail.gmail.com>
     [not found] ` <20171122015610.x3kgzqgtwywlurmz@wfg-t540p.sh.intel.com>
2017-11-22  3:27   ` kernel CI: printk loglevels in kernel boot logs? Fengguang Wu
2017-11-22  5:26     ` Sergey Senozhatsky
2017-11-22 10:42       ` Mark Brown
2017-11-22 11:34     ` Petr Mladek
2017-11-22 12:38       ` Sergey Senozhatsky
2017-11-22 12:52         ` Fengguang Wu
2017-11-23  2:59           ` Sergey Senozhatsky
2017-11-23  3:14             ` Fengguang Wu
2017-11-23  4:31               ` Sergey Senozhatsky
2017-11-29  0:13             ` Kevin Hilman
2017-11-29  7:25               ` Sergey Senozhatsky
2017-11-30 17:45                 ` Kevin Hilman
2017-12-01  1:25                   ` Sergey Senozhatsky
2017-11-23 10:04           ` Petr Mladek
2017-11-22 20:22         ` Kevin Hilman [this message]
2017-11-22 14:10       ` Fengguang Wu
2017-12-05 15:55         ` Petr Mladek
2017-12-05 16:13           ` Sergey Senozhatsky
2017-12-05 20:54           ` Steven Rostedt
2017-12-06 13:54             ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOi56cWif7n-j=2g0=wM_71YBtTf6T4hJbJJLz4zZriC1f4Jdw@mail.gmail.com' \
    --to=khilman@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).