LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pintu Kumar <pintu.ping@gmail.com>
To: "Shuah Khan (Samsung OSG)" <shuah@kernel.org>
Cc: "Daniel Díaz" <daniel.diaz@linaro.org>,
	linux-kselftest@vger.kernel.org,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides
Date: Sat, 12 May 2018 21:42:10 +0530	[thread overview]
Message-ID: <CAOuPNLhZyWQfm=eK440suESciE-1q0Rpwx0nKHXWD2jxMZ74xw@mail.gmail.com> (raw)
In-Reply-To: <20180502211848.22404-1-shuah@kernel.org>

On Thu, May 3, 2018 at 2:48 AM, Shuah Khan (Samsung OSG)
<shuah@kernel.org> wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
> ---
>  tools/testing/selftests/android/Makefile | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile
> index f6304d2be90c..72c25a3cb658 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -18,10 +18,6 @@ all:
>                 fi \
>         done
>
> -override define RUN_TESTS
> -       @cd $(OUTPUT); ./run.sh
> -endef
> -
>  override define INSTALL_RULE
>         mkdir -p $(INSTALL_PATH)
>         install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
> @@ -33,10 +29,6 @@ override define INSTALL_RULE
>         done;
>  endef
>
> -override define EMIT_TESTS
> -       echo "./run.sh"
> -endef
> -
>  override define CLEAN
>         @for DIR in $(SUBDIRS); do              \
>                 BUILD_TARGET=$(OUTPUT)/$$DIR;   \
> --
> 2.14.1
>

OK.

Acked-by: Pintu Agarwal <pintu.ping@gmail.com>

---

Note: This mail goes into my spam email box.

      parent reply	other threads:[~2018-05-12 16:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 21:18 Shuah Khan (Samsung OSG)
2018-05-02 21:18 ` [PATCH] selftests: futex: " Shuah Khan (Samsung OSG)
2018-05-09  9:46   ` Anders Roxell
2018-05-11 15:13   ` Darren Hart
2018-05-11 15:25     ` Shuah Khan
2018-05-02 21:18 ` [PATCH] selftests: memory-hotplug: " Shuah Khan (Samsung OSG)
2018-05-09  9:46   ` Anders Roxell
2018-05-09 11:39   ` lei yang
2018-05-02 21:18 ` [PATCH] selftests: mount: " Shuah Khan (Samsung OSG)
2018-05-09  9:49   ` Anders Roxell
2018-05-02 21:18 ` [PATCH] selftests: mqueue: " Shuah Khan (Samsung OSG)
2018-05-09  9:49   ` Anders Roxell
2018-05-12 16:12 ` Pintu Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOuPNLhZyWQfm=eK440suESciE-1q0Rpwx0nKHXWD2jxMZ74xw@mail.gmail.com' \
    --to=pintu.ping@gmail.com \
    --cc=daniel.diaz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).