LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	Seungwon Jeon <tgih.jun@samsung.com>,
	Heiko Stuebner <heiko@sntech.de>, Chris Ball <chris@printf.net>,
	Doug Anderson <dianders@chromium.org>,
	Addy Ke <addy.ke@rock-chips.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p()
Date: Tue, 27 Jan 2015 14:59:15 +0100	[thread overview]
Message-ID: <CAPDyKFobsHLRVS_T5H1o2R1c6orFeKFgAsQA_akknvPur0UfzA@mail.gmail.com> (raw)
In-Reply-To: <20150124003009.GA14891@dtor-ws>

On 24 January 2015 at 01:30, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> dw_mci_pltfm_remove() is not (nor should it be) marked as __exit,
> so we should not be using __exit_p() wrapper with it.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks! Applied for next.

Kind regards
Uffe


> ---
>  drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 5650ac4..e2a726a 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
>
>  static struct platform_driver dw_mci_rockchip_pltfm_driver = {
>         .probe          = dw_mci_rockchip_probe,
> -       .remove         = __exit_p(dw_mci_pltfm_remove),
> +       .remove         = dw_mci_pltfm_remove,
>         .driver         = {
>                 .name           = "dwmmc_rockchip",
>                 .of_match_table = dw_mci_rockchip_match,
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry

      parent reply	other threads:[~2015-01-27 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24  0:30 Dmitry Torokhov
2015-01-26 20:50 ` Doug Anderson
2015-01-27 13:59 ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFobsHLRVS_T5H1o2R1c6orFeKFgAsQA_akknvPur0UfzA@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=addy.ke@rock-chips.com \
    --cc=chris@printf.net \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=tgih.jun@samsung.com \
    --subject='Re: [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).