LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Chris Ball <chris@printf.net>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2
Date: Thu, 29 Jan 2015 16:01:48 +0100	[thread overview]
Message-ID: <CAPDyKFohbn3yG9iuj7WbV0mDY4H4jZe3SgihGSdOqPLKkTMdZQ@mail.gmail.com> (raw)
In-Reply-To: <20150129151711.454100be@endymion.delvare>

On 29 January 2015 at 15:17, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Ulf,
>
> On Wed, 28 Jan 2015 15:04:24 +0100, Ulf Hansson wrote:
>> On 27 January 2015 at 15:34, Jean Delvare <jdelvare@suse.de> wrote:
>> > Hi Ulf,
>> >
>> > Le Tuesday 27 January 2015 à 15:06 +0100, Ulf Hansson a écrit :
>> >> On 26 January 2015 at 11:23, Jean Delvare <jdelvare@suse.de> wrote:
>> >> > I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
>> >> > only needed on the MMP architecture. So add a hardware dependency on
>> >> > ARCH_MMP, so that other users don't get to build useless drivers.
>> >>
>> >> I would rather see the default option to be N.
>> >> Thus those configurations that needs this driver will have to select it.
>> >
>> > This is a different question. The purpose of my patch is that people
>> > configuring kernels for systems which just can't have these controllers,
>> > are not asked about this driver at all. Changing the default to N would
>> > not achieve that.
>>
>> For those SOC that want these drivers, they should be able to select
>> them from their defconfigs. So it will be an opt-in instead of opt-out
>> policy, which I prefer. It also follows the other Kconfig options for
>> mmc drivers.
>
> As you wish. But that change would be a separate patch going on top of
> mine, right? I'm not sure I understand what you expect from me at this
> point, please clarify.

Sorry for being unclear. I don't like $subject patch.

Send a new one, removing the following lines:
default CPU_MMP2
default CPU_PXA910

Then you send another patch(es) to the respective SOC maintainer,
updating the defonfig(s) selecting MMC_SDHCI_PXAV3|PXAV2, when
appropriate.

Would that work?

Kind regards
Uffe

  reply	other threads:[~2015-01-29 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 10:23 Jean Delvare
2015-01-27 14:06 ` Ulf Hansson
2015-01-27 14:34   ` Jean Delvare
2015-01-28 14:04     ` Ulf Hansson
2015-01-29 14:17       ` Jean Delvare
2015-01-29 15:01         ` Ulf Hansson [this message]
2015-01-30  8:29           ` Jean Delvare
2015-01-30 10:43             ` Ulf Hansson
2015-01-30 12:00               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFohbn3yG9iuj7WbV0mDY4H4jZe3SgihGSdOqPLKkTMdZQ@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@printf.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --subject='Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).