LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Jérôme Pouiller" <Jerome.Pouiller@silabs.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Avri Altman <avri.altman@wdc.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bean Huo <beanhuo@micron.com>,
linux-mmc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com, Tony Lindgren <tony@atomide.com>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
Date: Thu, 28 Oct 2021 11:31:42 +0200 [thread overview]
Message-ID: <CAPDyKFouhj7V7n-7NSw=9-vLWqPvAmhUuZFVPR5Htw=aCLVZ_Q@mail.gmail.com> (raw)
In-Reply-To: <2013308.OSlt1BDEiP@pc-42>
[...]
> > Combining your suggestions we could do roughly:
> >
> > in mmc_sdio_init_card():
> >
> > if (host->ops->init_card)
> > host->ops->init_card(host, card);
> > else
> > mmc_fixup_device(host, sdio_prepare_fixups_methods);
>
> I think I mostly agree, but why you don't call mmc_fixup_device() if
> init_card is defined? (BTW, mmc_fixup_device() takes a card as
> first parameter)
Ack.
>
>
> > Next we need a location for the sdio_prepare_fixups_methods table and functions.
> >
> > For "ti,wl1251" we would then provide the entry in the table and a function doing
> > the setup. But where should these be defined? Likely not in a header file like
> > quirks.h? But there is no quirks.c.
>
> I think you can place your function in drivers/mmc/core/card.h. There are
> already add_quirk(), add_limit_rate_quirk(), add_quirk_mmc(), etc...
FYI: I don't mind adding a quirks.c, if that makes sense.
Kind regards
Uffe
next prev parent reply other threads:[~2021-10-28 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 11:25 H. Nikolaus Schaller
2021-10-26 17:12 ` Ulf Hansson
2021-10-26 18:08 ` H. Nikolaus Schaller
2021-10-27 17:00 ` H. Nikolaus Schaller
2021-10-27 21:31 ` Ulf Hansson
2021-10-28 7:08 ` H. Nikolaus Schaller
2021-10-28 8:59 ` Jérôme Pouiller
2021-10-28 9:31 ` Ulf Hansson [this message]
2021-10-28 9:40 ` H. Nikolaus Schaller
2021-10-28 9:43 ` H. Nikolaus Schaller
2021-10-28 9:51 ` Ulf Hansson
2021-10-28 9:55 ` Jérôme Pouiller
2021-10-28 10:07 ` H. Nikolaus Schaller
2021-11-01 9:12 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFouhj7V7n-7NSw=9-vLWqPvAmhUuZFVPR5Htw=aCLVZ_Q@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tony@atomide.com \
--subject='Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).