LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mmc: cqhci: Update cqhci memory ioresource name
@ 2020-03-04 12:00 Veerabhadrarao Badiganti
  2020-03-04 12:23 ` Adrian Hunter
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
  0 siblings, 2 replies; 8+ messages in thread
From: Veerabhadrarao Badiganti @ 2020-03-04 12:00 UTC (permalink / raw)
  To: adrian.hunter, ulf.hansson
  Cc: linux-mmc, linux-kernel, linux-arm-msm, dianders, mka,
	Veerabhadrarao Badiganti, Ritesh Harjani, Asutosh Das

Update cqhci memory ioresource name from cqhci_mem to cqhci since
suffix _mem is redundant.

Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
index e2ea2c4..e24b8ff 100644
--- a/drivers/mmc/host/cqhci.c
+++ b/drivers/mmc/host/cqhci.c
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 12:00 [PATCH] mmc: cqhci: Update cqhci memory ioresource name Veerabhadrarao Badiganti
@ 2020-03-04 12:23 ` Adrian Hunter
  2020-03-04 13:12   ` Veerabhadrarao Badiganti
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
  1 sibling, 1 reply; 8+ messages in thread
From: Adrian Hunter @ 2020-03-04 12:23 UTC (permalink / raw)
  To: Veerabhadrarao Badiganti, ulf.hansson
  Cc: linux-mmc, linux-kernel, linux-arm-msm, dianders, mka,
	Ritesh Harjani, Asutosh Das

On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.

Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
right?  So no one else could be using "cqhci_mem"? Some more explanation is
needed here.

> 
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>  
>  	/* check and setup CMDQ interface */
>  	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -						   "cqhci_mem");
> +						   "cqhci");
>  	if (!cqhci_memres) {
>  		dev_dbg(&pdev->dev, "CMDQ not supported\n");
>  		return ERR_PTR(-EINVAL);
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 12:23 ` Adrian Hunter
@ 2020-03-04 13:12   ` Veerabhadrarao Badiganti
  0 siblings, 0 replies; 8+ messages in thread
From: Veerabhadrarao Badiganti @ 2020-03-04 13:12 UTC (permalink / raw)
  To: Adrian Hunter, ulf.hansson
  Cc: linux-mmc, linux-kernel, linux-arm-msm, dianders, mka,
	Ritesh Harjani, Asutosh Das


On 3/4/2020 5:53 PM, Adrian Hunter wrote:
> On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
>> Update cqhci memory ioresource name from cqhci_mem to cqhci since
>> suffix _mem is redundant.
> Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
> right?  So no one else could be using "cqhci_mem"? Some more explanation is
> needed here.

Right, only qcom cqhci solution is making use of it.

I did a grep in dt and find no other vendor is using it.

Sure. Will update commit text.

>> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>> ---
>> Corresponding binding change:
>> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
>> ---
>>   drivers/mmc/host/cqhci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
>> index e2ea2c4..e24b8ff 100644
>> --- a/drivers/mmc/host/cqhci.c
>> +++ b/drivers/mmc/host/cqhci.c
>> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>>   
>>   	/* check and setup CMDQ interface */
>>   	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> -						   "cqhci_mem");
>> +						   "cqhci");
>>   	if (!cqhci_memres) {
>>   		dev_dbg(&pdev->dev, "CMDQ not supported\n");
>>   		return ERR_PTR(-EINVAL);
>>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 12:00 [PATCH] mmc: cqhci: Update cqhci memory ioresource name Veerabhadrarao Badiganti
  2020-03-04 12:23 ` Adrian Hunter
@ 2020-03-04 13:25 ` Veerabhadrarao Badiganti
  2020-03-04 14:02   ` Adrian Hunter
                     ` (3 more replies)
  1 sibling, 4 replies; 8+ messages in thread
From: Veerabhadrarao Badiganti @ 2020-03-04 13:25 UTC (permalink / raw)
  To: adrian.hunter, ulf.hansson
  Cc: linux-mmc, linux-kernel, linux-arm-msm, dianders, mka,
	Veerabhadrarao Badiganti, Ritesh Harjani, Asutosh Das

Update cqhci memory ioresource name from cqhci_mem to cqhci since
suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now.
No other vendor's driver is using it. So this update shouldn't affect
any other vendor's cqhci functionality.

Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/

Changes sicne V1:
	- Updated commit text expalining this change affects *only*
	  qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
index e2ea2c4..e24b8ff 100644
--- a/drivers/mmc/host/cqhci.c
+++ b/drivers/mmc/host/cqhci.c
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
@ 2020-03-04 14:02   ` Adrian Hunter
  2020-03-04 16:00   ` Doug Anderson
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Adrian Hunter @ 2020-03-04 14:02 UTC (permalink / raw)
  To: Veerabhadrarao Badiganti, ulf.hansson
  Cc: linux-mmc, linux-kernel, linux-arm-msm, dianders, mka,
	Ritesh Harjani, Asutosh Das

On 4/03/20 3:25 pm, Veerabhadrarao Badiganti wrote:
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
> 
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
> 
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
> 
> Changes sicne V1:
> 	- Updated commit text expalining this change affects *only*
> 	  qcom cqhci functionality.
> 
> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>  
>  	/* check and setup CMDQ interface */
>  	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -						   "cqhci_mem");
> +						   "cqhci");
>  	if (!cqhci_memres) {
>  		dev_dbg(&pdev->dev, "CMDQ not supported\n");
>  		return ERR_PTR(-EINVAL);
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
  2020-03-04 14:02   ` Adrian Hunter
@ 2020-03-04 16:00   ` Doug Anderson
  2020-03-09 18:30   ` Bjorn Andersson
  2020-03-11 15:34   ` Ulf Hansson
  3 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2020-03-04 16:00 UTC (permalink / raw)
  To: Veerabhadrarao Badiganti
  Cc: Adrian Hunter, Ulf Hansson, Linux MMC List, LKML, linux-arm-msm,
	Matthias Kaehlcke, Ritesh Harjani, Asutosh Das

Hi,

On Wed, Mar 4, 2020 at 5:25 AM Veerabhadrarao Badiganti
<vbadigan@codeaurora.org> wrote:
>
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
>
> Changes sicne V1:
>         - Updated commit text expalining this change affects *only*
>           qcom cqhci functionality.
>
> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

...now I guess the last thing is the dts change...

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
  2020-03-04 14:02   ` Adrian Hunter
  2020-03-04 16:00   ` Doug Anderson
@ 2020-03-09 18:30   ` Bjorn Andersson
  2020-03-11 15:34   ` Ulf Hansson
  3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2020-03-09 18:30 UTC (permalink / raw)
  To: Veerabhadrarao Badiganti
  Cc: adrian.hunter, ulf.hansson, linux-mmc, linux-kernel,
	linux-arm-msm, dianders, mka, Ritesh Harjani, Asutosh Das

On Wed 04 Mar 05:25 PST 2020, Veerabhadrarao Badiganti wrote:

> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
> 
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
> 
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>

I do favor using names without the "_mem" suffix and it seems like the
existing code only acquire the first two regions by index. So this
should be fine.

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>


But I do expect to see some patches fixing up the 8 dts files that now
has invalid reg-names.

Regards,
Bjorn

> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
> 
> Changes sicne V1:
> 	- Updated commit text expalining this change affects *only*
> 	  qcom cqhci functionality.
> 
> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>  
>  	/* check and setup CMDQ interface */
>  	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -						   "cqhci_mem");
> +						   "cqhci");
>  	if (!cqhci_memres) {
>  		dev_dbg(&pdev->dev, "CMDQ not supported\n");
>  		return ERR_PTR(-EINVAL);
> -- 
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name
  2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
                     ` (2 preceding siblings ...)
  2020-03-09 18:30   ` Bjorn Andersson
@ 2020-03-11 15:34   ` Ulf Hansson
  3 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2020-03-11 15:34 UTC (permalink / raw)
  To: Veerabhadrarao Badiganti
  Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List,
	linux-arm-msm, Doug Anderson, Matthias Kaehlcke, Ritesh Harjani,
	Asutosh Das

On Wed, 4 Mar 2020 at 14:25, Veerabhadrarao Badiganti
<vbadigan@codeaurora.org> wrote:
>
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
>
> Changes sicne V1:
>         - Updated commit text expalining this change affects *only*
>           qcom cqhci functionality.
>
> ---
>  drivers/mmc/host/cqhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>
>         /* check and setup CMDQ interface */
>         cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -                                                  "cqhci_mem");
> +                                                  "cqhci");
>         if (!cqhci_memres) {
>                 dev_dbg(&pdev->dev, "CMDQ not supported\n");
>                 return ERR_PTR(-EINVAL);
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-11 15:35 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 12:00 [PATCH] mmc: cqhci: Update cqhci memory ioresource name Veerabhadrarao Badiganti
2020-03-04 12:23 ` Adrian Hunter
2020-03-04 13:12   ` Veerabhadrarao Badiganti
2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
2020-03-04 14:02   ` Adrian Hunter
2020-03-04 16:00   ` Doug Anderson
2020-03-09 18:30   ` Bjorn Andersson
2020-03-11 15:34   ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).