LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Chris Ball <chris@printf.net>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2
Date: Fri, 30 Jan 2015 11:43:17 +0100	[thread overview]
Message-ID: <CAPDyKFq+Abjfyynnw+cQrEVUYKx1xwWtY9fr1mbKAMD502qjpw@mail.gmail.com> (raw)
In-Reply-To: <20150130092913.6256e517@endymion.delvare>

On 30 January 2015 at 09:29, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Ulf,
>
> On Thu, 29 Jan 2015 16:01:48 +0100, Ulf Hansson wrote:
>> On 29 January 2015 at 15:17, Jean Delvare <jdelvare@suse.de> wrote:
>> > On Wed, 28 Jan 2015 15:04:24 +0100, Ulf Hansson wrote:
>> >> For those SOC that want these drivers, they should be able to select
>> >> them from their defconfigs. So it will be an opt-in instead of opt-out
>> >> policy, which I prefer. It also follows the other Kconfig options for
>> >> mmc drivers.
>> >
>> > As you wish. But that change would be a separate patch going on top of
>> > mine, right? I'm not sure I understand what you expect from me at this
>> > point, please clarify.
>>
>> Sorry for being unclear. I don't like $subject patch.
>>
>> Send a new one, removing the following lines:
>> default CPU_MMP2
>> default CPU_PXA910
>>
>> Then you send another patch(es) to the respective SOC maintainer,
>> updating the defonfig(s) selecting MMC_SDHCI_PXAV3|PXAV2, when
>> appropriate.
>>
>> Would that work?
>
> Not really, I'm afraid.
>
> My proposed change affects users of non-embedded systems, or more
> generally everyone not on ARCH_MMP. I want to make their life easier by
> hiding options which are not relevant to them. I have sent several
> dozen of such patches in the past for various drivers, see for example
> the latest ones:
>   http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=441fb7684782be3553c67dc04defcf304b999bba
>   http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c03842d89b769db44be5cb0b1ebb384ccfa25f7f
>   http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=84c3a8f6eadb2bedfba10f62da0328d8533c8f25
> Also note that the MMC subsystem already has examples of this, check
> MMC_OMAP_HS, MMC_SDHCI_MSM, MMC_SDHI, MMC_DW and MMC_SH_MMCIF in
> drivers/mmc/host/Kconfig. I'm just doing more of the same, nothing new.
>
> The change you want, OTOH, would affect exclusively the ARCH_MMP users
> (of which I am not.) It is essentially unrelated with what I was
> originally talking about, except for the fact that it touches the same
> Kconfig entries. I have no idea if your proposal is a good idea, I am
> not dealing with embedded systems, and I have no idea who are the
> maintainers of the affected SOCs. This is simply not my area.
>
> So basically you are rejecting my proposal without a reason, and then
> you ask me to do an unrelated work instead. This is not fair, sorry.
>
> Don't get me wrong, I'm always ready to do some more work than I
> originally intended if that's what it takes to get my patches merged. I
> value code review and I welcome constructive criticism. But this time
> your request is not reasonable.

I did a little more of investigation of what's good practice/policy
around your suggested patch. I have changed my mind, I am going to
accept your patch as is.

Sorry for all the noise and thanks for a good discussion.

Applied for next. Thanks!

Kind regards
Uffe

  reply	other threads:[~2015-01-30 10:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 10:23 Jean Delvare
2015-01-27 14:06 ` Ulf Hansson
2015-01-27 14:34   ` Jean Delvare
2015-01-28 14:04     ` Ulf Hansson
2015-01-29 14:17       ` Jean Delvare
2015-01-29 15:01         ` Ulf Hansson
2015-01-30  8:29           ` Jean Delvare
2015-01-30 10:43             ` Ulf Hansson [this message]
2015-01-30 12:00               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFq+Abjfyynnw+cQrEVUYKx1xwWtY9fr1mbKAMD502qjpw@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@printf.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --subject='Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).