LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Lai Jason <jasonlai.genesyslogic@gmail.com>
Cc: "Adrian Hunter" <adrian.hunter@intel.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Ben Chuang" <ben.chuang@genesyslogic.com.tw>,
	"GregTu[杜啟軒]" <greg.tu@genesyslogic.com.tw>,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Jason Lai" <jason.lai@genesyslogic.com.tw>
Subject: Re: [RFC PATCH v3.2 00/29] Add support UHS-II for GL9755
Date: Fri, 6 Aug 2021 12:11:43 +0200	[thread overview]
Message-ID: <CAPDyKFqB4nxv5andQktNDjGkf-vPfbiFVwkZ7PGOWW9NbdM+qA@mail.gmail.com> (raw)
In-Reply-To: <CAG0XXUG5q8_o-A3K0LNVXoeJmXHn=N=uyR81p2ai0H827SeS4Q@mail.gmail.com>

On Fri, 6 Aug 2021 at 08:37, Lai Jason <jasonlai.genesyslogic@gmail.com> wrote:
>
> On Tue, 03 Aug 2021 at 12:23,   Ulf Hansson <ulf.hansson@linaro.org>  wrote:
> >
> > On Thu, 22 Jul 2021 at 07:14, Jason Lai <jasonlai.genesyslogic@gmail.com> wrote:
> > >
> > > Summary
> > > =======
> > > In these patches we focus on uhs2 side to address Ulf's suggestion which
> > > was mentioned in patch [mmc: core: Preparations to support SD UHS-II cards].
> > >
> > >
> > > I moved codes in uhs2.c to proper functions in sd_uhs2.c, which should meet
> > > Ulf's expection.
> > >
> > > Please review this series (particularly Patch 29/29).
> >
> > I think you have misunderstood the intent with the series that I
> > posted [1] a while ago. The idea was to add the foundation of what
> > should be needed in the mmc core to support UHS-II cards. Note, it's
> > only the foundation, not the complete code.
> >
> > In other words, I think you should base the next version of $subject
> > series *on top* of my series [1], rather than the opposite.
> >
> Actually, I understand your intention is to implement functions which
> can be applied to control all UHS-II cards.
> However, why do I choose to base it on “[RFC,v3.1,00/27] Add support
> UHS-II for GL9755”?
> Because it contains a complete UHS-II interface(both host & card side)
> and UHS-II card can work normally.

It doesn't matter if things "work".

The code/patches need to be better organized than currently,
especially the changes for the mmc core, which is why I stepped in and
tried to help out earlier. Otherwise it is impossible for me to review
the changes, but also to maintain the code in the long run.

The sdhci part is likely a bit more mature as it has been reviewed and
iterated with Adrian/Ben/Akashi-san. However, new/more changes needed
when my suggested changes for the mmc core come into play.

[...]

Kind regards
Uffe

      reply	other threads:[~2021-08-06 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  5:14 Jason Lai
2021-08-02 16:22 ` Ulf Hansson
2021-08-06  6:37   ` Lai Jason
2021-08-06 10:11     ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFqB4nxv5andQktNDjGkf-vPfbiFVwkZ7PGOWW9NbdM+qA@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=ben.chuang@genesyslogic.com.tw \
    --cc=greg.tu@genesyslogic.com.tw \
    --cc=jason.lai@genesyslogic.com.tw \
    --cc=jasonlai.genesyslogic@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=takahiro.akashi@linaro.org \
    --subject='Re: [RFC PATCH v3.2 00/29] Add support UHS-II for GL9755' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).