LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Chris Ball <chris@printf.net>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2
Date: Wed, 28 Jan 2015 15:04:24 +0100	[thread overview]
Message-ID: <CAPDyKFqWa0uyZStNT1Wp21HpSqYpfJx3wU3TDJy25uMgG7qZaw@mail.gmail.com> (raw)
In-Reply-To: <1422369244.4499.187.camel@chaos.site>

On 27 January 2015 at 15:34, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Ulf,
>
> Le Tuesday 27 January 2015 à 15:06 +0100, Ulf Hansson a écrit :
>> On 26 January 2015 at 11:23, Jean Delvare <jdelvare@suse.de> wrote:
>> > I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
>> > only needed on the MMP architecture. So add a hardware dependency on
>> > ARCH_MMP, so that other users don't get to build useless drivers.
>>
>> I would rather see the default option to be N.
>> Thus those configurations that needs this driver will have to select it.
>
> This is a different question. The purpose of my patch is that people
> configuring kernels for systems which just can't have these controllers,
> are not asked about this driver at all. Changing the default to N would
> not achieve that.

For those SOC that want these drivers, they should be able to select
them from their defconfigs. So it will be an opt-in instead of opt-out
policy, which I prefer. It also follows the other Kconfig options for
mmc drivers.

Kind regards
Uffe

>
> That being said, feel free to change the default to N if you want, but
> to me (who knows nothing about MMP architecture and not much about MMC)
> the current default values look sane.
>
> Thanks,
> Jean
>
>> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> > Cc: Chris Ball <chris@printf.net>
>> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> > Cc: Eric Miao <eric.y.miao@gmail.com>
>> > Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
>> > ---
>> > This patch was already sent on:
>> >  * 2014-04-23
>> >  * 2014-06-16
>> >
>> >  drivers/mmc/host/Kconfig |    2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > --- linux-3.19-rc6.orig/drivers/mmc/host/Kconfig        2015-01-26 10:30:56.472182636 +0100
>> > +++ linux-3.19-rc6/drivers/mmc/host/Kconfig     2015-01-26 11:13:33.669863314 +0100
>> > @@ -228,6 +228,7 @@ config MMC_SDHCI_PXAV3
>> >         tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
>> >         depends on CLKDEV_LOOKUP
>> >         depends on MMC_SDHCI_PLTFM
>> > +       depends on ARCH_MMP || COMPILE_TEST
>> >         default CPU_MMP2
>> >         help
>> >           This selects the Marvell(R) PXAV3 SD Host Controller.
>> > @@ -240,6 +241,7 @@ config MMC_SDHCI_PXAV2
>> >         tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
>> >         depends on CLKDEV_LOOKUP
>> >         depends on MMC_SDHCI_PLTFM
>> > +       depends on ARCH_MMP || COMPILE_TEST
>> >         default CPU_PXA910
>> >         help
>> >           This selects the Marvell(R) PXAV2 SD Host Controller.
>> >
>> >
>> > --
>> > Jean Delvare
>> > SUSE L3 Support
>

  reply	other threads:[~2015-01-29  1:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 10:23 Jean Delvare
2015-01-27 14:06 ` Ulf Hansson
2015-01-27 14:34   ` Jean Delvare
2015-01-28 14:04     ` Ulf Hansson [this message]
2015-01-29 14:17       ` Jean Delvare
2015-01-29 15:01         ` Ulf Hansson
2015-01-30  8:29           ` Jean Delvare
2015-01-30 10:43             ` Ulf Hansson
2015-01-30 12:00               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFqWa0uyZStNT1Wp21HpSqYpfJx3wU3TDJy25uMgG7qZaw@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@printf.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --subject='Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).